Menu update #24
Open
Menu update #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 20, 2020 15:31
Owner
|
Hey @Hai-tun, this for the PR, but, you can explain the changes that this PR does? |
Author
|
|
related errors: [13:49:45] [Server thread/WARN]: java.lang.ClassCastException: org.bukkit.craftbukkit.v1_16_R3.command.ColouredConsoleSender cannot be cast to org.bukkit.entity.Player [13:49:45] [Server thread/WARN]: at moe.orangemc.userservice.Main$onPluginEnable$5$1.invokeSuspend(Main.kt:83) [13:49:45] [Server thread/WARN]: at moe.orangemc.userservice.Main$onPluginEnable$5$1.invoke(Main.kt) [13:49:45] [Server thread/WARN]: at br.com.devsrsouza.kotlinbukkitapi.dsl.command.CommandDSL$execute$1$1.invokeSuspend(CommandDSL.kt:193) [13:49:45] [Server thread/WARN]: at br.com.devsrsouza.kotlinbukkitapi.dsl.command.CommandDSL$execute$1$1.invoke(CommandDSL.kt) [13:49:45] [Server thread/WARN]: at br.com.devsrsouza.kotlinbukkitapi.dsl.command.CommandDSL.treatFail(CommandDSL.kt:251) [13:49:45] [Server thread/WARN]: at br.com.devsrsouza.kotlinbukkitapi.dsl.command.CommandDSL$execute$1.invokeSuspend(CommandDSL.kt:192) [13:49:45] [Server thread/WARN]: at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) [13:49:45] [Server thread/WARN]: at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:56) [13:49:45] [Server thread/WARN]: at com.okkero.skedule.BukkitDispatcher.dispatch(BukkitDispatcher.kt:45) [13:49:45] [Server thread/WARN]: at kotlinx.coroutines.DispatchedContinuationKt.resumeCancellableWith(DispatchedContinuation.kt:288) [13:49:45] [Server thread/WARN]: at kotlinx.coroutines.intrinsics.CancellableKt.startCoroutineCancellable(Cancellable.kt:26) [13:49:45] [Server thread/WARN]: at kotlinx.coroutines.CoroutineStart.invoke(CoroutineStart.kt:109) [13:49:45] [Server thread/WARN]: at kotlinx.coroutines.AbstractCoroutine.start(AbstractCoroutine.kt:158) [13:49:45] [Server thread/WARN]: at kotlinx.coroutines.BuildersKt__Builders_commonKt.launch(Builders.common.kt:56) [13:49:45] [Server thread/WARN]: at kotlinx.coroutines.BuildersKt.launch(Unknown Source) [13:49:45] [Server thread/WARN]: at kotlinx.coroutines.BuildersKt__Builders_commonKt.launch$default(Builders.common.kt:49) [13:49:45] [Server thread/WARN]: at kotlinx.coroutines.BuildersKt.launch$default(Unknown Source) [13:49:45] [Server thread/WARN]: at br.com.devsrsouza.kotlinbukkitapi.dsl.command.CommandDSL.execute(CommandDSL.kt:190) [13:49:45] [Server thread/WARN]: at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:149) [13:49:45] [Server thread/WARN]: at org.bukkit.craftbukkit.v1_16_R3.CraftServer.dispatchCommand(CraftServer.java:763) [13:49:45] [Server thread/WARN]: at org.bukkit.craftbukkit.v1_16_R3.CraftServer.dispatchServerCommand(CraftServer.java:748) [13:49:45] [Server thread/WARN]: at net.minecraft.server.v1_16_R3.DedicatedServer.handleCommandQueue(DedicatedServer.java:387) [13:49:45] [Server thread/WARN]: at net.minecraft.server.v1_16_R3.DedicatedServer.b(DedicatedServer.java:356) [13:49:45] [Server thread/WARN]: at net.minecraft.server.v1_16_R3.MinecraftServer.a(MinecraftServer.java:1008) [13:49:45] [Server thread/WARN]: at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:847) [13:49:45] [Server thread/WARN]: at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$0(MinecraftServer.java:164) [13:49:45] [Server thread/WARN]: at java.lang.Thread.run(Thread.java:748)
Author
|
@DevSrSouza Add an executor priority fix |
Author
|
@DevSrSouza Plz, review code and merge. |
|
i think it would be better if you kept the |
Author
|
It seems to be able to improve compatibility by that way... but in fact, the signature of the method has changed due to the addition of parameters. So even if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade menu module