Add global namespace handling in interface generation and improve test coverage

Author: Nikolay Pianikov

build/Core/Targets/TestExamplesTarget.cs

@@ -33,6 +33,7 @@ public async Task<int> RunAsync(CancellationToken cancellationToken)
             File.Copy(Path.Combine(solutionDir, "tests", "Pure.DI.UsageTests", "Test.props"), Path.Combine(appDir, "Directory.Build.props"));
             var programFile = Path.Combine(appDir, "Program.cs");
             var example = properties["example"];
+            var failures = 0;
             foreach (var (_, groupExamples) in examples)
             {
                 foreach (var vars in groupExamples)
@@ -60,6 +61,7 @@ public async Task<int> RunAsync(CancellationToken cancellationToken)
 
                     if (result.ExitCode != 0)
                     {
+                        failures++;
                         WriteLine($"Test \"{description}\"", Color.Header);
                         foreach (var line in code.Split([Environment.NewLine], StringSplitOptions.None))
                         {
@@ -68,6 +70,11 @@ public async Task<int> RunAsync(CancellationToken cancellationToken)
                     }
                 }
             }
+
+            if (failures > 0)
+            {
+                return 1;
+            }
         }
         finally
         {
@@ -83,4 +90,4 @@ public async Task<int> RunAsync(CancellationToken cancellationToken)
     private static bool HasIntegrationTest(Example example) =>
         !example.TryGetValue(CreateExamplesTarget.IntegrationTestKey, out var integrationTestStr)
         || bool.TryParse(integrationTestStr, out var integrationTest) && integrationTest;
-}
+}

src/Pure.DI.Core/InterfaceGeneration/InterfaceBuilder.cs

@@ -49,7 +49,7 @@ public GeneratedInterfacesResult BuildInterfacesFor(
         }
 
         const string generateInterfaceAttributeFullName = $"{Names.GlobalNamespacePrefix}{Names.GenerateInterfaceAttributeFullName}";
-        var defaultNamespaceName = typeSymbol.ContainingNamespace.ToDisplayString();
+        var defaultNamespaceName = GetNamespaceName(typeSymbol.ContainingNamespace);
         var defaultInterfaceName = $"I{classSyntax.Identifier.Text}";
 
         var settingsByInterface = new Dictionary<InterfaceKey, (bool AsInternal, bool HasClassAttribute)>();
@@ -458,4 +458,7 @@ private static string GetInterfaceDisplayName(InterfaceKey key) =>
             ? key.InterfaceName
             : $"{key.NamespaceName}.{key.InterfaceName}";
 
+    private static string GetNamespaceName(INamespaceSymbol namespaceSymbol) =>
+        namespaceSymbol.IsGlobalNamespace ? string.Empty : namespaceSymbol.ToDisplayString();
+
 }

tests/Pure.DI.IntegrationTests/InterfaceGenerationTests.cs

@@ -138,6 +138,39 @@ public static void Main()
         result.StdOut.ShouldContain("ok");
     }
 
+    [Fact]
+    public async Task ShouldGenerateInterfaceInGlobalNamespace()
+    {
+        var result = await """
+                           using Pure.DI;
+
+                           public partial interface IService
+                           {
+                           }
+
+                           [GenerateInterface]
+                           public partial class Service : IService
+                           {
+                               public string Message => "ok";
+                           }
+
+                           public class Program
+                           {
+                               public static void Main()
+                               {
+                                   IService service = new Service();
+                                   System.Console.WriteLine(service.Message);
+                               }
+                           }
+                           """.RunAsync(new Options(LanguageVersion.CSharp10, CheckCompilationErrors: false));
+
+        result.Errors.Count.ShouldBe(0, result);
+        result.Success.ShouldBeTrue(result);
+        result.GeneratedCode.ShouldNotContain("namespace {global_namespace}");
+        result.GeneratedCode.ShouldContain("public partial interface IService");
+        result.StdOut.ShouldContain("ok");
+    }
+
     [Fact]
     public async Task ShouldPreserveMethodParameterOrder()
     {

tests/Pure.DI.UsageTests/Interfaces/GenerateInterfaceSelectiveMembersScenario.cs

@@ -7,6 +7,7 @@
 $f=- Generate interface members selectively
 $f=- Keep class-level generation settings
 $f=- Exclude explicitly ignored members from all generated interfaces
+$r=Shouldly
 */
 
 // ReSharper disable ClassNeverInstantiated.Global

tests/Pure.DI.UsageTests/Interfaces/GenerateMultipleInterfacesScenario.cs

@@ -7,6 +7,7 @@
 $f=- Generate multiple interfaces from one class
 $f=- Select members per interface using member attributes
 $f=- Reuse one member in several generated interfaces
+$r=Shouldly
 */
 
 // ReSharper disable ClassNeverInstantiated.Global