#136 Insufficient performance 5

Author: NikolayPianikov

src/Pure.DI.Core/Core/Code/IVarStateTracker.cs

@@ -0,0 +1,6 @@
+namespace Pure.DI.Core.Code;
+
+interface IVarStateTracker
+{
+    void OnStateChanging(int bindingId);
+}

src/Pure.DI.Core/Core/Code/Var.cs

@@ -18,6 +18,9 @@ record Var(
     private string? _baseName;
     private string? _rootBaseName;
     private readonly IDependencyNode _abstractNode = Declaration.Node;
+    private bool _isCreated = IsCreatedDefault(Declaration.Node);
+    private bool _isLocalFunctionCalled;
+    private IVarStateTracker? _stateTracker;
 
     /// <summary>
     /// Gets the type of the instance.
@@ -67,7 +70,16 @@ public string Name
     public string CodeExpression
     {
         get => _codeExpression ?? Name;
-        set => _codeExpression = value;
+        set
+        {
+            if (string.Equals(_codeExpression, value, StringComparison.Ordinal))
+            {
+                return;
+            }
+
+            _stateTracker?.OnStateChanging(_abstractNode.BindingId);
+            _codeExpression = value;
+        }
     }
 
     internal string? RawCodeExpression => _codeExpression;
@@ -93,12 +105,38 @@ public string CodeExpression
     /// <summary>
     /// Gets or sets a value indicating whether the variable has been created.
     /// </summary>
-    public bool IsCreated { get; set; } = IsCreatedDefault(Declaration.Node);
+    public bool IsCreated
+    {
+        get => _isCreated;
+        set
+        {
+            if (_isCreated == value)
+            {
+                return;
+            }
+
+            _stateTracker?.OnStateChanging(_abstractNode.BindingId);
+            _isCreated = value;
+        }
+    }
 
     /// <summary>
     /// Gets or sets a value indicating whether the local function was called in the current path.
     /// </summary>
-    public bool IsLocalFunctionCalled { get; set; }
+    public bool IsLocalFunctionCalled
+    {
+        get => _isLocalFunctionCalled;
+        set
+        {
+            if (_isLocalFunctionCalled == value)
+            {
+                return;
+            }
+
+            _stateTracker?.OnStateChanging(_abstractNode.BindingId);
+            _isLocalFunctionCalled = value;
+        }
+    }
 
     /// <summary>
     /// Resets the variable to its default state, including generated code.
@@ -109,9 +147,9 @@ public bool ResetToDefaults()
     {
         var changed = false;
         var defaultCreated = IsCreatedDefault(_abstractNode);
-        if (defaultCreated != IsCreated)
+        if (defaultCreated != _isCreated)
         {
-            IsCreated = defaultCreated;
+            _isCreated = defaultCreated;
             changed = true;
         }
 
@@ -133,9 +171,9 @@ public bool ResetToDefaults()
             changed = true;
         }
 
-        if (IsLocalFunctionCalled)
+        if (_isLocalFunctionCalled)
         {
-            IsLocalFunctionCalled = false;
+            _isLocalFunctionCalled = false;
             changed = true;
         }
 
@@ -157,9 +195,9 @@ public bool ResetStateToDefaults(bool resetLocalFunctionCalled)
     {
         var changed = false;
         var defaultCreated = IsCreatedDefault(_abstractNode);
-        if (defaultCreated != IsCreated)
+        if (defaultCreated != _isCreated)
         {
-            IsCreated = defaultCreated;
+            _isCreated = defaultCreated;
             changed = true;
         }
 
@@ -171,15 +209,28 @@ public bool ResetStateToDefaults(bool resetLocalFunctionCalled)
         }
 
         // ReSharper disable once InvertIf
-        if (resetLocalFunctionCalled && IsLocalFunctionCalled)
+        if (resetLocalFunctionCalled && _isLocalFunctionCalled)
         {
-            IsLocalFunctionCalled = false;
+            _isLocalFunctionCalled = false;
             changed = true;
         }
 
         return changed;
     }
 
+    internal void AttachStateTracker(IVarStateTracker stateTracker) => _stateTracker = stateTracker;
+
+    internal void RestorePathState(bool isCreated, bool isLocalFunctionCalled, string? codeExpression, bool restoreLocalFunctionCalled)
+    {
+        _isCreated = isCreated;
+        if (restoreLocalFunctionCalled)
+        {
+            _isLocalFunctionCalled = isLocalFunctionCalled;
+        }
+
+        _codeExpression = codeExpression;
+    }
+
     public override string ToString() => $"{InstanceType} {Name}";
 
     private static bool IsCreatedDefault(IDependencyNode node) =>

src/Pure.DI.Core/Core/Code/VarDeclaration.cs

@@ -12,11 +12,26 @@ record VarDeclaration(
     IDependencyNode Node)
 {
     private readonly Lazy<string> _name = new(() => NameProvider.GetVariableName(Node, PerLifetimeId));
+    private bool _isDeclared = IsDeclaredDefault(Node);
+    private IVarStateTracker? _stateTracker;
 
     /// <summary>
     /// Gets or sets a value indicating whether the variable has been declared.
     /// </summary>
-    public bool IsDeclared { get; set; } = IsDeclaredDefault(Node) ;
+    public bool IsDeclared
+    {
+        get => _isDeclared;
+        set
+        {
+            if (_isDeclared == value)
+            {
+                return;
+            }
+
+            _stateTracker?.OnStateChanging(Node.BindingId);
+            _isDeclared = value;
+        }
+    }
 
     /// <summary>
     /// Gets the type of the instance.
@@ -35,12 +50,12 @@ record VarDeclaration(
     public bool ResetToDefaults()
     {
         var declaredDefault = IsDeclaredDefault(Node);
-        if (declaredDefault == IsDeclared)
+        if (declaredDefault == _isDeclared)
         {
             return false;
         }
 
-        IsDeclared = declaredDefault;
+        _isDeclared = declaredDefault;
         return true;
     }
 
@@ -50,8 +65,12 @@ public bool ResetToDefaults()
     /// <returns>True if the state has changed.</returns>
     public bool ResetStateToDefaults() => ResetToDefaults();
 
+    internal void AttachStateTracker(IVarStateTracker stateTracker) => _stateTracker = stateTracker;
+
+    internal void RestoreDeclaredState(bool isDeclared) => _isDeclared = isDeclared;
+
     public override string ToString() => $"{InstanceType} {Name}";
 
     private static bool IsDeclaredDefault(IDependencyNode node) =>
         node.ActualLifetime is Lifetime.Singleton or Lifetime.Scoped or Lifetime.PerResolve || node.Arg is not null;
-}
+}