Skip to content

Commit b2d957e

Browse files
Minor
1 parent 30c0be8 commit b2d957e

10 files changed

Lines changed: 5 additions & 97 deletions

File tree

benchmarks/Pure.DI.Benchmarks/ActivatorCreateInstanceBenchmark.cs

Lines changed: 0 additions & 43 deletions
This file was deleted.

benchmarks/Pure.DI.Benchmarks/Benchmarks/Enum.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ public CompositionRoot TestHandCoded() =>
5959
new Service4(),
6060
new Service4());
6161

62-
[MethodImpl(MethodImplOptions.AggressiveOptimization)]
6362
private static IEnumerable<IService3> EnumerableOfIService3()
6463
{
6564
yield return new Service3(new Service4(), new Service4());

benchmarks/Pure.DI.Benchmarks/Benchmarks/Func.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,7 @@ private static void SetupDI() =>
4545
[Benchmark(Description = "Hand Coded", Baseline = true)]
4646
public CompositionRoot TestHandCoded()
4747
{
48-
var func = new Func<IService3>(
49-
[MethodImpl(MethodImplOptions.AggressiveInlining)]() => new Service3(new Service4(), new Service4()));
48+
var func = new Func<IService3>(() => new Service3(new Service4(), new Service4()));
5049

5150
return new CompositionRoot(
5251
new Service1(new Service2Func(func)),

build/build.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
1919
</PackageReference>
2020
<PackageReference Include="System.CommandLine" Version="2.0.0-beta4.22272.1"/>
21-
<PackageReference Include="System.Xml.XDocument" Version="4.3.0" />
2221
<ProjectReference Include="..\benchmarks\Pure.DI.Benchmarks\Pure.DI.Benchmarks.csproj"/>
2322
</ItemGroup>
2423

readme/ReadmeTemplate.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ partial class Composition
7272

7373
public Program Root
7474
{
75-
[MethodImpl(MethodImplOptions.AggressiveInlining)]
7675
get
7776
{
7877
var stateFunc = new Func<State>(() => {

readme/UnityPageTemplate.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ Advantages over classical DI container libraries:
3232
For types inherited from `MonoBehaviour`, a `BuildUp` composition method will be generated. This method will look as follows:
3333

3434
```csharp
35-
[CompilerServices.MethodImpl(MethodImplOptions.AggressiveInlining)]
3635
public Clock BuildUp(Clock buildingInstance)
3736
{
3837
if (buildingInstance is null)

samples/WinFormsAppNetCore/FormMain.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,11 @@ internal FormMain(IAppViewModel app, IClockViewModel clock)
1717
labelTime.DataBindings.Add(CreateBinding(clock, nameof(clock.Time)));
1818
}
1919

20-
protected override void OnClosing(CancelEventArgs e) =>
20+
protected override void OnFormClosed(FormClosedEventArgs e)
21+
{
2122
_viewModels.ForEach(vm => vm.PropertyChanged -= OnPropertyChanged);
23+
base.OnFormClosed(e);
24+
}
2225

2326
private Binding CreateBinding(object model, string propertyName, string targetName = nameof(Text)) =>
2427
_bindings.GetOrAdd(

src/Pure.DI.Core/Components/Api.g.cs

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -3237,7 +3237,6 @@ internal static class DI
32373237
/// <param name="compositionTypeName">An optional argument specifying the partial class name to generate.</param>
32383238
/// <param name="kind">An optional argument specifying the kind of setup. Please <see cref="Pure.DI.CompositionKind"/> for details. It defaults to <c>Public</c>.</param>
32393239
/// <returns>Reference to the setup continuation chain.</returns>
3240-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
32413240
internal static IConfiguration Setup(string compositionTypeName = "", CompositionKind kind = CompositionKind.Public)
32423241
{
32433242
return SharedConfiguration;
@@ -3249,278 +3248,239 @@ internal static IConfiguration Setup(string compositionTypeName = "", Compositio
32493248
private sealed class Configuration: IConfiguration, IBinding
32503249
{
32513250
/// <inheritdoc />
3252-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
32533251
public IBinding Bind(params object[] tags)
32543252
{
32553253
return this;
32563254
}
32573255

32583256
/// <inheritdoc />
3259-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
32603257
public IBinding Bind<T>(params object[] tags)
32613258
{
32623259
return this;
32633260
}
32643261

32653262
/// <inheritdoc />
3266-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
32673263
public IBinding Bind<T1, T2>(params object[] tags)
32683264
{
32693265
return this;
32703266
}
32713267

32723268
/// <inheritdoc />
3273-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
32743269
public IBinding Bind<T1, T2, T3>(params object[] tags)
32753270
{
32763271
return this;
32773272
}
32783273

32793274
/// <inheritdoc />
3280-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
32813275
public IBinding Bind<T1, T2, T3, T4>(params object[] tags)
32823276
{
32833277
return this;
32843278
}
32853279

32863280
/// <inheritdoc />
3287-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
32883281
public IBinding Bind<T1, T2, T3, T4, T5>(params object[] tags)
32893282
{
32903283
return this;
32913284
}
32923285

32933286
/// <inheritdoc />
3294-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
32953287
public IBinding Bind<T1, T2, T3, T4, T5, T6>(params object[] tags)
32963288
{
32973289
return this;
32983290
}
32993291

33003292
/// <inheritdoc />
3301-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
33023293
public IBinding Bind<T1, T2, T3, T4, T5, T6, T7>(params object[] tags)
33033294
{
33043295
return this;
33053296
}
33063297

33073298
/// <inheritdoc />
3308-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
33093299
public IBinding Bind<T1, T2, T3, T4, T5, T6, T7, T8>(params object[] tags)
33103300
{
33113301
return this;
33123302
}
33133303

33143304
/// <inheritdoc />
3315-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
33163305
public IBinding RootBind<T>(string name, RootKinds kind, params object[] tags)
33173306
{
33183307
return this;
33193308
}
33203309

33213310
/// <inheritdoc />
3322-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
33233311
public IConfiguration DependsOn(params string[] setupNames)
33243312
{
33253313
return this;
33263314
}
33273315

33283316
/// <inheritdoc />
3329-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
33303317
public IConfiguration GenericTypeArgumentAttribute<T>()
33313318
where T: global::System.Attribute
33323319
{
33333320
return this;
33343321
}
33353322

33363323
/// <inheritdoc />
3337-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
33383324
public IConfiguration TypeAttribute<T>(int typeArgumentPosition)
33393325
where T: global::System.Attribute
33403326
{
33413327
return this;
33423328
}
33433329

33443330
/// <inheritdoc />
3345-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
33463331
public IConfiguration TagAttribute<T>(int tagArgumentPosition)
33473332
where T: global::System.Attribute
33483333
{
33493334
return this;
33503335
}
33513336

33523337
/// <inheritdoc />
3353-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
33543338
public IConfiguration OrdinalAttribute<T>(int ordinalArgumentPosition)
33553339
where T: global::System.Attribute
33563340
{
33573341
return this;
33583342
}
33593343

33603344
/// <inheritdoc />
3361-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
33623345
public IConfiguration DefaultLifetime(Pure.DI.Lifetime lifetime)
33633346
{
33643347
return this;
33653348
}
33663349

33673350
/// <inheritdoc />
3368-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
33693351
public IConfiguration DefaultLifetime<T>(Lifetime lifetime, params object[] tags)
33703352
{
33713353
return this;
33723354
}
33733355

33743356
/// <inheritdoc />
3375-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
33763357
public IConfiguration Arg<T>(string name, params object[] tags)
33773358
{
33783359
return this;
33793360
}
33803361

33813362
/// <inheritdoc />
3382-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
33833363
public IConfiguration RootArg<T>(string name, params object[] tags)
33843364
{
33853365
return this;
33863366
}
33873367

33883368
/// <inheritdoc />
3389-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
33903369
public IConfiguration Root<T>(string name, object tag, RootKinds rootKind)
33913370
{
33923371
return this;
33933372
}
33943373

33953374
/// <inheritdoc />
3396-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
33973375
public IConfiguration Roots<T>(string name, RootKinds kind, string filter)
33983376
{
33993377
return this;
34003378
}
34013379

34023380
/// <inheritdoc />
3403-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
34043381
public IConfiguration Builder<T>(string name, RootKinds kind)
34053382
{
34063383
return this;
34073384
}
34083385

34093386
/// <inheritdoc />
3410-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
34113387
public IConfiguration Builders<T>(string name, RootKinds kind, string filter)
34123388
{
34133389
return this;
34143390
}
34153391

34163392
/// <inheritdoc />
3417-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
34183393
public IConfiguration Hint(Hint hint, string value)
34193394
{
34203395
return this;
34213396
}
34223397

34233398
/// <inheritdoc />
3424-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
34253399
public IConfiguration Accumulate<T, TAccumulator>(params Lifetime[] lifetimes)
34263400
where TAccumulator: new()
34273401
{
34283402
return this;
34293403
}
34303404

34313405
/// <inheritdoc />
3432-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
34333406
public IConfiguration GenericTypeArgument<T>()
34343407
{
34353408
return this;
34363409
}
34373410

34383411
/// <inheritdoc />
3439-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
34403412
public IBinding As(Pure.DI.Lifetime lifetime)
34413413
{
34423414
return this;
34433415
}
34443416

34453417
/// <inheritdoc />
3446-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
34473418
public IBinding Tags(params object[] tags)
34483419
{
34493420
return this;
34503421
}
34513422

34523423
/// <inheritdoc />
3453-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
34543424
public IConfiguration To<T>()
34553425
{
34563426
return this;
34573427
}
34583428

34593429
/// <inheritdoc />
3460-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
34613430
public IConfiguration To<T>(global::System.Func<IContext, T> factory)
34623431
{
34633432
return this;
34643433
}
34653434

34663435
/// <inheritdoc />
3467-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
34683436
public IConfiguration To<T>(string sourceCodeStatement)
34693437
{
34703438
return this;
34713439
}
34723440

34733441
/// <inheritdoc />
3474-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
34753442
public IConfiguration To<T1, T>(global::System.Func<T1, T> factory)
34763443
{
34773444
return this;
34783445
}
34793446

34803447
/// <inheritdoc />
3481-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
34823448
public IConfiguration To<T1, T2, T>(global::System.Func<T1, T2, T> factory)
34833449
{
34843450
return this;
34853451
}
34863452

34873453
/// <inheritdoc />
3488-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
34893454
public IConfiguration To<T1, T2, T3, T>(global::System.Func<T1, T2, T3, T> factory)
34903455
{
34913456
return this;
34923457
}
34933458

34943459
/// <inheritdoc />
3495-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
34963460
public IConfiguration To<T1, T2, T3, T4, T>(Func<T1, T2, T3, T4, T> factory)
34973461
{
34983462
return this;
34993463
}
35003464

35013465
/// <inheritdoc />
3502-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
35033466
public IConfiguration To<T1, T2, T3, T4, T5, T>(Func<T1, T2, T3, T4, T5, T> factory)
35043467
{
35053468
return this;
35063469
}
35073470

35083471
/// <inheritdoc />
3509-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
35103472
public IConfiguration To<T1, T2, T3, T4, T5, T6, T>(Func<T1, T2, T3, T4, T5, T6, T> factory)
35113473
{
35123474
return this;
35133475
}
35143476

35153477
/// <inheritdoc />
3516-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
35173478
public IConfiguration To<T1, T2, T3, T4, T5, T6, T7, T>(Func<T1, T2, T3, T4, T5, T6, T7, T> factory)
35183479
{
35193480
return this;
35203481
}
35213482

35223483
/// <inheritdoc />
3523-
[global::System.Runtime.CompilerServices.MethodImpl((global::System.Runtime.CompilerServices.MethodImplOptions)256)]
35243484
public IConfiguration To<T1, T2, T3, T4, T5, T6, T7, T8, T>(Func<T1, T2, T3, T4, T5, T6, T7, T8, T> factory)
35253485
{
35263486
return this;

0 commit comments

Comments
 (0)