Commit 5b597e9
authored
PR Reviewer Agent (dotnet#32340)
* PR Reviewer Agent
* - additional custom agent updates
* update instrumentation documentation
* fix
* Address Copilot PR review comments
- Remove broken link to RTL-Testing-Guide.md (file doesn't exist)
- Update instrumentation guide example to use Task.Delay instead of Dispatcher.DispatchDelayed for better clarity
Addresses: dotnet#32340 (comment)
Addresses: dotnet#32340 (comment)
* Add security checklist and expand PR splitting guidance
- Add dedicated Security section to code review checklist covering:
- Hardcoded secrets detection
- External endpoint usage in tests
- Input validation
- Secure data handling
- Dependency security
- Platform permissions
- Expand PR splitting guidance with specific scenarios:
- Separate refactoring from bug fixes
- Split unrelated documentation updates
- Separate new features from fixes
- Split multi-platform changes
- Break up large API additions
Addresses: dotnet#32340 (comment)
Addresses: dotnet#32340 (comment)
* Improve pr-reviewer agent: make thorough testing the default
- Change default mode from Quick (code-only) to Thorough (with testing)
- Expand trigger words to include 'thorough', 'validation', 'review', 'check'
- Add 'Core Philosophy' section emphasizing hands-on testing over code review
- Add 'Edge Case Discovery' section with comprehensive test scenarios
- Add explicit 'Default Mode Selection Logic' decision tree
- Update mode examples to show reasoning for mode selection
- Mark Quick Mode as 'NOT RECOMMENDED' and requiring explicit user request
- Add warnings in output format section about default behavior
Fixes issue where 'thorough review and validation' incorrectly triggered
Quick Mode instead of Thorough Mode with actual device testing.
* Add build error handling guidelines to PR reviewer agent
- Add new 'Handling Build Errors' section after 'Build and Deploy'
- Update Thorough Mode to reference build error handling (step 5)
- Add explicit instructions to STOP and ask for help after 1-2 failed fix attempts
- Provide template message for reporting build errors to user
- Add 'What NOT to do' list to prevent silent mode switching
- Clarify that incomplete testing means incomplete review
* Fix inconsistencies in PR reviewer prompt guide
- Update Quick Mode examples to require explicit 'quick' keyword
- Add 'Please review PR #XXXXX' to Thorough Mode (it's the default)
- Add 'Important: Default Behavior' section explaining mode selection
- Add 'What Happens If Build Fails?' section documenting error handling
- Mark Quick Mode as NOT RECOMMENDED to align with agent instructions
- Clarify that simple 'review this PR' defaults to Thorough Mode (with testing)
This ensures the prompt guide is consistent with the agent instructions
where Thorough Mode (with testing) is the default for all PR reviews.
* - updates with safe area guidance
* Update PR reviewer agent instructions
* Clarify Sandbox vs HostApp usage for PR validation
- Add clear section explaining when to use each app
- Sandbox app: For PR validation and testing (99% of reviews)
- TestCases.HostApp: Only for writing/validating UI tests (1%, explicit request only)
- Emphasize Sandbox builds in ~2min vs HostApp ~20min
- Add decision tree and examples to prevent confusion
- Update Core Philosophy and Thorough Mode sections to reinforce this
* - add instructions for git
* - simplify instructions
* - update instructions
* - make updates about time constraints1 parent a494f6a commit 5b597e9
7 files changed
Lines changed: 2517 additions & 0 deletions
File tree
- .github
- agents
- instructions
- prompts
- docs
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
0 commit comments