Remove redundant code for element pv creation

The bend elements had their own code to create their pvs. Now they use the same code as for regular elements. I had to refactor the function a little bit to keep the same behaviour as before. This being that only 1 pv is created for all bend elements and each new element adds its index to a list stored in this pv

Author: ptsOSL

src/virtac/atip_server.py

@@ -163,48 +163,22 @@ def _create_records(self, limits_csv, disable_emittance):
                     float(line["lower"]),
                     int(line["precision"]),
                 )
+
         bend_in_record = None
         for element in self.lattice:
-            if element.type_.upper() == "BEND":
-                # Create bends only once as they all share a single PV.
-                if bend_in_record is None:
-                    value = element.get_value(
-                        "b0", units=pytac.ENG, data_source=pytac.SIM
-                    )
-                    get_pv = element.get_pv_name("b0", pytac.RB)
-                    upper, lower, precision = limits_dict.get(
-                        get_pv, (None, None, None)
-                    )
-                    builder.SetDeviceName(get_pv.split(":", 1)[0])
-                    in_record = builder.aIn(
-                        get_pv.split(":", 1)[1],
-                        LOPR=lower,
-                        HOPR=upper,
-                        PREC=precision,
-                        MDEL="-1",
-                        initial_value=value,
-                    )
-                    set_pv = element.get_pv_name("b0", pytac.SP)
-                    upper, lower, precision = limits_dict.get(
-                        set_pv, (None, None, None)
-                    )
-                    builder.SetDeviceName(set_pv.split(":", 1)[0])
-                    out_record = builder.aOut(
-                        set_pv.split(":", 1)[1],
-                        LOPR=lower,
-                        HOPR=upper,
-                        PREC=precision,
-                        initial_value=value,
-                        on_update_name=self._on_update,
-                        always_update=True,
-                    )
-                    self._in_records[in_record] = ([element.index], "b0")
-                    self._out_records[out_record] = in_record
-                    bend_in_record = in_record
-                else:
+            # There is only 1 bend PV in the lattice, if it has already been defined and
+            # we have another bend element, then just register this element with the
+            # existing pv. Otherwise create a new PV for the element
+            if element.type_.upper() == "BEND" and bend_in_record is not None:
+                # record[0] may be an int or a list of ints
+                if isinstance(self._in_records[bend_in_record][0], list):
                     self._in_records[bend_in_record][0].append(element.index)
+                else:
+                    self._in_records[bend_in_record] = [
+                        self._in_records[bend_in_record][0],
+                        element.index,
+                    ]
             else:
-                # Create records for all other families.
                 for field in element.get_fields()[pytac.SIM]:
                     value = element.get_value(
                         field, units=pytac.ENG, data_source=pytac.SIM
@@ -223,6 +197,7 @@ def _create_records(self, limits_csv, disable_emittance):
                         initial_value=value,
                     )
                     self._in_records[in_record] = (element.index, field)
+
                     try:
                         set_pv = element.get_pv_name(field, pytac.SP)
                     except HandleException:
@@ -242,6 +217,9 @@ def _create_records(self, limits_csv, disable_emittance):
                             always_update=True,
                         )
                         self._out_records[out_record] = in_record
+                        if element.type_.upper() == "BEND" and bend_in_record is None:
+                            bend_in_record = in_record
+
         # Now for lattice fields.
         lat_fields = self.lattice.get_fields()
         lat_fields = set(lat_fields[pytac.LIVE]) & set(lat_fields[pytac.SIM])