Upgrade version of upload and download artifact

V3 was deprecated in Nov 2024

Author: AlexanderWells-diamond

.github/actions/install_requirements/action.yml

@@ -29,16 +29,16 @@ runs:
 
     - name: Create lockfile
       run: |
-        mkdir -p lockfiles
-        pip freeze --exclude-editable > lockfiles/${{ inputs.requirements_file }}
+        mkdir -p lockfiles-${{ inputs.python_version }}
+        pip freeze --exclude-editable > lockfiles-${{ inputs.python_version }}/${{ inputs.requirements_file }}
         # delete the self referencing line and make sure it isn't blank
-        sed -i'' -e '/file:/d' lockfiles/${{ inputs.requirements_file }}
+        sed -i'' -e '/file:/d' lockfiles-${{ inputs.python_version }}/${{ inputs.requirements_file }}
       shell: bash
 
     - name: Upload lockfiles
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
-        name: lockfiles
+        name: lockfiles-${{ inputs.python_version }}
         path: lockfiles
 
     # This eliminates the class of problems where the requirements being given no
@@ -49,10 +49,9 @@ runs:
     - name: If requirements file exists, check it matches pip installed packages
       run: |
         if [ -s ${{ inputs.requirements_file }} ]; then
-          if ! diff -u ${{ inputs.requirements_file }} lockfiles/${{ inputs.requirements_file }}; then
+          if ! diff -u ${{ inputs.requirements_file }} lockfiles-${{ inputs.python_version }}/${{ inputs.requirements_file }}; then
             echo "Error: ${{ inputs.requirements_file }} need the above changes to be exhaustive"
             exit 1
           fi
         fi
       shell: bash
-

.github/workflows/code.yml

@@ -86,9 +86,9 @@ jobs:
           CIBW_SKIP: pp* *i686*
 
       - name: Upload sdist and wheels as artifacts
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: dist
+          name: dist-${{ matrix.os }}-${{ matrix.python }}
           path: dist
 
       - name: Check for packaging errors
@@ -104,7 +104,11 @@ jobs:
       HAS_PYPI_TOKEN: ${{ secrets.PYPI_TOKEN != '' }}
 
     steps:
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
+        with:
+            pattern: dist*
+            path: dist
+            merge-multiple: true
 
       - name: Fixup blank lockfiles
         # Github release artifacts can't be blank