Skip to content

Commit 641e0a4

Browse files
authored
Fix build dependencies (#2096)
* Pin daq-config-server to a version instead of a branch * Update the release instructions to add check for pyproject.toml dependency versions * Update lock file
1 parent a463d57 commit 641e0a4

3 files changed

Lines changed: 10 additions & 4 deletions

File tree

docs/how-to/make-release.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ To make a new release, please follow this checklist:
88
- Choose a new PEP440 compliant release number (see <https://peps.python.org/pep-0440/>) (The release version should
99
look like `{major}.{minor}.{patch}`). See [Deciding release numbers](#Deciding release numbers) if you're unsure on
1010
what the release version should be.
11+
- Ensure that dependencies in pyproject.toml refer to release versions and not branches, otherwise the release will be rejected by PyPI
12+
- If you updated the pyproject.toml, also run a `uv sync` to ensure that dependencies are updated, and then merge the changes back to ``main``
1113
- Go to the GitHub [release] page
1214
- Choose `Draft New Release`
1315
- Click `Choose Tag` and supply the new tag you chose (click create new tag)

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ dependencies = [
3232
"scanspec>=0.7.3",
3333
"pyzmq==27.1.0",
3434
"deepdiff",
35-
"daq-config-server @ git+https://github.com/DiamondLightSource/daq-config-server.git@main", # For getting Configuration settings.
35+
"daq-config-server >= 1.3.6", # For getting Configuration settings.
3636
"mysql-connector-python == 9.5.0", # Can unpin once https://github.com/DiamondLightSource/ispyb-api/pull/244 is merged and released
3737
]
3838

uv.lock

Lines changed: 7 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)