Skip to content

Commit a913636

Browse files
authored
Merge pull request #65 from DiamondLightSource/docsfix
yaml generator comment fixes
2 parents cf656f5 + 0214f34 commit a913636

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

httomo_backends/scripts/yaml_pipelines_generator.py

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ def yaml_pipelines_generator(
149149
)
150150
pipeline_full[i]["side_outputs"].yaml_add_eol_comment(
151151
key="cor",
152-
comment="A side output of the method, here a CoR scalar value",
152+
comment="An estimated CoR value provided as a side output",
153153
)
154154
pipeline_full[i]["side_outputs"].yaml_add_eol_comment(
155155
key="overlap",
@@ -158,17 +158,22 @@ def yaml_pipelines_generator(
158158
elif "corr" in module_name and "remove_outlier" in method_name:
159159
pipeline_full.yaml_set_comment_before_after_key(
160160
i,
161-
"--- Removing dead pixels in the data, aka zingers. Use if sharp streaks are present in reconstruction. Please use before normalisation. ---",
161+
"--- Removing unresponsive pixels in the data, aka zingers. Use if sharp streaks are present in the reconstruction. To be applied before normalisation. ---",
162162
indent=0,
163163
)
164164
pipeline_full += yaml_template_method
165165
if pipeline_full[i]["parameters"]["dif"] == "REQUIRED":
166166
# fix for the absent parameter in TomoPy's algorithm
167167
pipeline_full[i]["parameters"]["dif"] = 0.1
168+
pipeline_full[i]["parameters"].yaml_add_eol_comment(
169+
key="kernel_size",
170+
comment="The size of the 3D neighbourhood surrounding the voxel. Odd integer.",
171+
)
168172
pipeline_full[i]["parameters"].yaml_add_eol_comment(
169173
key="dif",
170-
comment="A difference between the outlier value and the median value of neighboring pixels.",
174+
comment="A difference between the outlier value and the median value of neighbouring pixels.",
171175
)
176+
172177
elif "distortion" in method_name:
173178
pipeline_full.yaml_set_comment_before_after_key(
174179
i,
@@ -225,8 +230,12 @@ def yaml_pipelines_generator(
225230
pipeline_full += yaml_template_method
226231
pipeline_full[i]["parameters"].yaml_add_eol_comment(
227232
key="center",
228-
comment="Reference to center of rotation side output OR an integer.",
233+
comment="Reference to center of rotation side output above OR a float number.",
229234
)
235+
pipeline_full[i]["parameters"].yaml_add_eol_comment(
236+
key="detector_pad",
237+
comment="Horizontal detector padding to minimise circle/arc-type artifacts in the reconstruction",
238+
)
230239
pipeline_full[i]["parameters"].yaml_add_eol_comment(
231240
key="recon_mask_radius",
232241
comment="Zero pixels outside the mask-circle radius.",

0 commit comments

Comments
 (0)