Merge pull request #218 from DiamondLightSource/nonzero

removes the default zeros check from the data_checker

Author: dkazanc

httomolibgpu/misc/supp_func.py

@@ -162,7 +162,7 @@ def data_checker(
 ) -> bool:
     """
     Function that performs the variety of checks on input data, in some cases also correct the data and prints warnings.
-    Currently it checks for: the presence of infs and nans in data; the number of zero elements.
+    Currently it checks for: the presence of infs and nans in data. 
 
     Parameters
     ----------
@@ -181,11 +181,12 @@ def data_checker(
 
     data = _naninfs_check(data, verbosity=verbosity, method_name=method_name)
 
-    _zeros_check(
-        data,
-        verbosity=verbosity,
-        percentage_threshold=50,
-        method_name=method_name,
-    )
+    # ! The number of zero elements check is currently switched off as it requires sorting or AtomicAdd, which makes it inefficient on GPUs. !
+    # _zeros_check(
+    #     data,
+    #     verbosity=verbosity,
+    #     percentage_threshold=50,
+    #     method_name=method_name,
+    # )
 
     return data

tests/test_misc/test_supp_func.py

@@ -157,7 +157,7 @@ def test_zeros_check3_numpy():
     assert warning_zeros == False
 
 
-def test_data_checker_numpy():
+def test_data_checker_infsnans_numpy():
     _data_input = np.ones(shape=(10, 10, 10)).astype(np.float32)
     _data_input[1, 1, 1] = -np.inf
     _data_input[1, 1, 2] = np.inf
@@ -181,7 +181,7 @@ def test_data_checker_numpy():
     assert _data_output.shape == (10, 10, 10)
 
 
-def test_data_checker():
+def test_data_infsnans_checker():
     _data_input = cp.ones(shape=(10, 10, 10)).astype(cp.float32) * 100.0
     _data_input[1, 1, 1] = -cp.inf
     _data_input[1, 1, 2] = cp.inf