Update setup_oav to use plan moved to dodal (#1577)

* Update setup_oav to use plan moved to dodal

* Set wait to false in plan

Author: noemifrisina

src/mx_bluesky/common/device_setup_plans/setup_oav.py

@@ -5,66 +5,16 @@
 from dodal.devices.oav.oav_detector import OAV
 from dodal.devices.oav.oav_parameters import OAVParameters
 from dodal.devices.oav.pin_image_recognition import PinTipDetection
+from dodal.devices.oav.pin_image_recognition.utils import ScanDirections
+from dodal.plans.device_setup_plans.setup_pin_tip_params import (
+    setup_pin_tip_detection_params,
+)
 
 from mx_bluesky.common.parameters.constants import (
     PlanGroupCheckpointConstants,
 )
 
 
-def setup_pin_tip_detection_params(
-    pin_tip_detect_device: PinTipDetection,
-    parameters: OAVParameters,
-):
-    set_using_group = partial(
-        bps.abs_set, group=PlanGroupCheckpointConstants.READY_FOR_OAV
-    )
-    # select which blur to apply to image
-    yield from set_using_group(
-        pin_tip_detect_device.preprocess_operation, parameters.preprocess
-    )
-
-    # sets length scale for blurring
-    yield from set_using_group(
-        pin_tip_detect_device.preprocess_ksize, parameters.preprocess_K_size
-    )
-
-    # sets iteration for blur
-    yield from set_using_group(
-        pin_tip_detect_device.preprocess_iterations, parameters.preprocess_iter
-    )
-
-    # Canny edge detect - lower
-    yield from set_using_group(
-        pin_tip_detect_device.canny_lower_threshold,
-        parameters.canny_edge_lower_threshold,
-    )
-
-    # Canny edge detect - upper
-    yield from set_using_group(
-        pin_tip_detect_device.canny_upper_threshold,
-        parameters.canny_edge_upper_threshold,
-    )
-
-    # "Open" morphological operation
-    yield from set_using_group(pin_tip_detect_device.open_ksize, parameters.open_ksize)
-
-    # "Close" morphological operation
-    yield from set_using_group(
-        pin_tip_detect_device.close_ksize, parameters.close_ksize
-    )
-
-    # Sample detection direction
-    yield from set_using_group(
-        pin_tip_detect_device.scan_direction, parameters.direction
-    )
-
-    # Minimum height
-    yield from set_using_group(
-        pin_tip_detect_device.min_tip_height,
-        parameters.minimum_height,
-    )
-
-
 def setup_general_oav_params(oav: OAV, parameters: OAVParameters):
     set_using_group = partial(
         bps.abs_set, group=PlanGroupCheckpointConstants.READY_FOR_OAV
@@ -91,5 +41,11 @@ def pre_centring_setup_oav(
     Setup OAV PVs with required values.
     """
     yield from setup_general_oav_params(oav, parameters)
-    yield from setup_pin_tip_detection_params(pin_tip_detection_device, parameters)
+    yield from setup_pin_tip_detection_params(
+        pin_tip_detection_device,
+        parameters,
+        ScanDirections.FORWARD,
+        group=PlanGroupCheckpointConstants.READY_FOR_OAV,
+        wait=False,
+    )
     yield from bps.wait(PlanGroupCheckpointConstants.READY_FOR_OAV)