Murko testing 4/09/25

[DominicOram]

• Error on oav type being wrong:

2025-09-04 14:19:48,620 ERROR [server/30142@i04-control.diamond.ac.uk] gda.jython.JythonServer - CommandServer: error while running command: 'sample_control.loadSampleUiLogged(sample_position=1, sample_holder=1, sampleName='robot_test1', code='', blsampleId=6780641)' encountered an error: 
org.python.core.PyException: java.util.concurrent.ExecutionException: java.util.concurrent.ExecutionException: uk.ac.diamond.daq.bluesky.client.error.HttpValidationError: ValidationError[locations=[body, params, oav], message=Value error, Device oav is not of type dodal.devices.oav.oav_detector.OAV, type=value_error, input=oav]

This was not getting through to graylog and the underlying issue was that the OAV was not instantiated at all, despite the error implying it was a type issue. Maybe we could be explicit that it doesn't exist at all and print the ones that do exist - fixed in DiamondLightSource/blueapi#1194

• The undlying cause of this was having to copy the jcameraman files in again, we need a long term fix for this - covered by OAV: Get config files from config server dodal#1566
• Filtering code fails with unusual error if there are no results (ValueError('not enough values to unpack (expected 4, got 0)')) - Murko fixes found from testing dodal#1587
• Sample id is not being set on murko_results - fixed in Fixes from murko testing #1300
• Not getting all the results, just using the last batch - fixed by changing the break to continue in Murko fixes found from testing dodal#1587
• Using the wrong beam centre (we have them in the two different devices) - set to use the fullscreen one for now but need to fix in Murko: Use the correct OAV for each centring #1312
• First one failed java.util.concurrent.ExecutionException: uk.ac.diamond.daq.bluesky.api.BlueskyException: WorkerEvent[state=IDLE, taskStatus=TaskStatus[taskID=06dba2ab-2edc-494e-adfe-3351eccc0be2, complete=true, failed=true], errors=[<AsyncStatus, device: murko_results, task: <coroutine object MurkoResultsDevice.trigger at 0x7f082a831d00>, errored: RuntimeError('pubsub connection not set: did you forget to call subscribe() or psubscribe()?')>], warnings=[]] - this was fixed by adding wait=True to the stage of the results - Murko fixes found from testing #1315
• We should add whether we have used the image in to the redis metadata - Murko: Add to redis metadata whether an image was used #1303
• Conversion of best click to move is still wrong (even when using the correct beam centre) - Murko: Use result with the smallest X #1313