Originally when robot_load_then_centre was called independently, we had to handle two cases:
- where the energy was not specified in the request and the desired energy was determined from the beamline state.
- where the energy was specified in the request and the beamline needed to be changed to this energy.
Because the detector params are computed up front this means that there is additional logic to populate the detector params in the first case by reading the beamline state.
Since we now don't call robot_load_then_centre as a standalone plan, we can potentially remove this logic. If it is ever needed again it would probably be better to put it in a beamline-specific plan wrapper.
Acceptance Criteria
- This code is removed
- Tests still pass
Originally when
robot_load_then_centrewas called independently, we had to handle two cases:Because the detector params are computed up front this means that there is additional logic to populate the detector params in the first case by reading the beamline state.
Since we now don't call robot_load_then_centre as a standalone plan, we can potentially remove this logic. If it is ever needed again it would probably be better to put it in a beamline-specific plan wrapper.
Acceptance Criteria