Skip to content

Commit 4efa606

Browse files
committed
More sanitisation and escaping
1 parent 916ab04 commit 4efa606

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

src/murfey/server/api/bootstrap.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -657,7 +657,7 @@ def get_windows_terminal_releases(request: Request):
657657

658658
for v in range(len(versions)):
659659
version = versions[v]
660-
hyperlink = f'<a href="{base_url}/{path}/{version}">{version}</a><br />'
660+
hyperlink = f'<a href="{base_url}/{path}/{quote(version, safe="")}">{quote(version, safe="")}</a><br />'
661661
link_list.append(hyperlink)
662662
hyperlinks = "\n".join(link_list)
663663

@@ -693,7 +693,7 @@ def get_windows_terminal_version_assets(
693693
raise HTTPException("Invalid version format")
694694

695695
# https://github.com/{owner}/{repo}/releases/expanded_assets/{version}
696-
url = f"{windows_terminal_url}/expanded_assets/{version}"
696+
url = f'{windows_terminal_url}/expanded_assets/{quote(version, safe="")}'
697697

698698
response = requests.get(url)
699699
headers = response.headers
@@ -728,9 +728,7 @@ def get_windows_terminal_version_assets(
728728

729729
for a in range(len(assets)):
730730
asset = assets[a]
731-
hyperlink = (
732-
f'<a href="{base_url}/{path}/{asset}">{quote(asset, safe="")}</a><br />'
733-
)
731+
hyperlink = f'<a href="{base_url}/{path}/{quote(asset, safe="")}">{quote(asset, safe="")}</a><br />'
734732
link_list.append(hyperlink)
735733
hyperlinks = "\n".join(link_list)
736734

0 commit comments

Comments
 (0)