Skip to content

[Gulp-Sass] Improper filtering of partials when #compiled is placed after compilation. #3

@MarkTwoFive

Description

@MarkTwoFive

Since v1.0.1/v1.0.2, we declare files as compiled when they are piped through #reportCompiled().
As this is desired to be done AFTER Sass compilation so Sass errors do not mark a file as compiled, we have trouble with partials:

When piped to gulp-sass, they are consumed and removed from the stream.

  if (path.basename(file.path).indexOf('_') === 0) {
    return cb();
  }

That causes them to be never considered as compiled as they are no longer in the stream.


We need a solution to this issue.
A discussion with the gulp-sass maintainers about this may also be required.
Until then, placing the #reportCompile() before the sass call will work around that issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Foreign causeBehavior is caused in conjunction with another project which is likely to be the cause.enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions