use sha256 hashes instead of crc32

Author: tomdaley92

linux/makefile

@@ -31,10 +31,10 @@ PIPEWIRE_LIBS = $(shell pkg-config --libs libpipewire-0.3)
 JACK_CFLAGS = $(shell pkg-config --cflags jack)
 JACK_LIBS = $(shell pkg-config --libs jack)
 
-CFLAGS += $(GTK3_CFLAGS) $(ALSA_CFLAGS) $(PULSE_CFLAGS) $(PIPEWIRE_CFLAGS) $(JACK_CFLAGS)
+CFLAGS += $(GTK3_CFLAGS) $(ALSA_CFLAGS) $(PULSE_CFLAGS) $(PIPEWIRE_CFLAGS) $(JACK_CFLAGS) $(shell pkg-config --cflags openssl)
 
 INCS = -I../external/sdl/build/include/ -I../external/imgui/ -I../external/stb/ -I../shared/
-LIBS = -L../external/sdl/build/lib -lSDL2-2.0 -lGL $(GTK3_LIBS) $(ALSA_LIBS) $(PULSE_LIBS) $(PIPEWIRE_LIBS) $(JACK_LIBS) $(ESD_LIBS) $(SNDIO_LIBS) -lm -ldl -lpthread
+LIBS = -L../external/sdl/build/lib -lSDL2-2.0 -lGL $(GTK3_LIBS) $(ALSA_LIBS) $(PULSE_LIBS) $(PIPEWIRE_LIBS) $(JACK_LIBS) $(ESD_LIBS) $(SNDIO_LIBS) -lm -ldl -lpthread $(shell pkg-config --libs openssl)
 
 # SDL dependency files
 SDL_LIB = ../external/sdl/build/lib/libSDL2-2.0.so.0
@@ -45,7 +45,7 @@ BOOTROM_HEADER = ../shared/bootrom.h
 BOOTROM_SOURCE = ../roms/Kiwi8_logo_2.ch8
 
 # Source files
-CORE_SRCS = ../shared/audio.cc ../shared/chip8.cc ../shared/crc32.cc ../shared/display.cc ../shared/gui.cc \
+CORE_SRCS = ../shared/audio.cc ../shared/chip8.cc ../shared/sha256.cc ../shared/display.cc ../shared/gui.cc \
 			../shared/input.cc ../shared/main.cc \
 			../shared/toast.cc ../shared/open_file_dialog.cc ../shared/profiles.cc
 IMGUI_SRCS = ../external/imgui/imgui.cpp ../external/imgui/imgui_draw.cpp ../external/imgui/imgui_impl_sdl.cpp

macos/makefile

@@ -16,10 +16,10 @@ APP_BUNDLE = $(APP_NAME).app
 APP_EXE = $(APP_NAME)
 
 CC = clang++
-CFLAGS = -std=c++17 -Wall -mmacosx-version-min=11.0 -MMD -MP -DAPP_NAME='"$(APP_NAME)"' -DVERSION='"$(VERSION)"' -DSUB_VERSION='"$(SUB_VERSION)"'
+CFLAGS = -std=c++17 -Wall -mmacosx-version-min=11.0 -MMD -MP -DAPP_NAME='"$(APP_NAME)"' -DVERSION='"$(VERSION)"' -DSUB_VERSION='"$(SUB_VERSION)"' $(shell pkg-config --cflags openssl)
 LFLAGS = -mmacosx-version-min=11.0
 INCS = -I../external/sdl/build/include/ -I../external/imgui/ -I../external/stb/ -I../shared/
-LIBS = -L../external/sdl/build/lib/ -lSDL2-2.0.0 -framework Cocoa -framework OpenGL
+LIBS = -L../external/sdl/build/lib/ -lSDL2-2.0.0 -framework Cocoa -framework OpenGL $(shell pkg-config --libs openssl)
 
 # SDL dependency files
 SDL_LIB = ../external/sdl/build/lib/libSDL2-2.0.0.dylib
@@ -30,7 +30,7 @@ BOOTROM_HEADER = ../shared/bootrom.h
 BOOTROM_SOURCE = ../roms/Kiwi8_logo_2.ch8
 
 # Source files
-CORE_SRCS = ../shared/audio.cc ../shared/chip8.cc ../shared/crc32.cc ../shared/display.cc ../shared/gui.cc \
+CORE_SRCS = ../shared/audio.cc ../shared/chip8.cc ../shared/sha256.cc ../shared/display.cc ../shared/gui.cc \
 			../shared/input.cc ../shared/main.cc \
 			../shared/toast.cc ../shared/open_file_dialog.cc ../shared/profiles.cc
 IMGUI_SRCS = ../external/imgui/imgui.cpp ../external/imgui/imgui_draw.cpp ../external/imgui/imgui_impl_sdl.cpp

shared/chip8.cc

@@ -5,7 +5,7 @@
 #include "audio.h"
 #include "opcodes.h"
 #include "profiles.h"
-#include "crc32.h"
+#include "sha256.h"
 #include "toast.h"
 #include "open_file_dialog.h"
 #include <SDL2/SDL.h>
@@ -176,9 +176,9 @@ int chip8_load_rom(const char *rom_filepath) {
         snprintf(notif_msg, sizeof(notif_msg), "ROM loaded: %s", chip8.rom_filename);
         toast_show(TOAST_SUCCESS, notif_msg);
 
-        /* Compute CRC32 and lookup profile */
-        uint32_t crc = crc32_compute(chip8.rom, chip8.rom_size);
-        const struct profile *profile = profile_lookup(crc);
+        /* Compute SHA256 and lookup profile */
+        sha256_hash_t sha256 = sha256_compute(chip8.rom, chip8.rom_size);
+        const struct profile *profile = profile_lookup(&sha256);
 
         if (profile) {
             /* Apply profile quirks */

shared/profiles.cc

@@ -1,16 +1,16 @@
 #include "profiles.h"
 #define STB_DS_IMPLEMENTATION
 #include "stb_ds.h"
-#include "crc32.h"
+#include "sha256.h"
 #include "chip8.h"
 #include "toast.h"
 #include <SDL2/SDL.h>
 #include <stdio.h>
 #include <string.h>
 #include <stddef.h>
 
-/* ROM profile hashmap: CRC32 -> profile */
-static struct { uint32_t key; struct profile value; } *profile_map = NULL;
+/* ROM profile hashmap: SHA256 -> profile */
+static struct { sha256_hash_t key; struct profile value; } *profile_map = NULL;
 
 /* Track which path we loaded profiles.ini from */
 static char loaded_profiles_path[512] = "";
@@ -36,7 +36,7 @@ static int create_profiles_file(const char *path) {
     FILE *file = fopen(path, "w");
     if (!file) return 0;
     fprintf(file, "# ROM Profiles Database\n");
-    fprintf(file, "# Format: [0xCRC32] followed by quirk settings\n\n");
+    fprintf(file, "# Format: [0xSHA256] followed by quirk settings\n\n");
     fclose(file);
     return 1;
 }
@@ -47,7 +47,8 @@ static void parse_profiles_ini(void) {
     if (!file) return;
 
     char line[512];
-    uint32_t current_crc = 0;
+    sha256_hash_t current_sha256 = {0};
+    int has_current = 0;
     struct profile current_profile;
 
     while (fgets(line, sizeof(line), file)) {
@@ -58,23 +59,46 @@ static void parse_profiles_ini(void) {
         /* Skip empty lines and comments */
         if (line[0] == '\0' || line[0] == '#') continue;
 
-        /* Section header [0xHEXVALUE] */
+        /* Section header [0xHEXVALUE] - 64 hex chars for SHA256 */
         if (line[0] == '[') {
-            if (current_crc != 0) hmput(profile_map, current_crc, current_profile);
+            if (has_current) hmput(profile_map, current_sha256, current_profile);
 
-            if (sscanf(line, "[0x%x]", &current_crc) != 1) {
+            char hex_str[65];
+            if (sscanf(line, "[%64[0-9a-fA-F]]", hex_str) != 1) {
                 printf("Error: Invalid profile section header: %s\n", line);
-                current_crc = 0;
+                has_current = 0;
                 continue;
             }
+
+            /* Parse 64 hex characters into 32 bytes */
+            if (strlen(hex_str) != 64) {
+                printf("Error: SHA256 must be 64 hex characters: %s\n", hex_str);
+                has_current = 0;
+                continue;
+            }
+
+            for (int i = 0; i < 32; i++) {
+                unsigned int byte;
+                if (sscanf(hex_str + i*2, "%2x", &byte) != 1) {
+                    printf("Error: Invalid hex in SHA256: %s\n", hex_str);
+                    has_current = 0;
+                    goto next_line;
+                }
+                current_sha256.bytes[i] = (uint8_t)byte;
+            }
+
             memset(&current_profile, 0, sizeof(current_profile));
-            current_profile.crc32 = current_crc;
+            current_profile.sha256 = current_sha256;
             current_profile.quirks = quirks_get_defaults();
+            has_current = 1;
+            continue;
+
+        next_line:
             continue;
         }
 
         /* Key=value pairs */
-        if (current_crc == 0) continue;
+        if (!has_current) continue;
 
         char key[256];
         int value;
@@ -96,7 +120,7 @@ static void parse_profiles_ini(void) {
     }
 
     /* Commit last entry */
-    if (current_crc != 0) hmput(profile_map, current_crc, current_profile);
+    if (has_current) hmput(profile_map, current_sha256, current_profile);
     fclose(file);
 }
 
@@ -177,8 +201,8 @@ void profiles_init(const char *custom_path) {
     }
 }
 
-const struct profile* profile_lookup(uint32_t crc32) {
-    ptrdiff_t idx = hmgeti(profile_map, crc32);
+const struct profile* profile_lookup(const sha256_hash_t *sha256) {
+    ptrdiff_t idx = hmgeti(profile_map, *sha256);
     return (idx >= 0) ? &profile_map[idx].value : NULL;
 }
 
@@ -196,11 +220,13 @@ static void profiles_write_to_file(void) {
     }
 
     fprintf(file, "# ROM Profiles Database\n");
-    fprintf(file, "# Format: [0xCRC32] followed by quirk settings\n\n");
+    fprintf(file, "# Format: [0xSHA256] followed by quirk settings\n\n");
 
     for (int i = 0; i < hmlen(profile_map); i++) {
         struct profile *p = &profile_map[i].value;
-        fprintf(file, "[0x%X]\n", p->crc32);
+        char hash_hex[65];
+        sha256_to_hex(&p->sha256, hash_hex, sizeof(hash_hex));
+        fprintf(file, "[%s]\n", hash_hex);
         if (p->rom_name[0] != '\0') fprintf(file, "name=%s\n", p->rom_name);
         for (size_t q = 0; q < NUM_QUIRK_FIELDS; q++) {
             bool val = *(bool *)((char *)&p->quirks + quirk_fields[q].offset);
@@ -222,18 +248,20 @@ void profiles_save_current(void) {
         return;
     }
 
-    uint32_t crc = crc32_compute(chip8.rom, chip8.rom_size);
+    sha256_hash_t sha256 = sha256_compute(chip8.rom, chip8.rom_size);
 
     struct profile p;
     memset(&p, 0, sizeof(p));
-    p.crc32 = crc;
+    p.sha256 = sha256;
     set_path(p.rom_name, sizeof(p.rom_name), chip8.rom_filename);
     p.quirks = chip8.quirks;
 
-    hmput(profile_map, crc, p);
+    hmput(profile_map, sha256, p);
     profiles_write_to_file();
 
-    printf("Saved ROM profile for: %s (CRC32: 0x%X)\n", chip8.rom_filename, crc);
+    char hash_hex[65];
+    sha256_to_hex(&sha256, hash_hex, sizeof(hash_hex));
+    printf("Saved ROM profile for: %s (SHA256: %s)\n", chip8.rom_filename, hash_hex);
     char msg[256];
     snprintf(msg, sizeof(msg), "Profile saved: %s", chip8.rom_filename);
     toast_show(TOAST_SUCCESS, msg);

shared/profiles.h

@@ -3,9 +3,10 @@
 
 #include <stdint.h>
 #include "quirks.h"
+#include "sha256.h"
 
 struct profile {
-    uint32_t crc32;
+    sha256_hash_t sha256;
     char rom_name[256];
     struct quirks quirks;
 };
@@ -14,8 +15,8 @@ struct profile {
  * Pass a custom file path, or NULL to use default search paths. */
 void profiles_init(const char *custom_path);
 
-/* Lookup a ROM profile by CRC32. Returns NULL if not found. */
-const struct profile* profile_lookup(uint32_t crc32);
+/* Lookup a ROM profile by SHA256. Returns NULL if not found. */
+const struct profile* profile_lookup(const sha256_hash_t *sha256);
 
 /* Save current ROM's quirks to the profile database and INI file
  * Requires: chip8.rom, chip8.rom_size, chip8.rom_filename, chip8.quirks

shared/profiles.ini

@@ -1,8 +1,8 @@
 # Kiwi8 ROM Profiles Database
 
-# Format: [0xCRC32] followed by quirk settings
+# Format: [0xSHA256] followed by quirk settings
 
-[0x9D307E90]
+[22ca535175f53fd0c8c0295b77198d7830a9c44b81497f14ee1fbc6c1322adc0]
 name=Blinky [Hans Christian Egeberg, 1991].ch8
 load_store_quirk=1
 shift_quirk=1
@@ -13,7 +13,7 @@ draw_flag_quirk=0
 vwrap=1
 hwrap=0
 
-[0x6FF0A017]
+[00bb7001de52b562d98357d33375406c6d0308466d7d95c2580537d2451a75cd]
 name=Space Invaders [David Winter].ch8
 load_store_quirk=0
 shift_quirk=0
@@ -24,7 +24,7 @@ draw_flag_quirk=0
 vwrap=0
 hwrap=1
 
-[0x614BA7F]
+[cfc1c1948c4419c3d45d98d8704885d8a0bc84d0d32022e069ac9119febe6035]
 name=Astro Dodge [Revival Studios, 2008].ch8
 load_store_quirk=1
 shift_quirk=1
@@ -35,7 +35,7 @@ draw_flag_quirk=0
 vwrap=1
 hwrap=0
 
-[0x9858889B]
+[871349b9cac53b5f99aabd3e25a71ad9979b85f1e7664049ad62fe288d1a0557]
 name=Connect 4 [David Winter].ch8
 load_store_quirk=1
 shift_quirk=1
@@ -46,7 +46,7 @@ draw_flag_quirk=0
 vwrap=1
 hwrap=0
 
-[0x61861AE5]
+[4f0b0ea0ca8cb819574dd1bef22943dd04282e005647f9dcfd9246d4e2458a89]
 name=Hidden [David Winter, 1996].ch8
 load_store_quirk=1
 shift_quirk=1
@@ -57,7 +57,7 @@ draw_flag_quirk=0
 vwrap=1
 hwrap=0
 
-[0x3A297A10]
+[4a07eed424eb5bbea779386f1c600f61ec7f6125539f64e4073cae2aeba7c039]
 name=Tic-Tac-Toe [David Winter].ch8
 load_store_quirk=1
 shift_quirk=1
@@ -68,7 +68,7 @@ draw_flag_quirk=0
 vwrap=1
 hwrap=0
 
-[0x511CDD7A]
+[f6024fea49433bb48b05fa05f7ab1d80696684d7cd89f884315494ed08fa4f22]
 name=Stars [Sergey Naydenov, 2010].ch8
 load_store_quirk=1
 shift_quirk=1
@@ -79,7 +79,7 @@ draw_flag_quirk=0
 vwrap=1
 hwrap=0
 
-[0xAAA44D0B]
+[c435e310ed832846a10f6d19e103910400a97dce27745370cb18207f24baee39]
 name=Brix [Andreas Gustafsson, 1990].ch8
 load_store_quirk=0
 shift_quirk=0
@@ -90,7 +90,7 @@ draw_flag_quirk=0
 vwrap=0
 hwrap=1
 
-[0x331413E7]
+[281d3bcc61227e15a5d3294b0e10facc156ec1bd819a3018d92e3ccf3a07acf1]
 name=UFO [Lutz V, 1992].ch8
 load_store_quirk=0
 shift_quirk=0
@@ -101,7 +101,7 @@ draw_flag_quirk=0
 vwrap=0
 hwrap=1
 
-[0x6465ACEF]
+[c37c9f76fa1061e1eb15e66ad76536798c84024bd67a64735cc454de0857f889]
 name=Animal Race [Brian Astle].ch8
 load_store_quirk=0
 shift_quirk=1

shared/sha256.cc

@@ -0,0 +1,54 @@
+#include "sha256.h"
+#include <string.h>
+#include <stdio.h>
+#include <openssl/evp.h>
+
+sha256_hash_t sha256_compute(const uint8_t* data, size_t len) {
+    sha256_hash_t result;
+    EVP_MD_CTX *mdctx = EVP_MD_CTX_new();
+
+    if (!mdctx) {
+        memset(&result, 0, sizeof(result));
+        return result;
+    }
+
+    if (!EVP_DigestInit_ex(mdctx, EVP_sha256(), NULL)) {
+        EVP_MD_CTX_free(mdctx);
+        memset(&result, 0, sizeof(result));
+        return result;
+    }
+
+    if (!EVP_DigestUpdate(mdctx, data, len)) {
+        EVP_MD_CTX_free(mdctx);
+        memset(&result, 0, sizeof(result));
+        return result;
+    }
+
+    unsigned int digest_len = 0;
+    if (!EVP_DigestFinal_ex(mdctx, result.bytes, &digest_len)) {
+        EVP_MD_CTX_free(mdctx);
+        memset(&result, 0, sizeof(result));
+        return result;
+    }
+
+    EVP_MD_CTX_free(mdctx);
+    return result;
+}
+
+void sha256_to_hex(const sha256_hash_t *hash, char *dst, size_t dst_size) {
+    if (dst_size < 65) return;  /* 64 hex chars + null terminator */
+
+    for (int i = 0; i < 32; i++) {
+        snprintf(dst + i*2, 3, "%02x", hash->bytes[i]);
+    }
+    dst[64] = '\0';
+}
+
+int sha256_equal(const sha256_hash_t *a, const sha256_hash_t *b) {
+    for (int i = 0; i < 32; i++) {
+        if (a->bytes[i] != b->bytes[i]) {
+            return 0;
+        }
+    }
+    return 1;
+}