make all print statements consistent and secure

Author: tomdaley92

shared/audio.cc

@@ -62,7 +62,7 @@ int audio_init(void) {
     int driver_found = 0;
     for (int i = 0; i < sizeof(drivers) / sizeof(drivers[0]); i++) {
         if (SDL_AudioInit(drivers[i]) == 0) {
-            fprintf(stdout, "Audio driver: %s\n", drivers[i]);
+            printf("Audio driver: %s\n", drivers[i]);
             char msg[256];
             snprintf(msg, sizeof(msg), "Audio driver: %s", drivers[i]);
             notify_show(NOTIFY_SUCCESS, msg);
@@ -71,18 +71,18 @@ int audio_init(void) {
         }
     }
     if (!driver_found) {
-        fprintf(stderr, "Could not initialize any audio driver, continuing without sound.\n");
+        printf("Could not initialize any audio driver, continuing without sound.\n");
         notify_show(NOTIFY_ERROR, "Could not initialize audio driver");
         notify_show(NOTIFY_INFO, "Continuing without sound");
     }
     audio.device = SDL_OpenAudioDevice(NULL, 0, &audio.audiospec, NULL, SDL_AUDIO_ALLOW_ANY_CHANGE);
     if (!audio.device) {
-        fprintf(stderr, "No audio device available, using dummy driver. %s\n", SDL_GetError());
+        printf("No audio device available, using dummy driver. %s\n", SDL_GetError());
         notify_show(NOTIFY_INFO, "Using dummy audio driver");
         SDL_setenv("SDL_AUDIODRIVER", "dummy", 1);
         audio.device = SDL_OpenAudioDevice(NULL, 0, &audio.audiospec, NULL, SDL_AUDIO_ALLOW_ANY_CHANGE);
         if (!audio.device) {
-            fprintf(stderr, "Failed to initialize audio (even with dummy driver): %s\n", SDL_GetError());
+            printf("Failed to initialize audio (even with dummy driver): %s\n", SDL_GetError());
             notify_show(NOTIFY_ERROR, "Failed to initialize audio");
             return 1;
         }

shared/chip8.cc

@@ -41,7 +41,7 @@ int chip8_init(
         SDL_INIT_VIDEO |
         SDL_INIT_EVENTS
     )) {
-        fprintf(stderr,"Error: %s\n", SDL_GetError());
+        printf("Error: %s\n", SDL_GetError());
         return 1;
     }
 
@@ -53,14 +53,14 @@ int chip8_init(
     chip8.vram = (unsigned char **) malloc(WIDTH * sizeof(unsigned char *));
     const char *err_str = "Unable to allocate memory on the heap.\n";
     if (!chip8.vram) {
-        fprintf(stderr, "%s", err_str);
+        printf("%s", err_str);
         return 1;
     }
     memset(chip8.vram, 0, WIDTH * sizeof(unsigned char *));
     for (int i = 0; i < WIDTH; i++) {
         chip8.vram[i] = (unsigned char *) malloc(HEIGHT * sizeof(unsigned char));
         if (!chip8.vram[i]) {
-            fprintf(stderr, "%s", err_str);
+            printf("%s", err_str);
             return 1;
         }
         memset(chip8.vram[i], 0, HEIGHT * sizeof(unsigned char));
@@ -103,7 +103,7 @@ int chip8_load_bootrom() {
     chip8.rom_size = BOOTROM_SIZE;
     chip8.rom = (unsigned char *)malloc(chip8.rom_size);
     if(!chip8.rom) {
-        fprintf(stderr, "Unable to allocate memory for rom.\n");
+        printf("Unable to allocate memory for rom.\n");
         return 1;
     }
     memset(chip8.rom, 0 , chip8.rom_size);
@@ -191,7 +191,7 @@ int chip8_load_rom(const char *rom_filepath) {
         /* load ROM from GUI */
         char new_rom_name[PATH_MAX];
         openFileDialog(new_rom_name) ?
-            fprintf(stdout, "User aborted the open file dialog.\n") :
+            printf("User aborted the open file dialog.\n") :
             chip8_load_rom(new_rom_name);
 
         /* flip GUI toggle */

shared/display.cc

@@ -48,15 +48,15 @@ int display_init(bool fullscreen) {
     const char *err_str = "Unable to allocate memory on the heap.\n";
 
     if(!display.back_buffer) {
-        fprintf(stderr, "%s", err_str);
+        printf("%s", err_str);
         return 1;
     }
     memset(display.back_buffer, 0, WIDTH * sizeof(unsigned char *));
 
     for (int i = 0; i < WIDTH; i++) {
         display.back_buffer[i] = (unsigned char *) malloc(HEIGHT * sizeof(unsigned char));
         if(!display.back_buffer[i]) {
-            fprintf(stderr, "%s", err_str);
+            printf("%s", err_str);
             return 1;
         }
         memset(display.back_buffer[i], 0, HEIGHT * sizeof(unsigned char));
@@ -79,7 +79,7 @@ int display_init(bool fullscreen) {
     );
 
     if (display.window == NULL) {
-        fprintf(stderr, "Error: %s\n", SDL_GetError());
+        printf("Error: %s\n", SDL_GetError());
         return 1;
     }
 

shared/main.cc

@@ -31,7 +31,7 @@ int main(int argc, char **argv){
             }
         }
         if (strcmp(argv[i], "--help") == 0 || strcmp(argv[i], "-h") == 0) {
-            fprintf(stderr, "%s", USAGE_TEXT);
+            printf("%s", USAGE_TEXT);
             return 0;
         }
         if (strcmp(argv[i], "--fullscreen") == 0) fullscreen = 1;

shared/profiles.cc

@@ -46,7 +46,7 @@ static void profiles_load_from_file(void) {
                 char notif_msg[256];
                 snprintf(notif_msg, sizeof(notif_msg), "Failed to create: %s", loaded_profiles_path);
                 notify_show(NOTIFY_ERROR, notif_msg);
-                fprintf(stderr, "Error: Unable to create profiles.ini at: %s\n", loaded_profiles_path);
+                printf("Error: Unable to create profiles.ini at: %s\n", loaded_profiles_path);
             }
             return;
         }
@@ -57,7 +57,7 @@ static void profiles_load_from_file(void) {
     /* Get executable's base path using SDL */
     base_path = SDL_GetBasePath();
     if (!base_path) {
-        fprintf(stderr, "Warning: Could not determine executable path. Trying current directory.\n");
+        printf("Warning: Could not determine executable path. Trying current directory.\n");
         snprintf(search_paths[0], sizeof(search_paths[0]), "./profiles.ini");
         snprintf(search_paths[1], sizeof(search_paths[1]), "../Resources/profiles.ini");
     } else {
@@ -99,7 +99,7 @@ static void profiles_load_from_file(void) {
             notify_show(NOTIFY_INFO, notif_msg);
         } else {
             notify_show(NOTIFY_ERROR, "Failed to create profiles.ini");
-            fprintf(stderr, "Error: Unable to create profiles.ini at: %s\n", search_paths[0]);
+            printf("Error: Unable to create profiles.ini at: %s\n", search_paths[0]);
         }
         return;
     }
@@ -132,7 +132,7 @@ static void profiles_load_from_file(void) {
             }
 
             if (sscanf(line, "[0x%x]", &current_crc) != 1) {
-                fprintf(stderr, "Error: Invalid profile section header: %s\n", line);
+                printf("Error: Invalid profile section header: %s\n", line);
                 current_crc = 0;
                 continue;
             }
@@ -215,13 +215,13 @@ static void profiles_write_to_file(void) {
     int i;
 
     if (loaded_profiles_path[0] == '\0') {
-        fprintf(stderr, "Error: profiles.ini path not initialized\n");
+        printf("Error: profiles.ini path not initialized\n");
         return;
     }
 
     file = fopen(loaded_profiles_path, "w");
     if (!file) {
-        fprintf(stderr, "Error: Unable to write to %s\n", loaded_profiles_path);
+        printf("Error: Unable to write to %s\n", loaded_profiles_path);
         return;
     }
 
@@ -284,7 +284,7 @@ void profiles_save_current(void) {
     /* Write entire hashmap to INI file */
     profiles_write_to_file();
 
-    fprintf(stdout, "Saved ROM profile for: %s (CRC32: 0x%X)\n",
+    printf("Saved ROM profile for: %s (CRC32: 0x%X)\n",
            chip8.rom_filename, crc32);
 
     /* Show success notification with path */