rename openFileDialog

Author: tomdaley92

linux/src/file_dialog.cc

@@ -2,7 +2,7 @@
 #include <gtk/gtk.h>
 #include <cstring>
 
-std::vector<std::string> openFileDialog(const std::string &title, const std::string &defaultDir, const std::vector<std::string> &filterExtensions) {
+std::vector<std::string> open_file_dialog(const std::string &title, const std::string &defaultDir, const std::vector<std::string> &filterExtensions) {
     std::vector<std::string> result;
 
     // Initialize GTK if not already initialized

linux/src/file_dialog.h

@@ -4,6 +4,6 @@
 #include <vector>
 #include <string>
 
-std::vector<std::string> openFileDialog(const std::string &title, const std::string &defaultDir, const std::vector<std::string> &filterExtensions);
+std::vector<std::string> open_file_dialog(const std::string &title, const std::string &defaultDir, const std::vector<std::string> &filterExtensions);
 
 #endif

macos/src/file_dialog.h

@@ -4,6 +4,6 @@
 #include <string>
 #include <vector>
 
-std::vector<std::string>openFileDialog(char const * const aTitle, char const * const aDefaultPathAndFile, const std::vector<std::string> & filters);
+std::vector<std::string>open_file_dialog(char const * const aTitle, char const * const aDefaultPathAndFile, const std::vector<std::string> & filters);
 
 #endif

macos/src/file_dialog.mm

@@ -4,7 +4,7 @@
 #include <string>
 #include <vector>
 
-std::vector<std::string>openFileDialog(
+std::vector<std::string>open_file_dialog(
     char const * const aTitle ,
     char const * const aDefaultPathAndFile ,
     const std::vector<std::string> & filters) {

shared/chip8.cc

@@ -193,7 +193,7 @@ int chip8_load_rom(const char *rom_filepath) {
     } else {
         /* load ROM from GUI */
         char new_rom_name[PATH_MAX];
-        openFileDialog(new_rom_name) ?
+        open_file_dialog(new_rom_name) ?
             printf("User aborted the open file dialog.\n") :
             chip8_load_rom(new_rom_name);
 

shared/open_file_dialog.cc

@@ -17,20 +17,20 @@
 #endif
 
 /* Returns 0 on success, 1 on error (or user hit cancel) */
-int openFileDialog(char *rom_name) {
+int open_file_dialog(char *rom_name) {
 
     #if defined(__APPLE__) || defined(__linux__)
     // Common flow for Apple and Linux: both return a vector<string>
     std::vector<std::string> fileTypes = {"ch8", "CH8", "chip-8", "CHIP-8", "Chip-8"};
     const char* defaultDir = ""; // unify behavior: let OS choose last-used/home
-    std::vector<std::string> files = openFileDialog("Chip8", defaultDir, fileTypes);
+    std::vector<std::string> files = open_file_dialog("Chip8", defaultDir, fileTypes);
     if (files.empty()) return 1;
     snprintf(rom_name, 256, "%s", files[0].c_str());
     return 0;
 
     #elif defined(_WIN32)
     // Windows API variant writes directly into buffer and returns int
-    return openFileDialog(rom_name, "Chip8\0*.ch8\0All\0*.*\0");
+    return open_file_dialog(rom_name, "Chip8\0*.ch8\0All\0*.*\0");
 
     #else
     return 1;

shared/open_file_dialog.h

@@ -14,6 +14,6 @@
 #include <limits.h> /* PATH_MAX */
 #endif
 
-int openFileDialog(char *rom_name);
+int open_file_dialog(char *rom_name);
 
 #endif

windows/src/file_dialog.cc

@@ -4,7 +4,7 @@
 #include <stdlib.h>
 #include <string.h>
 
-int openFileDialog(char *rom_name, char *filters) {
+int open_file_dialog(char *rom_name, char *filters) {
     /* open file dialogue */
     char cwd[MAX_PATH];
     GetCurrentDirectory(MAX_PATH, cwd);
@@ -34,7 +34,7 @@ int openFileDialog(char *rom_name, char *filters) {
         /* user hit cancel */
         return 1;
     }
-    
+
     strcpy(rom_name, szFile);
     return 0;
-}
+}

windows/src/file_dialog.h

@@ -1,6 +1,6 @@
 #ifndef WIN32_FILE_DIALOG_H
 #define WIN32_FILE_DIALOG_H
 
-int openFileDialog(char *rom_name, char *filters);
+int open_file_dialog(char *rom_name, char *filters);
 
 #endif