Skip to content

OLEDrgb_DrawRectangle colors off by 1 #53

@d-burnett

Description

@d-burnett

Per the "Drawing Rectangle" section of page 32 of the SSD1331 datasheet, bits corresponding to color A and color C include 1 bit of padding. This means fillColor should be padded in four places inside the OLEDrgb_DrawRectangle function as written below. I have tested and verified these revisions.

   cmds[7] = OLEDrgb_ExtractRFromRGB(lineColor) << 1;   // R
   cmds[8] = OLEDrgb_ExtractGFromRGB(lineColor);   // G
   cmds[9] = OLEDrgb_ExtractBFromRGB(lineColor) << 1;   // B

   cmds[10] = OLEDrgb_ExtractRFromRGB(fillColor) << 1;  // R
   cmds[11] = OLEDrgb_ExtractGFromRGB(fillColor);  // G
   cmds[12] = OLEDrgb_ExtractBFromRGB(fillColor) << 1;  // B

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions