Does Anyone know is there a way?

[Milkman9691]

@DimaKudosh is there a way to form stacks this way?

I have my roster order columns and batting orders before I run the opt but I was trying to eliminate the 7,8,9 hitters from my stack consideration but not for overall lineup consideration. If "optimizer.set_spacing_for_positions(['1B', '2B', '3B'], 3)" is used it could use a 9,1,2 wrap or 8,9,1 wrap to which i am trying to avoid. The "spacing=" argument could also give a wrap around. For MLB the 7,8,9 roster positions are pretty much useless but you will still need to be able to let them be in the selection process but wantig the core of stacks to come from the 1-6 positions. In 2023 82.7% of the top fantasy points scored came from batting positions 1-6 So far in 2024 that number is 79%. This is the importance of wanting to try to find a way.

optimizer.add_stack(TeamStack(3, for_teams=['ATL'], for_roster_order=['1', '2', '3', '4', '5','6']))
or
optimizer.add_stack(TeamStack(3, for_teams=['ATL'], for_roster_order=['1-6']))

Thx beforehand

[Denwen12]

I did a quick look in the team stack function so this may be possible but may need further discussion To achieve your goal of stacking primarily from batting positions 1-6 while still allowing the 7,8,9 hitters to be in the selection process, you can use the "for_batting_order" parameter in the TeamStack constructor. This parameter allows you to specify the range of batting positions you want to include in the stack. Here is an example of how you can modify your code to achieve this: optimizer.add_stack(TeamStack(3, for_teams=['ATL'], for_batting_order=(1, 6))) This code will create a stack for the Atlanta Braves that includes players from batting positions 1 through 6. The 7, 8, and 9 hitters will still be considered for selection, but the core of the stack will come from the top 6 positions. By using the "for_batting_order" parameter, you can customize the selection process to prioritize players from specific batting positions while still allowing for flexibility in the overall lineup construction.

…

On Tue, Apr 9, 2024, 11:55 PM G Dub D ***@***.***> wrote: @DimaKudosh <https://github.com/DimaKudosh> is there a way to form stacks this way? I have my roster order columns and batting orders before I run the opt but I was trying to eliminate the 7,8,9 hitters from my stack consideration but not for overall lineup consideration. If "optimizer.set_spacing_for_positions(['1B', '2B', '3B'], 3)" is used it could use a 9,1,2 wrap or 8,9,1 wrap to which i am trying to avoid. The "spacing=" argument could also give a wrap around. For MLB the 7,8,9 roster positions are pretty much useless but you will still need to be able to let them be in the selection process but wantig the core of stacks to come from the 1-6 positions. In 2023 82.7% of the top fantasy points scored came from batting positions 1-6 So far in 2024 that number is 79%. This is the importance of wanting to try to find a way. optimizer.add_stack(TeamStack(3, for_teams=['ATL'], for_roster_order=['1', '2', '3', '4', '5','6'])) or optimizer.add_stack(TeamStack(3, for_teams=['ATL'], for_roster_order=['1-6'])) Thx beforehand — Reply to this email directly, view it on GitHub <#426>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANBWO7VS6RJ5XAZXEQBC6CDY4SZ2BAVCNFSM6AAAAABF7VX7GCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZTINZQGU4TMOA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[Milkman9691]

Thanks bunches. You are awesome for creating this btw.

[Milkman9691]

---

TypeError Traceback (most recent call last)
Cell In[58], line 1
----> 1 optimizer.add_stack(TeamStack(3, for_teams=['ATL'], for_batting_order=(1,6)))

TypeError: TeamStack.init() got an unexpected keyword argument 'for_batting_order'

Now I am lost

[Denwen12]

It didn't work so disregard that I'll look more into it

…

On Wed, Apr 10, 2024, 1:27 AM G Dub D ***@***.***> wrote: ------------------------------ TypeError Traceback (most recent call last) Cell In[58], line 1 ----> 1 optimizer.add_stack(TeamStack(3, for_teams=['ATL'], for_batting_order=(1,6))) TypeError: TeamStack.*init*() got an unexpected keyword argument 'for_batting_order' Now I am lost — Reply to this email directly, view it on GitHub <#426 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANBWO7QAK3AKYSHVB5Z6HZ3Y4TEV5AVCNFSM6AAAAABF7VX7GCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBWGU3DIMRUHE> . You are receiving this because you commented.Message ID: ***@***.***>

[Denwen12]

Try this Here's an example of how you can set the spacing parameter for positions 7, 8, and 9: optimizer.add_stack(TeamStack(3, for_teams=['ATL'], for_positions=['7', '8', '9'], spacing=9999)) By setting a high spacing value for positions 7, 8, and 9, you are essentially reducing the chances of these players being included in the stack while still allowing them to be part of the overall lineup consideration. This can be a workaround to achieve your goal without directly modifying the class or filtering players before adding them to the optimizer.

…

On Wed, Apr 10, 2024, 2:01 AM joseph offen ***@***.***> wrote: It didn't work so disregard that I'll look more into it On Wed, Apr 10, 2024, 1:27 AM G Dub D ***@***.***> wrote: > ------------------------------ > > TypeError Traceback (most recent call last) > Cell In[58], line 1 > ----> 1 optimizer.add_stack(TeamStack(3, for_teams=['ATL'], > for_batting_order=(1,6))) > > TypeError: TeamStack.*init*() got an unexpected keyword argument > 'for_batting_order' > > Now I am lost > > — > Reply to this email directly, view it on GitHub > <#426 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ANBWO7QAK3AKYSHVB5Z6HZ3Y4TEV5AVCNFSM6AAAAABF7VX7GCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBWGU3DIMRUHE> > . > You are receiving this because you commented.Message ID: > ***@***.***> >

[Milkman9691]

Got this Error
LineupOptimizerIncorrectPositionName Traceback (most recent call last)
Cell In[201], line 1
----> 1 optimizer.add_stack(TeamStack(3, for_teams=['ATL'], for_positions=['7', '8', '9'], spacing=9999))

File ~\anaconda3\Lib\site-packages\pydfs_lineup_optimizer\lineup_optimizer.py:342, in LineupOptimizer.add_stack(self, stack)
341 def add_stack(self, stack: BaseStack) -> None:
--> 342 stack.validate(self)
343 self.stacks.append(stack)

File ~\anaconda3\Lib\site-packages\pydfs_lineup_optimizer\stacks.py:210, in TeamStack.validate(self, optimizer)
208 for position in self.for_positions or []:
209 if position not in optimizer.player_pool.available_positions:
--> 210 raise LineupOptimizerIncorrectPositionName('%s is incorrect position name.' % position)

LineupOptimizerIncorrectPositionName: 7 is incorrect position name.

[Milkman9691]

Tried it as roster_order and got

TypeError Traceback (most recent call last)
Cell In[212], line 1
----> 1 optimizer.add_stack(TeamStack(3, for_teams=['ATL'], for_roster_order=['7', '8', '9'], spacing=9999))

TypeError: TeamStack.init() got an unexpected keyword argument 'for_roster_order'

[Denwen12]

Instead of positions change it to for_roster_order See what that will do

…

On Wed, Apr 10, 2024, 2:11 AM G Dub D ***@***.***> wrote: Got this Error LineupOptimizerIncorrectPositionName Traceback (most recent call last) Cell In[201], line 1 ----> 1 optimizer.add_stack(TeamStack(3, for_teams=['ATL'], for_positions=['7', '8', '9'], spacing=9999)) File ~\anaconda3\Lib\site-packages\pydfs_lineup_optimizer\lineup_optimizer.py:342, in LineupOptimizer.add_stack(self, stack) 341 def add_stack(self, stack: BaseStack) -> None: --> 342 stack.validate(self) 343 self.stacks.append(stack) File ~\anaconda3\Lib\site-packages\pydfs_lineup_optimizer\stacks.py:210, in TeamStack.validate(self, optimizer) 208 for position in self.for_positions or []: 209 if position not in optimizer.player_pool.available_positions: --> 210 raise LineupOptimizerIncorrectPositionName('%s is incorrect position name.' % position) LineupOptimizerIncorrectPositionName: 7 is incorrect position name. — Reply to this email directly, view it on GitHub <#426 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANBWO7W2RB5B2JYMMTRDA2TY4TJYJAVCNFSM6AAAAABF7VX7GCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBWGYYDKMBXHE> . You are receiving this because you commented.Message ID: ***@***.***>

[Milkman9691]

TypeError Traceback (most recent call last)
Cell In[234], line 1
----> 1 optimizer.add_stack(TeamStack(3, for_teams=['ATL'], for_roster_order=['7', '8', '9'], spacing=9999))

TypeError: TeamStack.init() got an unexpected keyword argument 'for_roster_order'

[Denwen12]

Still looking into it

…

On Wed, Apr 10, 2024, 2:16 AM G Dub D ***@***.***> wrote: TypeError Traceback (most recent call last) Cell In[234], line 1 ----> 1 optimizer.add_stack(TeamStack(3, for_teams=['ATL'], for_roster_order=['7', '8', '9'], spacing=9999)) TypeError: TeamStack.*init*() got an unexpected keyword argument 'for_roster_order' — Reply to this email directly, view it on GitHub <#426 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANBWO7U3V2ZO67DPPTPKD6LY4TKMBAVCNFSM6AAAAABF7VX7GCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBWGYYTAMRUHA> . You are receiving this because you commented.Message ID: ***@***.***>

[Denwen12]

Try this # Sort players based on roster order players.sort(key=lambda x: x.roster_order) # Select players for positions 1-6 selected_players = [player for player in players if player.roster_order in ['1', '2', '3', '4', '5', '6']] # Add selected players for stacking optimizer.add_stack(TeamStack(3, for_teams=['ATL'], for_positions=None, spacing=None).build_stacks(selected_players, optimizer))

…

On Wed, Apr 10, 2024, 2:17 AM joseph offen ***@***.***> wrote: Still looking into it On Wed, Apr 10, 2024, 2:16 AM G Dub D ***@***.***> wrote: > TypeError Traceback (most recent call last) > Cell In[234], line 1 > ----> 1 optimizer.add_stack(TeamStack(3, for_teams=['ATL'], > for_roster_order=['7', '8', '9'], spacing=9999)) > > TypeError: TeamStack.*init*() got an unexpected keyword argument > 'for_roster_order' > > — > Reply to this email directly, view it on GitHub > <#426 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ANBWO7U3V2ZO67DPPTPKD6LY4TKMBAVCNFSM6AAAAABF7VX7GCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBWGYYTAMRUHA> > . > You are receiving this because you commented.Message ID: > ***@***.***> >

[Milkman9691]

NameError Traceback (most recent call last)
Cell In[259], line 1
----> 1 players.sort(key=lambda x: x.roster_order)

NameError: name 'players' is not defined

[Denwen12]

I'll look into it more this weekend for you

…

On Wed, Apr 10, 2024, 2:26 AM G Dub D ***@***.***> wrote: NameError Traceback (most recent call last) Cell In[259], line 1 ----> 1 players.sort(key=lambda x: x.roster_order) NameError: name 'players' is not defined — Reply to this email directly, view it on GitHub <#426 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANBWO7VWUJL3BRDFZNPWIB3Y4TLSLAVCNFSM6AAAAABF7VX7GCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBWGYZDCNBSGQ> . You are receiving this because you commented.Message ID: ***@***.***>

[Milkman9691]

I am trying multiple things over here between msgs but I am not being much help but I appreciate evrything you are doing to assist. If I somehow get it I will let you know also. Thx again

[Denwen12]

Can you send your config to ***@***.***

…

On Wed, Apr 10, 2024, 2:27 AM joseph offen ***@***.***> wrote: I'll look into it more this weekend for you On Wed, Apr 10, 2024, 2:26 AM G Dub D ***@***.***> wrote: > NameError Traceback (most recent call last) > Cell In[259], line 1 > ----> 1 players.sort(key=lambda x: x.roster_order) > > NameError: name 'players' is not defined > > — > Reply to this email directly, view it on GitHub > <#426 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ANBWO7VWUJL3BRDFZNPWIB3Y4TLSLAVCNFSM6AAAAABF7VX7GCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBWGYZDCNBSGQ> > . > You are receiving this because you commented.Message ID: > ***@***.***> >