Merge pull request #1 from DiogoRibeiro7/solver_fix

fix: Replace solver asserts with explicit runtime checks

Author: DiogoRibeiro7

min_ratio_cycle/solver.py

@@ -666,7 +666,10 @@ def _solve_exact(self, **kwargs) -> SolverResult:
                 error_message="Exact mode requires integer weights",
             )
 
-        assert self._Ci is not None and self._Ti is not None
+        if self._Ci is None or self._Ti is None:
+            raise RuntimeError(
+                "Integer weight arrays (_Ci, _Ti) must be initialized before solving"
+            )
 
         max_den = kwargs.get("max_denominator", self.config.exact_max_denominator)
         max_steps = kwargs.get("max_steps", self.config.exact_max_steps)
@@ -702,7 +705,10 @@ def _stern_brocot_search(
         self, max_den: Optional[int], max_steps: Optional[int]
     ) -> Tuple[List[int], int, int, Tuple[int, int], float]:
         """Implement Stern-Brocot tree search for exact optimal ratio."""
-        assert self._Ci is not None and self._Ti is not None
+        if self._Ci is None or self._Ti is None:
+            raise RuntimeError(
+                "Integer weight arrays (_Ci, _Ti) must be initialized before searching"
+            )
 
         # Set defaults
         if max_den is None:
@@ -772,9 +778,18 @@ def _combine_weights_exact(self, a: int, b: int) -> np.ndarray:
 
     def _has_negative_cycle_exact(self, a: int, b: int) -> bool:
         """Check for negative cycle with exact integer arithmetic."""
-        assert self._U is not None and self._V is not None
-        assert self._Ci is not None and self._Ti is not None
-        assert self._starts is not None and self._counts is not None
+        if self._U is None or self._V is None:
+            raise RuntimeError(
+                "Edge endpoint arrays (_U, _V) must be initialized before cycle checks"
+            )
+        if self._Ci is None or self._Ti is None:
+            raise RuntimeError(
+                "Integer weight arrays (_Ci, _Ti) must be initialized before cycle checks"
+            )
+        if self._starts is None or self._counts is None:
+            raise RuntimeError(
+                "Segment arrays (_starts, _counts) must be initialized before cycle checks"
+            )
 
         W = self._combine_weights_exact(a, b)
         dist = np.zeros(self.n, dtype=np.int64)
@@ -815,8 +830,14 @@ def _find_zero_cycle_exact(
         if not ok:
             return None
 
-        assert self._U is not None and self._V is not None
-        assert self._Ci is not None and self._Ti is not None
+        if self._U is None or self._V is None:
+            raise RuntimeError(
+                "Edge endpoint arrays (_U, _V) must be initialized before cycle extraction"
+            )
+        if self._Ci is None or self._Ti is None:
+            raise RuntimeError(
+                "Integer weight arrays (_Ci, _Ti) must be initialized before cycle extraction"
+            )
 
         W = self._combine_weights_exact(a, b)
         equal_mask = (dist[self._U] + W) == dist[self._V]
@@ -864,9 +885,18 @@ def dfs(u: int) -> Optional[List[int]]:
 
     def _compute_potentials_exact(self, a: int, b: int) -> Tuple[bool, np.ndarray]:
         """Compute shortest path potentials with exact arithmetic."""
-        assert self._U is not None and self._V is not None
-        assert self._Ci is not None and self._Ti is not None
-        assert self._starts is not None and self._counts is not None
+        if self._U is None or self._V is None:
+            raise RuntimeError(
+                "Edge endpoint arrays (_U, _V) must be initialized before computing potentials"
+            )
+        if self._Ci is None or self._Ti is None:
+            raise RuntimeError(
+                "Integer weight arrays (_Ci, _Ti) must be initialized before computing potentials"
+            )
+        if self._starts is None or self._counts is None:
+            raise RuntimeError(
+                "Segment arrays (_starts, _counts) must be initialized before computing potentials"
+            )
 
         W = self._combine_weights_exact(a, b)
         dist = np.zeros(self.n, dtype=np.int64)
@@ -1053,9 +1083,18 @@ def _detect_negative_cycle_numeric(
         self, lam: float, slack: float = 0.0
     ) -> Tuple[bool, Optional[Tuple[List[int], float, float, float]]]:
         """Detect negative cycle using vectorized Bellman-Ford."""
-        assert self._U is not None and self._V is not None
-        assert self._C is not None and self._T is not None
-        assert self._starts is not None and self._counts is not None
+        if self._U is None or self._V is None:
+            raise RuntimeError(
+                "Edge endpoint arrays (_U, _V) must be initialized before numeric cycle detection"
+            )
+        if self._C is None or self._T is None:
+            raise RuntimeError(
+                "Weight arrays (_C, _T) must be initialized before numeric cycle detection"
+            )
+        if self._starts is None or self._counts is None:
+            raise RuntimeError(
+                "Segment arrays (_starts, _counts) must be initialized before numeric cycle detection"
+            )
 
         n = self.n
         W = self._C - lam * self._T

pyproject.toml

@@ -16,17 +16,27 @@ psutil = "^7.0"  # Resource monitoring
 
 [tool.poetry.group.dev.dependencies]
 pytest = "^8.0"
-hypothesis = "^6.100"  # Property-based testing
-pytest-cov = "^4.1"    # Coverage reporting
-pytest-benchmark = "^4.0"  # Performance benchmarking
-pytest-xdist = "^3.3"  # Parallel test execution
-black = "^23.0"        # Code formatting
-isort = "^5.12"        # Import sorting
-mypy = "^1.5"          # Type checking
-flake8 = "^6.0"        # Linting
-sphinx = "^7.0"        # Documentation generator
-pre-commit = "^3.5"    # Git hook management
-bandit = "^1.7"        # Security scanning
+hypothesis = "^6.100" 
+pytest-cov = "^4.1"    
+pytest-benchmark = "^4.0"  
+pytest-xdist = "^3.3"  
+black = "^23.0"        
+isort = "^5.12"        
+mypy = "^1.5"          
+flake8 = "^6.0"        
+sphinx = "^7.0"        
+pre-commit = "^3.5"    
+bandit = "^1.7"        
+requests = ">=2.32.4,<3.0.0"
+urllib3 = ">=2.5.0,<3.0.0"
+idna = ">=3.7,<4.0.0"
+certifi = ">=2024.7.4,<2026.0.0"
+cryptography = ">=42.0.5,<43.0.0"
+configobj = ">=5.0.9,<6.0.0"
+pyjwt = ">=2.10.1,<3.0.0"
+jinja2 = ">=3.1.6,<4.0.0"
+setuptools = ">=78.1.1"
+twisted = ">=24.7.0"
 
 [tool.poetry.group.test.dependencies]
 # Additional test utilities