fix: fix and improvemets

Author: DiogoRibeiro7

R/goodbye.R

@@ -5,8 +5,9 @@
 #'
 #' @param name Character string. The name to bid farewell to. Default is "world".
 #' @param language Character string. The language for the farewell.
-#'        Supported languages: "english" (default), "spanish", "french", "portuguese".
+#'        Supported languages: "english" (default), "spanish", "french", "portuguese", "german", "italian".
 #' @param exclamation Logical. Whether to add an exclamation mark. Default is TRUE.
+#' @param capitalize Logical. Whether to capitalize the name. Default is FALSE.
 #'
 #' @return A character string containing the farewell message.
 #' @export
@@ -16,9 +17,10 @@
 #' goodbye("R Users")
 #' goodbye("amigos", language = "spanish")
 #' goodbye("mes amis", language = "french", exclamation = FALSE)
+#' goodbye("world", capitalize = TRUE)
 #'
 #' @seealso \code{\link{hello}} for a greeting function
-goodbye <- function(name = "world", language = "english", exclamation = TRUE) {
+goodbye <- function(name = "world", language = "english", exclamation = TRUE, capitalize = FALSE) {
   # Input validation
   if (!is.character(name) || length(name) != 1) {
     stop("'name' must be a single character string")
@@ -28,18 +30,43 @@ goodbye <- function(name = "world", language = "english", exclamation = TRUE) {
     stop("'language' must be a single character string")
   }
 
+  # Validate language parameter
+  supported_languages <- c("english", "spanish", "french", "portuguese", "german", "italian")
+  language <- tolower(language)
+  if (!language %in% supported_languages) {
+    warning(
+      sprintf(
+        "Language '%s' not supported. Using English instead. Supported languages: %s",
+        language,
+        paste(supported_languages, collapse = ", ")
+      )
+    )
+    language <- "english"
+  }
+
   if (!is.logical(exclamation) || length(exclamation) != 1) {
     stop("'exclamation' must be a single logical value")
   }
 
+  if (!is.logical(capitalize) || length(capitalize) != 1) {
+    stop("'capitalize' must be a single logical value")
+  }
+
+  # Capitalize name if requested
+  if (capitalize) {
+    name <- paste0(toupper(substr(name, 1, 1)), substr(name, 2, nchar(name)))
+  }
+
   # Select farewell based on language
   farewell <- switch(
-    tolower(language),
+    language,
     english = "Goodbye",
     spanish = "Adi\u00f3s", # Using Unicode escape for 'ó'
     french = "Au revoir",
     portuguese = "Adeus",
-    # Default to English if language not supported
+    german = "Auf Wiedersehen",
+    italian = "Arrivederci",
+    # Default to English if language not supported (shouldn't happen due to validation)
     "Goodbye"
   )
 

R/hello.R

@@ -5,8 +5,9 @@
 #'
 #' @param name Character string. The name to greet. Default is "world".
 #' @param language Character string. The language for the greeting.
-#'        Supported languages: "english" (default), "spanish", "french", "portuguese".
+#'        Supported languages: "english" (default), "spanish", "french", "portuguese", "german", "italian".
 #' @param exclamation Logical. Whether to add an exclamation mark. Default is TRUE.
+#' @param capitalize Logical. Whether to capitalize the name. Default is FALSE.
 #'
 #' @return A character string containing the greeting.
 #' @export
@@ -16,9 +17,10 @@
 #' hello("R Users")
 #' hello("amigos", language = "spanish")
 #' hello("mes amis", language = "french", exclamation = FALSE)
+#' hello("world", capitalize = TRUE)
 #'
 #' @seealso \code{\link{goodbye}} for a farewell function
-hello <- function(name = "world", language = "english", exclamation = TRUE) {
+hello <- function(name = "world", language = "english", exclamation = TRUE, capitalize = FALSE) {
   # Input validation
   if (!is.character(name) || length(name) != 1) {
     stop("'name' must be a single character string")
@@ -28,18 +30,43 @@ hello <- function(name = "world", language = "english", exclamation = TRUE) {
     stop("'language' must be a single character string")
   }
 
+  # Validate language parameter
+  supported_languages <- c("english", "spanish", "french", "portuguese", "german", "italian")
+  language <- tolower(language)
+  if (!language %in% supported_languages) {
+    warning(
+      sprintf(
+        "Language '%s' not supported. Using English instead. Supported languages: %s",
+        language,
+        paste(supported_languages, collapse = ", ")
+      )
+    )
+    language <- "english"
+  }
+
   if (!is.logical(exclamation) || length(exclamation) != 1) {
     stop("'exclamation' must be a single logical value")
   }
 
+  if (!is.logical(capitalize) || length(capitalize) != 1) {
+    stop("'capitalize' must be a single logical value")
+  }
+
+  # Capitalize name if requested
+  if (capitalize) {
+    name <- paste0(toupper(substr(name, 1, 1)), substr(name, 2, nchar(name)))
+  }
+
   # Select greeting based on language
   greeting <- switch(
-    tolower(language),
+    language,
     english = "Hello",
     spanish = "Hola",
     french = "Bonjour",
     portuguese = "Ol\u00e1", # Using Unicode escape for 'á'
-    # Default to English if language not supported
+    german = "Hallo",
+    italian = "Ciao",
+    # Default to English if language not supported (shouldn't happen due to validation)
     "Hello"
   )
 

R/utils.R

@@ -0,0 +1,23 @@
+# Internal utility functions
+
+#' Get supported languages
+#'
+#' Returns a vector of languages supported by greeting functions
+#'
+#' @return Character vector of supported language names
+#' @keywords internal
+get_supported_languages <- function() {
+  c("english", "spanish", "french", "portuguese", "german", "italian")
+}
+
+#' Capitalize first letter
+#'
+#' Capitalizes the first letter of a string
+#'
+#' @param x Character string to capitalize
+#' @return Character string with first letter capitalized
+#' @keywords internal
+capitalize_first <- function(x) {
+  if (nchar(x) == 0) return(x)
+  paste0(toupper(substr(x, 1, 1)), substr(x, 2, nchar(x)))
+}

_pkgdown.yml

@@ -48,7 +48,7 @@ reference:
   - title: "Package Information"
     desc: "Documentation about the package itself"
     contents:
-      - myrpackage-package
+      - "myrpackage-package"  # Use quotes to ensure it's treated as a literal string
       - myrpackage-lifecycle
 
 home: