push page to browser history without navigating to it

[brianmay]

Currently if I want to push an item to the browser history, I have to navigate to that page, which AFAIK completely replaces the current page with the new page:

let navigator = navigator();
navigator.push(Route::Details {id});

But sometimes I just want to be able to popup a Dialog box and push the new URL to the browser stack without entirely replacing the page. For example, if the user clicks an item I want to be able to show the details as a dialog.

Is this possible?

Or is this a bad idea?

[ealmloff]

It should only replace the parts of the page/layout that have changed. There is a bug in debug mode today that causes more state to be wiped than is required. See #3235 for more information

[ealmloff]

For example, this works in release mode (but not in debug mode because of the bug):

use dioxus::prelude::*;

fn main() {
    dioxus::launch(|| {
        rsx! {
            Router::<Route> {}
        }
    });
}

#[derive(Routable, Clone, Debug, PartialEq)]
#[rustfmt::skip]
enum Route {
    // The default route is always "/" unless otherwise specified
    #[route("/", MaybeSelected)]
    Home {},

    #[route("/:selected", MaybeSelected)]
    Selected {
        selected: String,
    },
}

#[component]
fn MaybeSelected(selected: Option<String>) -> Element {
    static COMPONENT_COUNTER: GlobalSignal<usize> = GlobalSignal::new(|| 0);
    let component_id = use_hook(|| {
        let mut write = COMPONENT_COUNTER.write();
        *write += 1;
        *write
    });

    rsx! {
        div { id: "maybe-selected",
            h1 { "Dioxus Blog" }
            p { "{component_id}" }
            "{selected:?}"
        }

        Link {
            to: Route::Selected { selected: "123".to_string() },
            "Go to selected 123"
        }

        Link {
            to: Route::Home {},
            "Go to home"
        }
    }
}

[brianmay]

I notice that #3225 is closed in 0.6.3, but it looks like this is still broken. At least for my stupid test case. Except in release mode.

Also, assuming you have to use the same component from the route for this to work? i.e. if you split the above up into two components that render the same shared component this would presumable stop working?

[ealmloff]

I notice that #3225 is closed in 0.6.3, but it looks like this is still broken. At least for my stupid test case. Except in release mode.

Can you share your test case? The example I posted seems to work in 0.6.3 after running cargo update

Also, assuming you have to use the same component from the route for this to work? i.e. if you split the above up into two components that render the same shared component this would presumable stop working?

Yes, that is one of the tradeoffs of the template diffing system. It only does shallow diffing until it finds something like a component that is different

[brianmay]

Unfortunately my test case was somewhat a mess. And I have since taken a different approach entirely (for now).

[brianmay]

I just realized my test was invalid. I updated the dioxus CLI, but had forgotten to update the dioxus crate. Oops. Sorry about that.