Already borrowed calling callback

[brianmay]

I have a component to display a different dialog depending on an enum parameter:

#[component]
pub fn ConsumableDialog(
    dialog: ReadOnlySignal<ActiveDialog>,
    on_change: Callback<Consumable>,
    on_change_ingredients: Callback<Consumable>,
    on_delete: Callback<Consumable>,
    show_edit: Callback<Consumable>,
    show_ingredients: Callback<Consumable>,
    show_nested_ingredient: Callback<(Consumable, Consumable)>,
    show_nested_ingredients: Callback<(Consumable, Consumable)>,
    on_close: Callback<()>,
) -> Element {
    tracing::debug!("5555 {:?}", dialog());
    // let x = use_callback(|_| tracing::debug!("CALLBACK!"));
    match dialog() {

        [...]
        
        ActiveDialog::Ingredients(consumable) => {
            rsx! {
                Dialog {
                    ConsumableNested {
                        consumable,
                        on_close,
                        on_change: on_change_ingredients,
                        show_edit,
                        show_ingredient: show_nested_ingredient,
                        show_ingredients: show_nested_ingredients
                    }
                }
            }
        }
        
        [...]
        
        ActiveDialog::NestedIngredients(parent, consumable) => {
            tracing::debug!("6666 {:?}", dialog());
            let parent_clone_1 = parent.clone();
            let parent_clone_2 = parent.clone();
            let parent_clone_3 = parent.clone();
            let parent_clone_4 = parent.clone();
            rsx! {
                Dialog {
                    ConsumableNested {
                        consumable,
                        on_close: move |()| {
                            show_ingredients(parent.clone())
                        },
                        on_change: move |_consumable: Consumable| {
                            on_change_ingredients(parent_clone_1.clone());
                        },
                        show_edit: move |consumable: Consumable| {
                            tracing::debug!("!!!!");
                            // x((parent_clone_2.clone(), consumable));
                            show_nested_ingredient((parent_clone_2.clone(), consumable));
                            tracing::debug!("@@@@@");
                        },
                        show_ingredient: move |(_parent, consumable): (Consumable, Consumable)| {
                            show_nested_ingredients((parent_clone_3.clone(), consumable));
                        },
                        show_ingredients: move |(_parent, consumable): (Consumable, Consumable)| {
                            show_nested_ingredients((parent_clone_4.clone(), consumable.clone()));
                        },
                    }
                }
            }
        }
    }
}

(The names are terrible - something I need to fix still)

In the first case we show the Ingredients dialog. The user clicks a button which invokes the show_nested_ingredients which runs a navigator.push() command:

                        navigator
                            .push(Route::ConsumableList{
                                dialog: ListDialogReference::NestedIngredients { parent_id: parent.id, consumable_id: consumable.id}
                            });

This then displays the NestedIngredients dialog. The user clicks another button when invokes the show_edit button, which prints the "!!!!" debug message, and tries to call the show_nested_ingredient callback. This call back does nothing except print using tracing::debug!(). This message does not appear. Instead the attempt to call the callback panics with the error:

07:44:38 [web] panicked at /home/brian/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/dioxus-ccalled `Result::unwrap()` on an `Err` value: AlreadyBorrowed(AlreadyBorrowedError { borrowed_at: [] })
Stack:

__wbg_get_imports/imports.wbg.__wbg_new_8a6f238a6ece86ea/<@http://localhost:4000/assets/penguin_nurse-8db6f0f87eeb2da9.js:5:33553
logError@http://localhost:4000/assets/penguin_nurse-8db6f0f87eeb2da9.js:1:22234
__wbg_get_imports/imports.wbg.__wbg_new_8a6f238a6ece86ea@http://localhost:4000/assets/penguin_nurse-8db6f0f87eeb2da9.js:5:33523
penguin_nurse-94196f07c5155f49.wasm.__wbg_new_8a6f238a6ece86ea externref shim@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[10852]:0x55fa71
penguin_nurse-94196f07c5155f49.wasm.console_error_panic_hook::hook::he6c8c10cb6e80f54@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[2265]:0x32c00c
penguin_nurse-94196f07c5155f49.wasm.core::ops::function::Fn::call::hec7e668007fb70a1@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[13274]:0x56a307
penguin_nurse-94196f07c5155f49.wasm.std::panicking::rust_panic_with_hook::h4501cceb7dbe383d@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[6826]:0x508230
penguin_nurse-94196f07c5155f49.wasm.std::panicking::begin_panic_handler::{{closure}}::hc2b9d3fc26dda7f9@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[7373]:0x51fc4d
penguin_nurse-94196f07c5155f49.wasm.std::sys::backtrace::__rust_end_short_backtrace::hf6a83a0a2155b9c0@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[13003]:0x569998
penguin_nurse-94196f07c5155f49.wasm.rust_begin_unwind@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[9717]:0x556f57
penguin_nurse-94196f07c5155f49.wasm.core::panicking::panic_fmt::h619600efce2da276@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[9718]:0x556f83
penguin_nurse-94196f07c5155f49.wasm.core::result::unwrap_failed::h4ec8ebc0cd29f54b@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[7760]:0x52dfdd
penguin_nurse-94196f07c5155f49.wasm.<dioxus_core::events::Callback<Args,Ret> as core::ops::deref::Deref>::deref::{{closure}}::hdc2b8c4f6110d22a@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[3937]:0x418a56
penguin_nurse-94196f07c5155f49.wasm.dioxus_core::events::Callback<Args,Ret>::new::{{closure}}::h38c0888225a06d61@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[1664]:0x2bb065
penguin_nurse-94196f07c5155f49.wasm.<dioxus_core::events::Callback<Args,Ret> as core::ops::deref::Deref>::deref::{{closure}}::hdc2b8c4f6110d22a@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[3937]:0x4189d2
penguin_nurse-94196f07c5155f49.wasm.dioxus_core::events::Callback<Args,Ret>::new::{{closure}}::hb75e100c7df89736@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[3749]:0x402378
penguin_nurse-94196f07c5155f49.wasm.<dioxus_core::events::Callback<Args,Ret> as core::ops::deref::Deref>::deref::{{closure}}::hdc2b8c4f6110d22a@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[3937]:0x4189d2
penguin_nurse-94196f07c5155f49.wasm.dioxus_core::events::Callback<Args,Ret>::new::{{closure}}::h4d23507d7bf02c92@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[545]:0x15519f
penguin_nurse-94196f07c5155f49.wasm.<dioxus_core::events::Callback<Args,Ret> as core::ops::deref::Deref>::deref::{{closure}}::hd3b3cfd2c9c2f48e@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[3938]:0x418ba8
penguin_nurse-94196f07c5155f49.wasm.dioxus_core::events::Callback<Args,Ret>::new::{{closure}}::h0b14fa0beab52dcb@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[4213]:0x438f50
penguin_nurse-94196f07c5155f49.wasm.<dioxus_core::events::Callback<Args,Ret> as core::ops::deref::Deref>::deref::{{closure}}::hf4cddd603f540406@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[4174]:0x43498b
penguin_nurse-94196f07c5155f49.wasm.dioxus_core::events::Callback<Args,Ret>::new::{{closure}}::h47ab9bf8ef2baccc@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[7955]:0x534030
penguin_nurse-94196f07c5155f49.wasm.dioxus_core::events::Callback<Args,Ret>::call::hab34808a9ce5ecb9@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[4712]:0x46adda
penguin_nurse-94196f07c5155f49.wasm.dioxus_core::events::Callback<Args,Ret>::leak::{{closure}}::h6cae314478a6981e@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[4269]:0x43ed82
penguin_nurse-94196f07c5155f49.wasm.dioxus_core::events::Callback<Args,Ret>::call::hd83ba4b4a453a336@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[3836]:0x40cd93
penguin_nurse-94196f07c5155f49.wasm.dioxus_core::runtime::Runtime::handle_event::h135e7d8b55c6093b@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[347]:0x98bda
penguin_nurse-94196f07c5155f49.wasm.dioxus_web::dom::WebsysDom::new::{{closure}}::h559083b6eac3ee05@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[529]:0x14c8dc
penguin_nurse-94196f07c5155f49.wasm.<dyn core::ops::function::Fn<(&A,)>+Output = R as wasm_bindgen::closure::WasmClosure>::describe::invoke::h671fd8195ad9fffc@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[9249]:0x550c56
penguin_nurse-94196f07c5155f49.wasm.closure4770 externref shim@http://localhost:4000/assets/penguin_nurse_bg-200878490f009121.wasm:wasm-function[9720]:0x556fcb
__wbg_adapter_62@http://localhost:4000/assets/penguin_nurse-8db6f0f87eeb2da9.js:5:1199
real@http://localhost:4000/assets/penguin_nurse-8db6f0f87eeb2da9.js:4:2770

If I reload the page and do the exact same thing it works. It only fails when I take the exact same sequence.

One theory I have had it that the callback is somehow borrowed and in use by the first ConsumableNested - does this make any sense?

I have tried cloning the object in different places, but without success.

Also if I uncomment the "x" callback and calling the "x" callback, that works fine also, so it isn't a problem with the parameters.

How do I resolve?

[brianmay]

If I change the first reference to use a closure:

show_ingredient: move |consumable| { show_nested_ingredient(consumable); },

Then it works fine. Somehow I smell a Dioxus bug.

[ealmloff]

Could the callback be invoked recursively in that code path? Closures cannot be called recursively because they are FnMut

[brianmay]

At one point the callback did nothing except call tracing::debug!("...");, so I don't think that is possible.

Also, like I said, when I changed the reference to the callback to go via a closure (instead of directly to the callback) - so the exact same functionality - it started working fine.