[Quality][Medium] Improve vault creation idempotency and reservations: bounded performance and operational visibility

[1nonlypiece]

Problem

The current vault creation idempotency and reservations implementation is a production-quality risk area: Concurrent first writes and retries must produce one durable vault result without orphaned rows or ambiguous ownership.

This issue requires meaningful implementation and focused tests. Typo-only, documentation-only, formatting-only, dependency-only, and cosmetic changes do not satisfy the scope.

Objective

bound rendering, polling, network, and memory costs while making degraded behavior observable for the implementation anchored at src/routes/vaults.ts; prisma; src/services.

Scope

• Establish the feature's explicit state, data, authorization, and failure invariants.
• Set explicit bounds for pagination, polling, chart points, upload sizes, and concurrent requests where applicable.
• Avoid redundant fetches and state updates during route changes, reconnects, or rapid user interaction.
• Expose actionable client telemetry or structured diagnostics for latency, failure, and recovery paths without leaking secrets.
• Keep the change focused on this feature and preserve unrelated public behavior.

Acceptance criteria

• The implementation defines and enforces the relevant invariants for normal and adversarial inputs.
• Set explicit bounds for pagination, polling, chart points, upload sizes, and concurrent requests where applicable.
• Avoid redundant fetches and state updates during route changes, reconnects, or rapid user interaction.
• Expose actionable client telemetry or structured diagnostics for latency, failure, and recovery paths without leaking secrets.
• Automated tests cover success, failure, boundary, retry, and permission behavior applicable to this feature.
• The PR includes validation commands, design tradeoffs, and any remaining limitations.
• The PR references this issue using Refs #<issue-number>.

Priority

Medium — determined by the potential impact on correctness, user funds or data, security, availability, and implementation depth.

Non-goals

• Do not make typo-only, documentation-only, formatting-only, dependency-only, or cosmetic changes.
• Do not remove tests merely to make CI pass.
• Do not introduce secrets, credentials, unsafe network defaults, or unrelated refactors.

Contributor application

Before starting, comment with relevant experience, a concise implementation approach, the main risks or tradeoffs, and an estimate for opening the first draft PR. Wait for maintainer assignment before coding.

Submission requirements

• Use PR title format: [#<issue-number>] <short summary>.
• Address every acceptance criterion in the PR description and implementation.
• Include focused automated tests and validation results.
• Explain any unavoidable limitations or pre-existing CI failures.
• Address maintainer review feedback before requesting final review.

Quality evaluation will consider scope adherence, implementation quality, test depth, security, correctness, review responsiveness, and follow-up stability.

[OkonkwoEmeka]

@OkonkwoEmeka has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

hi maintainer, please i'd love to work on this issue. i'm a professional typescript/nestjs backend developer, and i can complete the first pr within the timeframe.

i've been actively contributing across stellar wave projects, and i understand the core risk is concurrent vault creation and retries producing duplicate or orphaned records. i'll tighten the idempotency/reservation flow, enforce relevant request and concurrency bounds, add structured diagnostics, and cover success, retry, failure, permission, and boundary cases with focused tests.

looking forward to contributing!

ℹ️ Repo Maintainers: To accept this application, review their application or assign @OkonkwoEmeka to this issue.

[drips-wave]

Congratulations, @OkonkwoEmeka! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @OkonkwoEmeka: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊