fix(automod): improve validation for invalid actions (#1030)

This improves validation in `Guild.create_automod_rule` and
`AutoModRule.edit`, now raising a proper `TypeError` for invalid action
types in the most common error cases.

ref:
https://canary.discord.com/channels/808030843078836254/1093894067135463475

Author: shiftinv

changelog/1030.bugfix.rst

@@ -0,0 +1 @@
+Raise :exc:`TypeError` in :meth:`Guild.create_automod_rule` and :meth:`AutoModRule.edit` when an action has an invalid type, instead of a rather cryptic error.

disnake/automod.py

@@ -544,6 +544,9 @@ async def edit(
 
         All fields are optional.
 
+        .. versionchanged:: 2.9
+            Now raises a :exc:`TypeError` if given ``actions`` have an invalid type.
+
         Examples
         --------
         Edit name and enable rule:
@@ -598,6 +601,8 @@ async def edit(
         ------
         ValueError
             When editing the list of actions, at least one action must be provided.
+        TypeError
+            The specified ``actions`` are of an invalid type.
         Forbidden
             You do not have proper permissions to edit the rule.
         NotFound
@@ -619,8 +624,13 @@ async def edit(
         if trigger_metadata is not MISSING:
             payload["trigger_metadata"] = trigger_metadata.to_dict()
         if actions is not MISSING:
-            if len(actions) == 0:
+            if not actions:
                 raise ValueError("At least one action must be provided.")
+            for action in actions:
+                if not isinstance(action, AutoModAction):
+                    raise TypeError(
+                        f"actions must be of type `AutoModAction` (or subtype), not {type(action)!r}"
+                    )
             payload["actions"] = [a.to_dict() for a in actions]
         if enabled is not MISSING:
             payload["enabled"] = enabled

disnake/guild.py

@@ -26,7 +26,7 @@
 from . import abc, utils
 from .app_commands import GuildApplicationCommandPermissions
 from .asset import Asset
-from .automod import AutoModRule
+from .automod import AutoModAction, AutoModRule
 from .bans import BanEntry
 from .channel import (
     CategoryChannel,
@@ -90,7 +90,7 @@
     from .abc import Snowflake, SnowflakeTime
     from .app_commands import APIApplicationCommand
     from .asset import AssetBytes
-    from .automod import AutoModAction, AutoModTriggerMetadata
+    from .automod import AutoModTriggerMetadata
     from .permissions import Permissions
     from .state import ConnectionState
     from .template import Template
@@ -4565,6 +4565,9 @@ async def create_automod_rule(
 
         .. versionadded:: 2.6
 
+        .. versionchanged:: 2.9
+            Now raises a :exc:`TypeError` if given ``actions`` have an invalid type.
+
         Parameters
         ----------
         name: :class:`str`
@@ -4594,8 +4597,10 @@ async def create_automod_rule(
         Raises
         ------
         ValueError
-            The specified trigger type requires `trigger_metadata` to be set,
+            The specified trigger type requires ``trigger_metadata`` to be set,
             or no actions have been provided.
+        TypeError
+            The specified ``actions`` are of an invalid type.
         Forbidden
             You do not have proper permissions to create auto moderation rules.
         HTTPException
@@ -4614,8 +4619,13 @@ async def create_automod_rule(
         ):
             raise ValueError("Specified trigger type requires `trigger_metadata` to not be empty")
 
-        if len(actions) == 0:
+        if not actions:
             raise ValueError("At least one action must be provided.")
+        for action in actions:
+            if not isinstance(action, AutoModAction):
+                raise TypeError(
+                    f"actions must be of type `AutoModAction` (or subtype), not {type(action)!r}"
+                )
 
         data = await self._state.http.create_auto_moderation_rule(
             self.id,