refactor: rewrite http ratelimiting to be dynamic #947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftinv
added
s: needs review
Skelmis
reviewed
Mar 15, 2023
There was a problem hiding this comment.
Is there a possible race condition here given the original lock and then the one used in subsequent requests are going to be seperate Lock objects? Just given if there is a bucket from within the request it will generate a new lock object and use that for subsequent requests from what I can see
That could be a possibility, yeah. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR rewrites http ratelimiting to be more dynamic.
Closes #663.
I'm not sure whether to declare this PR as feature or breaking for the changelog entry, so please let me know which one it should be.
Checklist
task linttask pyright