[BE-122] VendorsService is missing delete()

[yusuftomilola]

Overview

VendorsService (backend/src/vendors/vendors.service.ts) has findAll, findById, create, and update, but no delete() — a vendor created by mistake, or one the org no longer works with, can never be removed.

Tasks

• Add delete(id), guarding against removing a vendor still referenced by an open PurchaseOrder.vendorId (purchase_orders currently has no DB-level foreign key on this column — see [BE-134]).
• Wire DELETE /vendors/:id into VendorsController.
• Add a unit test covering both the happy path and the referenced-vendor rejection.

Acceptance Criteria

• DELETE /vendors/:id removes a vendor with no open purchase orders.
• Deleting a vendor referenced by an open PO is rejected.

Notes for Contributors

Comment below to be assigned.

[odiliflash-ops]

I would love to work on this issue

[Halo-chains]

@Halo-chains has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi Maintainer, I’ve gone through the issue and acceptance criteria in detail. I’m confident I can deliver a clean implementation that meets the project’s expectations.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Halo-chains to this issue.

[BIGSMKE12]

@BIGSMKE12 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello, I’ve assessed the issue and have a clear understanding of the work involved. I’m ready to take ownership and deliver the required changes.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @BIGSMKE12 to this issue.

[bitkongdigital]

@bitkongdigital has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello, I’ve gone through the requirements thoroughly and understand what the task involves. I believe I can deliver a reliable implementation that meets the specified acceptance criteria.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @bitkongdigital to this issue.

[devzakari-sketch]

@devzakari-sketch has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi maintainer can i work on this task?

ℹ️ Repo Maintainers: To accept this application, review their application or assign @devzakari-sketch to this issue.

[drips-wave]

Congratulations, @devzakari-sketch! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @devzakari-sketch: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[grantfox-oss]

🎉 This issue has been marked as completed on GrantFox!

@devzakari-sketch's PR #1368 was approved and merged by @yusuftomilola.

🏆 @devzakari-sketch: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (35 total points). Track your full progress on GrantFox.

👏 Great work, @devzakari-sketch! Keep contributing to DistinctCodes.

[drips-wave]

This issue has been completed by @devzakari-sketch as part of the Stellar Wave Program's 8th Wave 🥳

😎 @devzakari-sketch: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.