Skip to content

[SC-77] deploy.sh needs verifying against contrib's real deployable surface once dead code is resolved #1348

Description

@yusuftomilola

Overview

contracts/scripts/deploy.sh (227 lines) presumably deploys/initializes all five workspace crates — once [SC-57] either wires up or deletes contrib's seven uncompiled files, the crate's actual deployable ABI changes, and deploy.sh (plus contracts/deployments/testnet.example.json, which lists a single contrib contract id with no indication of which entrypoints that id is expected to expose) should be checked against the new reality.

Tasks

  • After [SC-57] lands, re-run deploy.sh against a local/testnet target and confirm it still deploys and initializes contrib correctly with its finalized entrypoint set.
  • Update any comments/docs in deploy.sh that reference contrib capabilities affected by the change.

Acceptance Criteria

  • deploy.sh deploys contrib's post-cleanup ABI correctly, verified against a real (or sandboxed) deployment.

Dependencies

Depends on [SC-57].

Notes for Contributors

Requires Rust + Soroban. Workspace: contracts/ (soroban-sdk 23, members: assetsup, contrib, multisig-wallet, multisig-transfer, asset-maintenance). Run cargo test --all, cargo fmt --all -- --check, and cargo clippy --all-targets --all-features -- -D warnings before opening a PR — CI enforces all three. Comment below to be assigned.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    contractdevopsCI/CD, infrastructure, and deployment

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions