SOV-5202: Hide LM rewards (#1112)

* Hide LM rewards

* Create lazy-coats-design.md

* Use one week average for calculating return rate

Author: tiltom

.changeset/lazy-coats-design.md

@@ -0,0 +1,5 @@
+---
+"frontend": patch
+---
+
+SOV-5202: Hide LM rewards

apps/frontend/src/app/5_pages/LandingPage/components/QuickLaunch/QuickLaunch.tsx

@@ -40,8 +40,8 @@ export const QuickLaunch: FC = () => {
   const maxRate = useMemo(() => {
     let maxRewards = '0';
     rates.forEach(rate => {
-      if (Number(rate.afterRewards) > Number(maxRewards)) {
-        maxRewards = rate.afterRewards;
+      if (Number(rate.beforeRewards) > Number(maxRewards)) {
+        maxRewards = rate.beforeRewards;
       }
     });
 

apps/frontend/src/app/5_pages/MarketMakingPage/components/MarketMaking/MarketMaking.tsx

@@ -18,7 +18,6 @@ import { RSK_STORAGE_KEY } from '../../../../2_molecules/MarketMakingNetworkBann
 import { useIsMobile } from '../../../../../hooks/useIsMobile';
 import { translations } from '../../../../../locales/i18n';
 import { PoolsTable } from '../PoolsTable/PoolsTable';
-import { Promotions } from '../Promotions/Promotions';
 
 export const MarketMaking: FC = () => {
   const { isMobile } = useIsMobile();
@@ -61,11 +60,6 @@ export const MarketMaking: FC = () => {
             {t(translations.marketMakingPage.subtitle)}
           </Paragraph>
 
-          <Promotions
-            setActivePool={setActivePool}
-            onClick={setIsPromoCardClicked}
-          />
-
           <div className="w-full my-4">
             <Input
               value={searchInputValue}

apps/frontend/src/app/5_pages/MarketMakingPage/components/PoolDetails/components/PoolChart/hooks/useGetPoolVolumeData.ts

@@ -29,7 +29,7 @@ export const useGetPoolVolumeData = (pool: AmmLiquidityPool) => {
         pool.poolTokenA.toLowerCase()
       ].map(item => ({
         timestamp: dayjs(item.activity_date).format('YYYY-MM-DD'),
-        apy: Number(item.APY_pc),
+        apy: Number(item.APY_fees_pc),
         btcVolume: String(item.btc_volume),
       }));
 

apps/frontend/src/app/5_pages/MarketMakingPage/components/PoolsTable/components/PoolsTableReturns/PoolsTableReturns.tsx

@@ -1,10 +1,7 @@
 import React, { FC, useMemo } from 'react';
 
-import { t } from 'i18next';
+import classNames from 'classnames';
 
-import { ContextLink } from '@sovryn/ui';
-
-import { translations } from '../../../../../../../locales/i18n';
 import { useGetReturnRate } from '../../../../hooks/useGetReturnRate';
 import { AmmLiquidityPool } from '../../../../utils/AmmLiquidityPool';
 import styles from './PoolsTableReturns.module.css';
@@ -20,52 +17,13 @@ export const PoolsTableReturns: FC<PoolsTableReturnsProps> = ({
 }) => {
   const { returnRates } = useGetReturnRate(pool);
 
-  const hasRewards = useMemo(
-    () => Number(returnRates.afterRewards) > 0,
-    [returnRates],
-  );
-
-  const renderTooltipChildren = useMemo(
-    () => (
-      <div className="flex flex-col">
-        <div>
-          {t(translations.marketMakingPage.poolsTableReturns.before, {
-            percent: returnRates.beforeRewards,
-          })}
-        </div>
-        <div>
-          {t(translations.marketMakingPage.poolsTableReturns.after, {
-            percent: returnRates.afterRewards,
-          })}
-        </div>
-      </div>
-    ),
-    [returnRates],
-  );
-
-  const renderChildren = useMemo(
+  const returnRate = useMemo(
     () =>
-      hasRewards
-        ? t(translations.marketMakingPage.poolsTableReturns.title, {
-            percent: returnRates.afterRewards,
-          })
-        : '0%',
-    [returnRates, hasRewards],
+      returnRates.beforeRewards === '0.00' ? '0' : returnRates.beforeRewards,
+    [returnRates],
   );
 
-  const renderComponent = useMemo(
-    () =>
-      hasRewards ? (
-        <ContextLink
-          className={className}
-          children={renderChildren}
-          tooltipContent={renderTooltipChildren}
-        />
-      ) : (
-        <div className={styles.rewards}>{renderChildren}</div>
-      ),
-    [className, hasRewards, renderChildren, renderTooltipChildren],
+  return (
+    <div className={classNames(styles.rewards, className)}>{returnRate}%</div>
   );
-
-  return renderComponent;
 };

apps/frontend/src/app/5_pages/MarketMakingPage/hooks/useGetReturnRate.ts

@@ -49,18 +49,26 @@ export const useGetReturnRate = ({
               ? data[converter].data[Object.keys(data[converter].data)[0]]
               : data[converter].data[poolTokenA];
 
-          const lastEntry = poolData[poolData.length - 1];
+          if (poolData && poolData.length > 0) {
+            const sumFeesApy = poolData.reduce(
+              (acc, entry) => acc + parseFloat(entry.APY_fees_pc),
+              0,
+            );
+            const sumTotalApy = poolData.reduce(
+              (acc, entry) => acc + parseFloat(entry.APY_pc),
+              0,
+            );
 
-          const totalAPY = {
-            beforeRewards: lastEntry
-              ? parseFloat(lastEntry.APY_rewards_pc).toFixed(2)
-              : '0',
-            afterRewards: lastEntry
-              ? parseFloat(lastEntry.APY_pc).toFixed(2)
-              : '0',
-          };
+            const avgFeesApy = (sumFeesApy / poolData.length).toFixed(2);
+            const avgTotalApy = (sumTotalApy / poolData.length).toFixed(2);
 
-          setReturnRates(totalAPY);
+            setReturnRates({
+              beforeRewards: avgFeesApy,
+              afterRewards: avgTotalApy,
+            });
+          } else {
+            setReturnRates({ beforeRewards: '0', afterRewards: '0' });
+          }
         } else {
           setReturnRates({ beforeRewards: '0', afterRewards: '0' });
         }

apps/frontend/src/locales/en/translations.json

@@ -510,7 +510,7 @@
             },
             "earn": {
                 "title": "Earn up to {{amount}}% APR in AMM",
-                "description": "Deposit in the AMM pools, earn from trades and get SOV rewards.",
+                "description": "Deposit in the AMM pools and earn from trades.",
                 "action": "Deposit in AMM"
             },
             "lend": {
@@ -1211,7 +1211,7 @@
         },
         "yieldFarmingBanner": {
             "title": "Yield farming",
-            "description": "Deposit in the AMM pools, earn from trades in Sovryn and get rewards",
+            "description": "Deposit in the AMM pools and earn from trades in Sovryn",
             "action": "Deposit in AMM"
         },
         "staking": {
@@ -2109,4 +2109,4 @@
             "invalidNumberFormat": "Invalid number format."
         }
     }
-}
+}