Clear user suggestion criteria cache for no projects

Author: cpeel

pinc/UserSuggestions.inc

@@ -53,6 +53,14 @@ class UserSuggestions
         }
     }
 
+    public function clear_cache(): void
+    {
+        // only clear the cache for the user looking at their own suggestions
+        if ($this->_username == User::current_username()) {
+            unset($_SESSION[$this->_cache_key]);
+        }
+    }
+
     private function _calculate_normalized_weights(array $criteria): array
     {
         $new_criteria = [];

tools/proofers/my_suggestions.php

@@ -79,6 +79,10 @@
 }
 if (count($projects) == 0) {
     echo "<p>" . $round_view_options[$round_view]["text_none"] . "</p>";
+
+    // clear the suggestions cache so if they get access to rounds and come
+    // back to the page, we re-evaluate their suggestions
+    $user_suggestions->clear_cache();
 } else {
     if ($explain_why) {
         // we don't html_safe() as they can contain HTML