Remove duplicate notifications

Author: DjangoCRM

common/utils/helpers.py

@@ -11,6 +11,7 @@
 from django.db.models import Q
 from django.db.models.query import QuerySet
 from django.template.defaultfilters import truncatechars
+from django.utils.translation import gettext_lazy as _
 from django.utils.formats import date_format
 from django.utils.safestring import mark_safe
 from django.utils.safestring import SafeString
@@ -27,10 +28,15 @@
 CONTENT_COPY_LINK = '<a href="{}" title="{}">{}</a>'
 CRM_NOTICE = '<i class ="material-icons" style="color: var(--body-quiet-color);\
     font-size: 17px;vertical-align: middle;">message</i>:'
+FRIDAY_SATURDAY_SUNDAY_MSG = _("Attention! Mass mailings are not carried out on: Fridays, Saturdays and Sundays.")
 LEADERS = '- - - - -'
 OBJ_DOESNT_EXIT_STR = gettext_lazy("{} with ID '{}' doesn’t exist. "
                                    "Perhaps it was deleted?")
 ONCLICK_STR = "window.open('{}', '{}','width=800,height=700'); return false;"
+USE_HTML = _("""
+Use HTML. To specify the address of the embedded image, use {% cid_media ‘path/to/pic.png' %}.<br>
+You can embed files uploaded to the CRM server in the ‘media/pics/’ folder.
+""")
 USER_MODEL = get_user_model()
 
 

crm/site/crmmodeladmin.py

@@ -19,8 +19,10 @@
 from django.utils.translation import gettext_lazy as _
 from django.urls import reverse
 
-from common.models import Department, TheFile
+from common.models import Department
+from common.models import TheFile
 from common.site.basemodeladmin import BaseModelAdmin
+from common.utils.helpers import FRIDAY_SATURDAY_SUNDAY_MSG
 from common.utils.helpers import get_active_users
 from common.utils.helpers import get_department_id
 from common.utils.helpers import get_manager_departments
@@ -336,10 +338,7 @@ def make_massmail(self, request):
                         department_id=request.user.department_id
                     )
                     mailing_out.save()
-                    messages.info(
-                        request,
-                        _("""Note massmail is not performed on the following days: 
-                        Friday, Saturday, Sunday.""")
+                    messages.info(request, _(FRIDAY_SATURDAY_SUNDAY_MSG)
                     )
                     return HttpResponseRedirect(reverse(
                         'site:massmail_mailingout_change',

massmail/admin_actions.py

@@ -10,6 +10,7 @@
 from django.urls import reverse
 from django.utils.translation import gettext_lazy as _
 
+from common.utils.helpers import FRIDAY_SATURDAY_SUNDAY_MSG
 from massmail.models import EmailAccount
 from massmail.models import MailingOut
 from massmail.models import MassContact
@@ -49,11 +50,7 @@ def make_mailing_out(modeladmin, request, queryset):
         recipient_ids=",".join([str(obj.id) for obj in queryset]),
         recipients_number=queryset.count()
     )
-    messages.info(
-        request,
-        _("Note massmail is not performed on the following days:"
-          " Friday, Saturday, Sunday.")
-    )
+    messages.info(request, _(FRIDAY_SATURDAY_SUNDAY_MSG))
     return HttpResponseRedirect(
         reverse(
             'site:massmail_mailingout_change',

massmail/models/email_message.py

@@ -4,14 +4,10 @@
 from django.contrib.contenttypes.fields import GenericRelation
 from django.urls import reverse
 
+from common.utils.helpers import USE_HTML
 from massmail.models.baseeml import BaseEml
 
-content_help_text = mark_safe(_(
-    """
-    Use HTML. To specify the address of the embedded image, use {% cid_media ‘path/to/pic.png' %}.<br>
-    You can embed files uploaded to the CRM server in the ‘media/pics/’ folder or attached to this message.
-    """
-))
+content_help_text = mark_safe(_(USE_HTML))
 
 
 class EmlMessage(BaseEml):

massmail/models/signature.py

@@ -1,14 +1,11 @@
 from django.db import models
 from django.utils.safestring import mark_safe
 from django.utils.translation import gettext_lazy as _
+
 from common.models import Base1
+from common.utils.helpers import USE_HTML
 
-content_help_text = mark_safe(_(
-    """
-    Use HTML. To specify the address of the embedded image, use {% cid_media ‘path/to/pic.png' %}.<br>
-    You can embed files uploaded to the CRM server in the ‘media/pics/’ folder.
-    """
-))
+content_help_text = mark_safe(_(USE_HTML))
 
 
 class Signature(Base1):

massmail/site/mailingoutadmin.py

@@ -7,6 +7,7 @@
 from django.utils.translation import gettext_lazy as _
 from django.utils.safestring import mark_safe
 
+from common.utils.helpers import FRIDAY_SATURDAY_SUNDAY_MSG
 from common.utils.helpers import get_today
 from crm.site.crmmodeladmin import CrmModelAdmin
 from crm.utils.admfilters import ByOwnerFilter
@@ -67,11 +68,7 @@ def changelist_view(self, request, extra_context=None):
         now = timezone.localtime(timezone.now())
         weekday = now.weekday()
         if weekday in (4, 5, 6):
-            messages.warning(
-                request,
-                gettext("""Note massmail is not performed on the following days: 
-                Friday, Saturday, Sunday.""")
-            )
+            messages.warning(request, gettext(FRIDAY_SATURDAY_SUNDAY_MSG))
         return super().changelist_view(request, extra_context)
 
     def save_model(self, request, obj, form, change):