fix: correct format verbs in diagnostic messages (aquasecurity#10805)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: eran132

pkg/sbom/spdx/marshal.go

@@ -523,7 +523,7 @@ func (m *Marshaler) spdxChecksums(digests []digest.Digest) []common.Checksum {
 		case digest.MD5:
 			alg = spdx.MD5
 		default:
-			m.logger.Warn("Unsupported hash algorithm", log.String("algorithm", string(alg)))
+			m.logger.Warn("Unsupported hash algorithm", log.String("algorithm", d.Algorithm().String()))
 			continue
 		}
 		checksums = append(checksums, spdx.Checksum{

pkg/vex/sbomref.go

@@ -84,7 +84,7 @@ func retrieveExternalVEXDocument(ctx context.Context, vexUrl *url.URL, report *t
 	defer res.Body.Close()
 
 	if res.StatusCode != http.StatusOK {
-		return nil, xerrors.Errorf("did not receive 2xx status code: %w", res.StatusCode)
+		return nil, xerrors.Errorf("unexpected status code %d from %s", res.StatusCode, vexUrl.Redacted())
 	}
 
 	val, err := io.ReadAll(res.Body)

pkg/vex/sbomref_test.go

@@ -82,37 +82,35 @@ func TestRetrieveExternalVEXDocuments(t *testing.T) {
 		name      string
 		input     *types.Report
 		wantVEXes int
-		wantErr   bool
+		wantErr   string
 	}{
 		{
 			name:      "external vex retrieval",
 			input:     setupTestReport(s, vexExternalRef),
 			wantVEXes: 1,
-			wantErr:   false,
 		},
 		{
 			name:    "incompatible external vex",
 			input:   setupTestReport(s, vexUnknown),
-			wantErr: true,
+			wantErr: "unable to load VEX from external reference",
 		},
 		{
 			name:    "vex not found",
 			input:   setupTestReport(s, vexNotFound),
-			wantErr: true,
+			wantErr: "unexpected status code 404",
 		},
 		{
 			name:      "no external reference",
 			input:     setupEmptyTestReport(),
 			wantVEXes: 0,
-			wantErr:   false,
 		},
 	}
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			got, err := vex.NewSBOMReferenceSet(tt.input)
-			if tt.wantErr {
-				require.Error(t, err)
+			if tt.wantErr != "" {
+				require.ErrorContains(t, err, tt.wantErr)
 				return
 			}
 			require.NoError(t, err)