Merge pull request #56 from DoclerLabs/fix-virtual-package-dependency

replace virtual pkg with suggest

Author: vsouz4

CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [7.2.0] - 2021-09-24
+### Removed
+- Remove virtual package dependency (psr/http-client-implementation)
+
 ## [7.1.1] - 2021-09-09
 ### Fixed
 - Changed default php-cs-fixer configuration to add blank line after opening tag, according to PSR12

README.md

@@ -9,7 +9,6 @@ API client generator is a console application capable of auto-generating a [PSR1
 ## Requirements
 - OpenAPI >= 3.0
 - PHP >= 7.0
-- [PSR-18 base client](https://packagist.org/providers/psr/http-client-implementation)
 
 ## Why using it?
 - With generated client you are always sure that your OpenAPI specification is up-to-date.
@@ -29,7 +28,7 @@ API client generator is a console application capable of auto-generating a [PSR1
     * application/x-www-form-urlencoded
     * application/xml
 - Supports new PHP versions synthax features.
-- It is base client independent, you are free to choose any [existing PSR-18 compliant client](https://packagist.org/providers/psr/http-client-implementation). Just choose the one which you already use, so generated client would not cause conflicts in your dependencies.
+- It is base client independent, you are free to choose any [existing PSR-18 compliant client](https://packagist.org/providers/psr/http-client-implementation). Just choose the one which you already use, so generated client would not cause any conflicts with your dependencies. Although not recommended, you can also use or build your own PSR-18 implementation, as the generated client depends on PSR interfaces only.
 - Applies code style rules to generated code, you can specify your own.
 - Generates README and composer.json files with possibility to use your own template.
 - Supports `allOf` OpenAPI parameter.

example/composer.lock

@@ -15,12 +15,15 @@
         "guzzlehttp/psr7": "^1.6",
         "pimple/pimple": "^3.3",
         "psr/container": "^1.0",
-        "psr/http-client": "^1.0",
-        "psr/http-client-implementation": "^1.0"
+        "psr/http-client": "^1.0"
     },
     "autoload": {
         "psr-4": {
             "OpenApi\\PetStoreClient\\": "src/"
         }
+    },
+    "suggest": {
+        "guzzlehttp/guzzle": "PSR-18 provided by Guzzle 7",
+        "php-http/guzzle6-adapter": "PSR-18 wrapper for Guzzle 6"
     }
-}
+}

example/gen/composer.json

@@ -66,7 +66,6 @@ private function getCommonPackages(): array
             'ext-intl'                         => '*',
             'psr/container'                    => '^1.0',
             'psr/http-client'                  => '^1.0',
-            'psr/http-client-implementation'   => '^1.0',
         ];
     }
 }

src/Meta/ComposerJsonTemplate.php

@@ -21,5 +21,9 @@
         "psr-4": {
             "{{ addslashes(namespace) }}\\": "src/"
         }
+    },
+    "suggest": {
+        "guzzlehttp/guzzle": "PSR-18 provided by Guzzle 7",
+        "php-http/guzzle6-adapter": "PSR-18 wrapper for Guzzle 6"
     }
-}
+}

template/composer.json.twig

@@ -14,12 +14,15 @@
         "guzzlehttp/psr7": "^1.6",
         "pimple/pimple": "^3.3",
         "psr/container": "^1.0",
-        "psr/http-client": "^1.0",
-        "psr/http-client-implementation": "^1.0"
+        "psr/http-client": "^1.0"
     },
     "autoload": {
         "psr-4": {
             "Test\\": "src/"
         }
+    },
+    "suggest": {
+        "guzzlehttp/guzzle": "PSR-18 provided by Guzzle 7",
+        "php-http/guzzle6-adapter": "PSR-18 wrapper for Guzzle 6"
     }
-}
+}

test/suite/functional/Meta/ComposerJson/composer_default.json

@@ -14,12 +14,15 @@
         "guzzlehttp/psr7": "^1.6",
         "pimple/pimple": "^3.3",
         "psr/container": "^1.0",
-        "psr/http-client": "^1.0",
-        "psr/http-client-implementation": "^1.0"
+        "psr/http-client": "^1.0"
     },
     "autoload": {
         "psr-4": {
             "Test\\": "src/"
         }
+    },
+    "suggest": {
+        "guzzlehttp/guzzle": "PSR-18 provided by Guzzle 7",
+        "php-http/guzzle6-adapter": "PSR-18 wrapper for Guzzle 6"
     }
-}
+}

test/suite/functional/Meta/ComposerJson/composer_guzzle_message.json

@@ -14,12 +14,15 @@
         "nyholm/psr7": "^1.3",
         "pimple/pimple": "^3.3",
         "psr/container": "^1.0",
-        "psr/http-client": "^1.0",
-        "psr/http-client-implementation": "^1.0"
+        "psr/http-client": "^1.0"
     },
     "autoload": {
         "psr-4": {
             "Test\\": "src/"
         }
+    },
+    "suggest": {
+        "guzzlehttp/guzzle": "PSR-18 provided by Guzzle 7",
+        "php-http/guzzle6-adapter": "PSR-18 wrapper for Guzzle 6"
     }
-}
+}