moving guzzle6 warning to readme

Author: vsouz4

src/Generator/ClientFactoryGenerator.php

@@ -13,12 +13,6 @@
 
 class ClientFactoryGenerator extends GeneratorAbstract
 {
-    private const PSR18_EXCEPTION_WARNING = [
-        'If using Guzzle 6, make sure to configure Guzzle to not throw exceptions',
-        'on HTTP error status codes, or this client will violate PSR-18.',
-        'e.g. new Client([\'base_uri\' => $baseUri, \'http_errors\' => false, ...])',
-    ];
-
     private ContainerImplementationStrategy $containerImplementation;
 
     public function __construct(
@@ -83,7 +77,7 @@ protected function generateCreate(Specification $specification): ClassMethod
             ->addParams($params)
             ->addStmts($statements)
             ->setReturnType($clientClassName)
-            ->composeDocBlock($params, $clientClassName, [], self::PSR18_EXCEPTION_WARNING)
+            ->composeDocBlock($params, $clientClassName, [])
             ->getNode();
     }
 }

template/README.md.twig

@@ -16,7 +16,6 @@ dhlabs/api-client-generator
 ```
 
 ## Usage
-{% set serverUrl = specification.serverUrls() is not empty ? specification.serverUrls()|first : '<server-base-url>' %}
 {% set requestClass = static('\\DoclerLabs\\ApiClientGenerator\\Naming\\RequestNaming', 'getClassName', exampleOperation) %}
 
 ```php
@@ -25,8 +24,15 @@ dhlabs/api-client-generator
 use {{ namespace }}\{{ static('\\DoclerLabs\\ApiClientGenerator\\Naming\\ClientNaming', 'getFactoryClassName', specification) }};
 use {{ namespace }}\Request\{{ requestClass }};
 
+/**
+ * If using Guzzle 6, make sure to configure Guzzle to not throw exceptions
+ * on HTTP error status codes, or this client will violate PSR-18.
+ * e.g. new Client(['base_uri' => $baseUri, 'http_errors' => false, ...])
+ */
+$client = ...; // any PSR-18 HTTP CLIENT
+
 $factory = new {{ static('\\DoclerLabs\\ApiClientGenerator\\Naming\\ClientNaming', 'getFactoryClassName', specification) }}();
-$client  = $factory->create('{{ serverUrl }}', ['timeout' => 2]);
+$client  = $factory->create($client);
 
 $request = new {{ requestClass }}();
 $result  = $client->{{ exampleOperation.getName() }}($request);

test/suite/functional/Generator/ClientFactory/ClientFactoryDefault.php

@@ -16,10 +16,6 @@
 class SwaggerPetstoreClientFactory
 {
     /**
-     * If using Guzzle 6, make sure to configure Guzzle to not throw exceptions
-     * on HTTP error status codes, or this client will violate PSR-18.
-     * e.g. new Client(['base_uri' => $baseUri, 'http_errors' => false, ...])
-     *
      * @param ClientInterface $client
      *
      * @return SwaggerPetstoreClient

test/suite/functional/Generator/ClientFactory/ClientFactoryNyholmMessage.php

@@ -16,10 +16,6 @@
 class SwaggerPetstoreClientFactory
 {
     /**
-     * If using Guzzle 6, make sure to configure Guzzle to not throw exceptions
-     * on HTTP error status codes, or this client will violate PSR-18.
-     * e.g. new Client(['base_uri' => $baseUri, 'http_errors' => false, ...])
-     *
      * @param ClientInterface $client
      *
      * @return SwaggerPetstoreClient

test/suite/functional/Meta/ReadmeMd/README.md

@@ -23,8 +23,15 @@ dhlabs/api-client-generator
 use Test\SwaggerPetstoreClientFactory;
 use Test\Request\FindPetsRequest;
 
+/**
+ * If using Guzzle 6, make sure to configure Guzzle to not throw exceptions
+ * on HTTP error status codes, or this client will violate PSR-18.
+ * e.g. new Client(['base_uri' => $baseUri, 'http_errors' => false, ...])
+ */
+$client = ...; // any PSR-18 HTTP CLIENT
+
 $factory = new SwaggerPetstoreClientFactory();
-$client  = $factory->create('http://petstore.swagger.io/api', ['timeout' => 2]);
+$client  = $factory->create($client);
 
 $request = new FindPetsRequest();
 $result  = $client->findPets($request);