Skip to content

Change Date Format #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Change Date Format #104

wants to merge 1 commit into from

Conversation

Sabreen-Parveen
Copy link

Closes #10

The date format has been changed to mm/yyyy from the default format dd/mm/yyy

dhairyaj
dhairyaj reviewed Dec 18, 2020
View reviewed changes
Copy link
Member

@dhairyaj dhairyaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is fine. But doesnot work on all browsers. Please use normal text and use Javascript to validate the correct and required format.

@dhairyaj dhairyaj self-requested a review December 18, 2020 08:38
dhairyaj
dhairyaj requested changes Dec 18, 2020
View reviewed changes
Copy link
Member

@dhairyaj dhairyaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Javascript or some custom date pickers which are supported by all browsers.

@frankhart2018
Copy link
Member

Stale PR, closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhairyaj dhairyaj dhairyaj requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]Change date format
3 participants
@Sabreen-Parveen @frankhart2018 @dhairyaj