Fixed select trigger bug

acburst · acburst · commit d1c369cdc670 · 2018-06-17T15:08:59.000-07:00
diff --git a/js/select.js b/js/select.js
@@ -135,8 +135,9 @@
         }
 
         // Set selected on original select option
-        // Check if clicking on already selected option
-        if (!$(this._valueDict[key].el).prop('selected')) {
+        // Only trigger if selected state changed
+        let prevSelected = $(this._valueDict[key].el).prop('selected');
+        if (prevSelected !== selected) {
           $(this._valueDict[key].el).prop('selected', selected);
           this.$el.trigger('change');
         }

Original file line number	Diff line number	Diff line change
`@@ -135,8 +135,9 @@`
`135`	`135`	`}`
`136`	`136`
`137`	`137`	`// Set selected on original select option`
`138`		`- // Check if clicking on already selected option`
`139`		`- if (!$(this._valueDict[key].el).prop('selected')) {`
	`138`	`+ // Only trigger if selected state changed`
	`139`	`+ let prevSelected = $(this._valueDict[key].el).prop('selected');`
	`140`	`+ if (prevSelected !== selected) {`
`140`	`141`	`$(this._valueDict[key].el).prop('selected', selected);`
`141`	`142`	`this.$el.trigger('change');`
`142`	`143`	`}`