open dashboard links in new tab (#39)

Author: DolceTriade

blade/components/dashboard/duration_chart.rs

@@ -1,8 +1,11 @@
 use leptos::prelude::*;
-use leptos_dom::helpers::window;
 use state::TestHistory;
 
-use crate::{charts::linechart::LineChart, summaryheader::format_time};
+use crate::{
+    charts::linechart::LineChart,
+    navigation::open_in_new_tab,
+    summaryheader::format_time,
+};
 
 pub fn format_unix(t: f64) -> String {
     let d = std::time::Duration::from_secs_f64(t);
@@ -17,7 +20,7 @@ pub fn format_unix(t: f64) -> String {
 pub fn DurationChart(history: TestHistory) -> impl IntoView {
     let on_point_click = |point: state::TestHistoryPoint| {
         let link = format!("/invocation/{}", point.invocation_id);
-        window().open_with_url_and_target(&link, "_blank").unwrap();
+        open_in_new_tab(&link);
     };
 
     // Sort data so that successful tests are rendered first and failed tests last

blade/components/dashboard/pass_fail_scatterplot.rs

@@ -1,15 +1,18 @@
 use leptos::prelude::*;
-use leptos_dom::helpers::window;
 use state::{Status, TestHistory};
 
-use crate::{charts::scatterplot::ScatterPlot, summaryheader::format_time};
+use crate::{
+    charts::scatterplot::ScatterPlot,
+    navigation::open_in_new_tab,
+    summaryheader::format_time,
+};
 
 #[allow(non_snake_case)]
 #[component]
 pub fn PassFailScatterPlot(history: TestHistory) -> impl IntoView {
     let on_point_click = |point: state::TestHistoryPoint| {
         let link = format!("/invocation/{}", point.invocation_id);
-        window().location().set_href(&link).unwrap();
+        open_in_new_tab(&link);
     };
 
     view! {

blade/components/dashboard/test_history_table.rs

@@ -1,8 +1,7 @@
 use leptos::prelude::*;
-use leptos_router::hooks::use_navigate;
 use state::{Status, TestHistory};
 
-use crate::summaryheader::format_time;
+use crate::{navigation::open_in_new_tab, summaryheader::format_time};
 
 #[derive(Debug, Clone)]
 struct RuntimeStats {
@@ -140,9 +139,8 @@ pub fn TestHistoryTable(history: TestHistory) -> impl IntoView {
                                     <tr
                                         class="border-b border-gray-200 dark:border-gray-600 hover:bg-gray-100 dark:hover:bg-gray-600 cursor-pointer"
                                         on:click=move |_| {
-                                            let navigate = use_navigate();
                                             let url = format!("/invocation/{}", &point.invocation_id);
-                                            navigate(&url, Default::default());
+                                            open_in_new_tab(&url);
                                         }
                                     >
                                         <td class="py-3 px-6 text-left whitespace-nowrap">

blade/components/lib.rs

@@ -6,6 +6,7 @@ pub mod dashboard;
 pub mod list;
 pub mod measuretime;
 pub mod nav;
+pub mod navigation;
 pub mod searchbar;
 pub mod shellout;
 pub mod statusicon;

blade/components/navigation.rs

@@ -0,0 +1,4 @@
+use leptos_dom::helpers::window;
+
+/// Opens a URL in a new browser tab
+pub fn open_in_new_tab(url: &str) { let _ = window().open_with_url_and_target(url, "_blank"); }