Gross price not calculated in supplier orders

[mannybiker]

Bug

The gross price (price + VAT) is not calculated in supplier orders lines when the subprice_ttc field in the DB (table llx_commande_fournisseurdet) is at 0.

I don't know if this is a normal behavior but all my subprice_ttc values in my supplier's orders are at 0 in the DB.
This means that when in the class commonobject.class.php at line 5563 it tests if $line->subprice_ttc is empty it returns false (it is a string "0,0000" not empty) and do not recalculate the price.

I had to actually change this in order to fix the problem from this
if (empty($line->subprice_ttc) && $line->qty) {
to this
if ((empty($line->subprice_ttc) or $line->subprice_ttc == 0) && $line->qty) {

but I'am not sure this will not impact something elsewhere.

The problem was not present in version 22.0.0. Probably due to the deprecation of the use of $pu_ttc that has been substituted by $subprice_ttc.

Dolibarr Version

23.0.1

Environment PHP

8.0.30

Environment Database

No response

Steps to reproduce the behavior and expected behavior

• Verify that in the table llx_commande_fournisseurdet the field subprice_ttc is at 0
• Set the global variable MAIN_NO_INPUT_PRICE_WITH_TAX to 0 in order to shop TTC prices in the supplier's order page

Attached files

No response

[faveurs9]

Same issue

[sribalajitvm]

Same issue
It was working fine in V22

[vanyolai]

After some investigation, I found out that the problem might be at the
$tmpcal = calcul_price_total($obj->qty, $obj->up, $obj->remise_percent, $obj->vatrate, $obj->localtax1_tx, $obj->localtax2_tx, 0, $base_price_type, $obj->info_bits, $obj->product_type, $seller, $localtax_array, (isset($obj->situation_percent) ? $obj->situation_percent : 100), $multicurrency_tx);
function call in htdocs/core/class/commonobject.class.php because the $pu_devise parameter is missing, so it will be 0. Fixing this will inpact more objects, too, I guess.