readers

Author: DomCR

samples/in/glb-gltf/sample_basic_box.bin samples/in/gltf/sample_basic_box.binsamples/in/glb-gltf/sample_basic_box.bin renamed to samples/in/gltf/sample_basic_box.bin

@@ -42,15 +42,15 @@ public Box(string name) : base(name) { }
 		/// <summary>
 		/// Initializes a new instance of the Box class with the specified dimensions and center point.
 		/// </summary>
-		/// <param name="xDimension">The length of the box along the X-axis. Must be a positive value.</param>
-		/// <param name="yDimension">The length of the box along the Y-axis. Must be a positive value.</param>
-		/// <param name="zDimension">The length of the box along the Z-axis. Must be a positive value.</param>
+		/// <param name="lengthX">The length of the box along the X-axis. Must be a positive value.</param>
+		/// <param name="lengthY">The length of the box along the Y-axis. Must be a positive value.</param>
+		/// <param name="lengthZ">The length of the box along the Z-axis. Must be a positive value.</param>
 		/// <param name="center">The center point of the box, specified as an XYZ coordinate.</param>
-		public Box(double xDimension, double yDimension, double zDimension, XYZ center) : this()
+		public Box(double lengthX, double lengthY, double lengthZ, XYZ center) : this()
 		{
-			this.LengthX = xDimension;
-			this.LengthY = yDimension;
-			this.LengthZ = zDimension;
+			this.LengthX = lengthX;
+			this.LengthY = lengthY;
+			this.LengthZ = lengthZ;
 			this.Center = center;
 		}
 
@@ -93,7 +93,10 @@ private void createFace(
 			int index0, int index1, int index2,
 			int dir1, int dir2,
 			double length, double height, double width,
-			List<XYZ> vertices, List<XYZ> normals, List<XY> uvs, List<Quad> polygons,
+			List<XYZ> vertices, 
+			List<XYZ> normals, 
+			List<XY> uvs, 
+			List<Quad> polygons,
 			ref int currQuad)
 		{
 			//Creates a face with no shared vertices

samples/in/glb-gltf/sample_basic_box.glb samples/in/gltf/sample_basic_box.glbsamples/in/glb-gltf/sample_basic_box.glb renamed to samples/in/gltf/sample_basic_box.glb

@@ -0,0 +1,7 @@
+namespace MeshIO.Formats;
+
+public enum ContentType
+{
+	Binary,
+	ASCII,
+}

samples/in/glb-gltf/sample_basic_box.gltf samples/in/gltf/sample_basic_box.gltfsamples/in/glb-gltf/sample_basic_box.gltf renamed to samples/in/gltf/sample_basic_box.gltf

@@ -4,21 +4,44 @@
 
 namespace MeshIO.Formats.Fbx
 {
-	public class FbxReader : ReaderBase
+	/// <summary>
+	/// Provides functionality for reading and parsing FBX files or streams into scene objects.
+	/// </summary>
+	/// <remarks>
+	/// The <see cref="FbxReader"/> supports reading FBX data from both file paths and streams. It exposes options for
+	/// controlling the reading process via the Options property. Notifications and warnings encountered during reading can
+	/// be handled by subscribing to the OnNotification event or by providing a notification handler.
+	/// </remarks>
+	public class FbxReader : SceneReader
 	{
+		/// <summary>
+		/// Gets the options used to control the behavior of the FBX reader.
+		/// </summary>
+		/// <remarks>Use this property to configure how FBX files are read, such as specifying import settings or
+		/// handling of specific data types. The options are read-only; to modify them, update the properties of the returned
+		/// <see cref="FbxReaderOptions"/> instance.</remarks>
 		public FbxReaderOptions Options { get; } = new FbxReaderOptions();
 
 		/// <summary>
-		/// Initializes a new instance of the <see cref="FbxReader"/> class for the specified file.
+		/// Initializes a new instance of the FbxReader class for reading FBX files from the specified path.
 		/// </summary>
-		/// <param name="path">The complete file path to read from</param>
-		public FbxReader(string path) : base(File.OpenRead(path)) { }
+		/// <param name="path">The file system path to the FBX file to be read. Cannot be null or empty.</param>
+		/// <param name="notification">An optional delegate to receive notifications or warnings during the reading process. If null, notifications are not
+		/// raised.</param>
+		public FbxReader(string path, NotificationEventHandler notification = null)
+			: base(path, notification) { }
 
 		/// <summary>
-		/// Initializes a new instance of the <see cref="FbxReader"/> class for the specified stream.
+		/// Initializes a new instance of the FbxReader class to read FBX data from the specified stream.
 		/// </summary>
-		/// <param name="stream">The stream to read from</param>
-		public FbxReader(Stream stream) : base(stream) { }
+		/// <remarks>The caller is responsible for managing the lifetime of the provided stream. The FbxReader does not
+		/// close or dispose the stream when finished.</remarks>
+		/// <param name="stream">The input stream containing FBX data to be read. The stream must be readable and positioned at the start of the FBX
+		/// content.</param>
+		/// <param name="notification">An optional event handler for receiving notifications or warnings during the reading process. If null, notifications
+		/// are not raised.</param>
+		public FbxReader(Stream stream, NotificationEventHandler notification = null)
+			: base(stream, notification) { }
 
 		/// <summary>
 		/// Read a fbx file into an scene
@@ -52,17 +75,15 @@ public static Scene Read(Stream stream, NotificationEventHandler notificationHan
 		public FbxRootNode Parse()
 		{
 			FbxRootNode root;
-			using (IFbxParser parser = getParser(this._stream, this.Options))
+			using (IFbxParser parser = getParser(this._stream.Stream, this.Options))
 			{
 				root = parser.Parse();
 			}
 
 			return root;
 		}
 
-		/// <summary>
-		/// Read the FBX file
-		/// </summary>
+		/// <inheritdoc/>
 		public override Scene Read()
 		{
 			FbxRootNode root = this.Parse();
@@ -87,4 +108,4 @@ private static IFbxParser getParser(Stream stream, FbxReaderOptions options)
 			return parser;
 		}
 	}
-}
+}

samples/in/glb-gltf/sample_glb.glb samples/in/gltf/sample_glb.glbsamples/in/glb-gltf/sample_glb.glb renamed to samples/in/gltf/sample_glb.glb

@@ -1,5 +1,4 @@
-using MeshIO.Core;
-using MeshIO.Formats.Fbx.Connections;
+using MeshIO.Formats.Fbx.Connections;
 using MeshIO.Formats.Fbx.Templates;
 using System;
 using System.Collections.Generic;