Performance optimization

Author: marcelzwiers

bidscoin/plugins/__init__.py

@@ -266,7 +266,7 @@ def eventstable(self) -> pd.DataFrame:
                 df['onset'] -= df['onset'][start].iloc[0]                   # Take the time of the first occurrence as zero
 
         # Loop over the row groups to filter/edit the rows
-        rows = pd.Series([len(self.rows) == 0] * len(df), index=df.index)   # All rows are True if no row expressions were specified
+        rows = pd.Series(len(self.rows) == 0, index=df.index)               # All rows are True if no row expressions were specified
         for group in self.rows:                                             # With a group the expressions are AND between groups they are OR
 
             rowgroup = pd.Series(True, index=df.index)

bidscoin/plugins/events2bids.py

@@ -369,7 +369,7 @@ def add_started(time, started: float):
                 if (stopped := f"{event}.stopped") in df:
                     duration = df[stopped] - df[started]
                 else:
-                    duration = pd.Series([float('nan')] * len(df), index=df.index)
+                    duration = pd.Series(pd.NA, index=df.index)
                 df_piv_ = pd.DataFrame({'onset': onset, 'duration': duration, 'event_type': [event]*len(df)}, index=df.index).dropna(subset=['onset'])
                 df_misc = df.filter(regex=r'^(?!.*\.(started|stopped)$)').loc[df_piv_.index,:]  # Drop all columns that end with '.started', '.stopped'
                 if not df_piv_.empty:                                           # Only concatenate if df_piv_ has data