Skip to content

Commit 9996728

Browse files
committed
also store app version in data object
1 parent 02a7f64 commit 9996728

File tree

6 files changed

+10
-11
lines changed

6 files changed

+10
-11
lines changed

index.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,7 @@ window.addEventListener('keydown', (event) => {
5656
// add model to store
5757
import modelData from './models/circle_error.d3sketch';
5858
import JSONToSketchData from './src/shape/JSONToSketchData.js';
59-
const { data, appVersion } = JSON.parse(modelData);
60-
JSONToSketchData({ data }, appVersion).then(sketch => {
59+
JSONToSketchData(JSON.parse(modelData)).then(sketch => {
6160
store.dispatch(actions.openSketch(sketch));
6261
});
6362

src/components/App.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,8 @@ class App extends React.Component {
9999
case 'D3SKETCH':
100100
case 'JSON':
101101
const url = URL.createObjectURL(file);
102-
const { data, appVersion } = await fetch(url).then(result => result.json());
103-
const sketchData = await JSONToSketchData(data, appVersion);
102+
const data = await fetch(url).then(result => result.json());
103+
const sketchData = await JSONToSketchData(data);
104104
openSketch(sketchData);
105105
break;
106106
case 'JPG':

src/components/DoodlePreview.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ class DoodlePreview extends React.Component {
4848
async componentDidMount() {
4949
let { docData, sketchData } = this.props;
5050

51-
if (docData) sketchData = await JSONToSketchData(docData.data, docData.appVersion);
51+
if (docData) sketchData = await JSONToSketchData(docData);
5252

5353
const { canvas } = this.refs;
5454

src/shape/JSONToSketchData.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,12 +68,12 @@ function revive(appVersion, key, value) {
6868
return value;
6969
}
7070

71-
export default async function JSONToSketchData(data, appVersion) {
71+
export default async function JSONToSketchData({ data, appVersion }) {
7272
let sketchData;
7373
if (semver.gt(appVersion, '0.17.4')) {
7474
sketchData = reviveObject(data, (key, value) => revive(appVersion, key, value));
7575
} else {
76-
sketchData = JSON.parse(data.data, (key, value) => revive(appVersion, key, value));
76+
sketchData = JSON.parse(data, (key, value) => revive(appVersion, key, value));
7777
}
7878
sketchData = await recursivePromiseApply(sketchData);
7979

src/shape/docToFile.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@ export default async function docToFile(db, doc, { image = false, sketch = false
99
author: doc.author,
1010
id: doc._id,
1111
createdOn: doc.createdOn,
12-
updatedOn: doc.updatedOn,
13-
appVersion: doc.appVersion
12+
updatedOn: doc.updatedOn
1413
};
1514
if (doc.class) response.class = doc.class;
1615

@@ -28,7 +27,7 @@ export default async function docToFile(db, doc, { image = false, sketch = false
2827
}
2928
const data = await blobToJSON(doc._attachments.sketch.data);
3029

31-
response.data = await JSONToSketchData(data, appVersion);
30+
response.data = await JSONToSketchData(data);
3231
} else {
3332
const data = { data: doc.data, appVersion };
3433
response.data = await JSONToSketchData(data);

src/shape/sketchDataToJSON.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { vectorArrayToBase64, imageToBase64 } from '../utils/binaryUtils.js';
2+
import { VERSION } from '../constants/general.js';
23

34
function createShapeData(shape) {
45
shape = { ...shape };
@@ -59,5 +60,5 @@ export default function sketchDataToJSON({ objectsById, spaces }) {
5960
}
6061
}
6162

62-
return data;
63+
return { data, appVersion: VERSION };
6364
}

0 commit comments

Comments
 (0)