Skip to content

Commit 5f1e628

Browse files
committed
add 'name' to slice function and fix gcode object/string
1 parent a1b4a9c commit 5f1e628

File tree

4 files changed

+11
-9
lines changed

4 files changed

+11
-9
lines changed

index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const jsonLoader = new THREE.JSONLoader();
2424
jsonLoader.load(fileURL, geometry => {
2525
render((
2626
<MuiThemeProvider>
27-
<Interface geometry={geometry}/>
27+
<Interface geometry={geometry} name="Doodle3D"/>
2828
</MuiThemeProvider>
2929
), document.getElementById('app'));
3030
});

src/interface/Settings.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class Settings extends React.Component {
3030
classes: PropTypes.objectOf(PropTypes.string),
3131
onChange: PropTypes.func,
3232
printers: PropTypes.object.isRequired,
33-
defaultPrinter: PropTypes.string.isRequired,
33+
defaultPrinter: PropTypes.string,
3434
quality: PropTypes.object.isRequired,
3535
defaultQuality: PropTypes.string.isRequired,
3636
material: PropTypes.object.isRequired,

src/interface/index.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -85,24 +85,25 @@ class Interface extends React.Component {
8585
classes: PropTypes.objectOf(PropTypes.string),
8686
defaultSettings: PropTypes.object.isRequired,
8787
printers: PropTypes.object.isRequired,
88-
defaultPrinter: PropTypes.string.isRequired,
88+
defaultPrinter: PropTypes.string,
8989
quality: PropTypes.object.isRequired,
9090
defaultQuality: PropTypes.string.isRequired,
9191
material: PropTypes.object.isRequired,
9292
defaultMaterial: PropTypes.string.isRequired,
9393
pixelRatio: PropTypes.number.isRequired,
94-
onCancel: PropTypes.func
94+
onCancel: PropTypes.func,
95+
name: PropTypes.string.isRequired
9596
};
9697

9798
static defaultProps = {
9899
defaultSettings: baseSettings,
99100
printers: printerSettings,
100-
defaultPrinter: 'ultimaker2',
101101
quality: qualitySettings,
102102
defaultQuality: 'medium',
103103
material: materialSettings,
104104
defaultMaterial: 'pla',
105-
pixelRatio: 1
105+
pixelRatio: 1,
106+
name: 'Doodle3D'
106107
};
107108

108109
constructor(props) {
@@ -177,13 +178,14 @@ class Interface extends React.Component {
177178

178179
slice = async () => {
179180
const { mesh, settings, isSlicing, printers, quality, material } = this.state;
181+
const { name } = this.props;
180182

181183
if (isSlicing) return;
182184

183185
this.setState({ isSlicing: true, progress: { action: '', slicing: 0, uploading: 0 }, error: null });
184186

185187
try {
186-
await slice(mesh, settings, printers, quality, material, progress => {
188+
await slice(name, mesh, settings, printers, quality, material, progress => {
187189
this.setState({ progress: { ...this.state.progress, ...progress } });
188190
});
189191
} catch (error) {

src/interface/utils.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ export function fetchProgress(url, { method = 'get', headers = {}, body = {} } =
105105
const GCODE_SERVER_URL = 'https://gcodeserver.doodle3d.com';
106106
const CONNECT_URL = 'http://connect.doodle3d.com/';
107107

108-
export async function slice(mesh, settings, printers, quality, material, updateProgress) {
108+
export async function slice(name, mesh, settings, printers, quality, material, updateProgress) {
109109
const { dimensions } = settings;
110110
const centerX = dimensions.x / 2;
111111
const centerY = dimensions.y / 2;
@@ -114,7 +114,7 @@ export async function slice(mesh, settings, printers, quality, material, updateP
114114
mesh.updateMatrix();
115115

116116
const matrix = new THREE.Matrix4().makeTranslation(centerY, 0, centerX).multiply(mesh.matrix);
117-
const gcode = await sliceGeometry(settings, geometry, matrix, false, false, ({ progress }) => {
117+
const { gcode } = await sliceGeometry(settings, geometry, matrix, false, false, ({ progress }) => {
118118
updateProgress({
119119
action: progress.action,
120120
slicing: progress.done / progress.total

0 commit comments

Comments
 (0)