Skip to content

Report more accurate printing progress #34

@woutgg

Description

@woutgg

With GCode buffering improvements currently being integrated, it becomes possible for clients to set the total of lines to be buffered beforehand.
To report more accurate progress (esp. with large prints), it would be good to use this number (if set by client) instead of current behaviour where the number of buffered lines so far is used.

A possible implementation would be to (don't mind the naming proposals):

  • rename getTotalLines() to getTotalAppendedLines(),
  • create new function (e.g., getGrandTotalLines) which returns sequenceTotal_ if set, or getTotalAppendedLines() otherwise.
    The new function would then be used for progress reports.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions