"don't await on Task.FromResult" analyzer and code fix

[tugberkugurlu]

This is sad but yes, I have seen usages of this 😄 More info is available as a blog post. Also, have a look at AsyncPackage sample inside Roslyn code base to get an idea of how an async analyzer can be implemented.

[sharwell]

The AsyncPackage sample is actually overly complicated for this case. You can just register a syntax analyzer for an AwaitExpression.

[tugberkugurlu]

Yes, right.

BTW, do you know how that AsyncPackage will end up? They didn't ship it and I was thinking that it would be more meaningful to have all async specific diagnostics inside one package/VSIX and refactoring + diagnostics inside one VSIX.