Fill in missing types

[joshmedeski]

There are some missing types that I would like to get defined or change to String

window_close_confirmation is just one that's has undefined types, using an LSP it should be easy to find which ones are missing and fill in the gaps.

[gonstoll]

Hey @joshmedeski, I have a fork here where this should be working properly. Planning to make a PR here with more types, just don't know how quick it'll be approved 🤷

[joshmedeski]

Thanks, I'll check out your fork

[justinsgithub]

@gonstoll I am sadly no longer doing anything software-related at the moment. Not sure when I will get back into it. I added you as a collaborator if you would like to takeover this project.

[DrKJeff16]

@gonstoll @joshmedeski

Currently working on extending the type annotations, among other fixes.
Credits for PRs that are not mine are at the bottom

Progress so far

• fix!: Format with StyLua, annotations fixed, moved types directory #4
• feat(pre-commit): Added config file for pre-commit. #5
• fix: Polished a bunch of already existing annotations #6
• feat(wezterm): Lots of documentation for types.wezterm and more #7
• [BRANCH SWITCH] Lots of documentation for types.wezterm and more #8
• fix(init): Solving issue #9 . #11
• feat: Added CODEOWNERS file. #12
• docs: Improved README.md syntax and instructions. #13
• docs: Annotated Window, MuxTabObj and SpawnCommand. #14
• fix(init): Improved annotations for colour palettes and related. #15
• chore(wezterm): Moved all submodules to a directory. #16
• Gave maintenance to ExecDomain, LocalProcessInfo, MuxDomain #17
• fix(init): Fixed faulty bool definition, added/fixed descriptions. #18
• Generated PaneInformation object, renamed MuxTabObj to MuxTab #19
• fix(objects)!: More object types reworked. #20
• Corrected harfbuzz_features inclusion into FontAttributes #21
• Harfbuzz dealt with. #22
• CopyMode enum, gitignore suggestion, other docs fixed. #24
• fix(events): Fully documented gui.lua and multiplexer.lua #25
• fix: multiple return values in functions don't require brackets #26
• PROPOSAL: Add a StyLua workflow check for new commits. #27
• Finished WindowEvents and documented all events. #28
• Documentation tweaks, types/init.lua corrections started #29
• Partial overhaul for types/config.lua #30
• Remove user config file wezterm.lua #31
• Add demonstrative GIF to README.md #32
• [REFACTOR] Moved files, removed a lot of useless types #33
• fix: allow_square_glyphs_to_overflow_width wrong value #34
• .luarc.json cleanup #35
• feat: Add credits to collaborators and maintainers in README.md. #36
• [REPO] Issue Templates #38
• Respect .gitignore by deleting scripts/ directory. #39
• feat: add config.leader and document it #40
• [CONFIG] Further Config class documentation #41

---

Credits

#26 - @TheLeoP
#31 , #34 , #35 , #40 - @craigmac

[DrKJeff16]

@gonstoll I am sadly no longer doing anything software-related at the moment. Not sure when I will get back into it. I added you as a collaborator if you would like to takeover this project.

@joshmedeski If you agree, I am interested in being a collaborator aswell. I'll obviously consult with
you and the others if warranted.

And yes, no default branch pushing without PRs.

SEE #3 (comment)

[joshmedeski]

I don't touch my config too often, so this isn't a high priority for me.

But if you want support let me know. It would be nice if we could ultimately integrate this into the wezterm project.

[DrKJeff16]

I don't touch my config too often, so this isn't a high priority for me.

But if you want support let me know. It would be nice if we could ultimately integrate this into the wezterm project.

Oh I had no intentions to touch your config file at all. I was refering mostly to repository management

SEE #3 (comment)

[joshmedeski]

I just mean i'm not interacting with wezterm types now that I've gotten my setup the way I want it.

But I am willing to help with repo management of the types 🙏

[DrKJeff16]

Oh yeah, I understand your position:

@gonstoll I am sadly no longer doing anything software-related at the moment. Not sure when I will get back into it. I added you as a collaborator if you would like to takeover this project.

Rest assured I won't ask anything code-related unless absolutely necessary. I am just willing to maintain this as support for your efforts!

SEE #3 (comment)

[joshmedeski]

This project is owned by @justinsgithub, he'll have to make you a maintainer, sounds like you and/or @gonstoll should partner up and decide if you want to for this project and start your own version or get more support from @justinsgithub on this.

[DrKJeff16]

@joshmedeski

Man... why did I confuse you with the owner earlier?
Just because of the j at the start?

You'll think I'm toying with you but no, I'm dead serious, and for that I owe both you and the owner an apology

[DrKJeff16]

Also, @joshmedeski , do you still have missing types from main?
I contributed a bunch to it recently and I think I covered the gaps (before the polishing).

P.S. Sorry for so many @'s

[joshmedeski]

I have what I need, thanks! Hopefully @justinsgithub is open to having you join the maintainers of this repo.