Merge pull request #21 from DrSkillIssue/fix/lint-warnings

fix: resolve ESLint warnings in test utilities and cross-file test suites

Author: DrSkillIssue

packages/ganko/test/cross-file/layout-cls-rules.test.ts

@@ -1,4 +1,4 @@
-import { describe, expect, it } from "vitest"
+import { afterAll, describe, expect, it } from "vitest"
 import type { Diagnostic } from "../../src/diagnostic"
 import { analyzeCrossFileInput } from "../../src/cross-file"
 import { parseCode } from "../solid/test-utils"
@@ -14,6 +14,7 @@ interface CssFixture {
  * The SolidInput is created lazily on first access and cached for reuse.
  */
 const tsxToSolidInput = new Map<string, ReturnType<typeof parseCode>>()
+afterAll(() => tsxToSolidInput.clear())
 let batchFileCounter = 0
 
 function getOrCreateSolidInput(tsx: string): ReturnType<typeof parseCode> {

packages/ganko/test/cross-file/layout-sibling-alignment-conditional-evidence.test.ts

@@ -1,9 +1,10 @@
-import { describe, expect, it } from "vitest";
+import { afterAll, describe, expect, it } from "vitest";
 import type { Diagnostic } from "../../src/diagnostic";
 import { analyzeCrossFileInput, getLatestLayoutPerfStatsForTest } from "../../src/cross-file";
 import { parseCode } from "../solid/test-utils";
 
 const _ceCache = new Map<string, ReturnType<typeof parseCode>>()
+afterAll(() => _ceCache.clear())
 let _ceFC = 0
 
 function runRule(tsx: string, css: string): readonly Diagnostic[] {

packages/ganko/test/cross-file/layout-sibling-alignment-context.test.ts

@@ -1,5 +1,5 @@
 import { noopLogger } from "@drskillissue/ganko-shared";
-import { describe, expect, it } from "vitest";
+import { afterAll, describe, expect, it } from "vitest";
 import type { Diagnostic } from "../../src/diagnostic";
 import { analyzeCrossFileInput, buildLayoutGraph, collectAlignmentCases, evaluateAlignmentCase, ContextCertainty } from "../../src/cross-file";
 import { buildSolidGraph } from "../../src/solid/plugin";
@@ -12,6 +12,7 @@ interface CssFixture {
 }
 
 const _ctxCache = new Map<string, ReturnType<typeof parseCode>>()
+afterAll(() => _ctxCache.clear())
 let _ctxFC = 0
 
 function runRule(tsx: string, files: readonly CssFixture[]): readonly Diagnostic[] {

packages/ganko/test/cross-file/layout-sibling-alignment-determinism.test.ts

@@ -1,4 +1,4 @@
-import { describe, expect, it } from "vitest";
+import { afterAll, describe, expect, it } from "vitest";
 import type { Diagnostic } from "../../src/diagnostic";
 import type { SolidInput } from "../../src/solid/input";
 import { analyzeCrossFileInput } from "../../src/cross-file";
@@ -10,6 +10,7 @@ interface CssFixture {
 }
 
 const _detCache = new Map<string, ReturnType<typeof parseCode>>()
+afterAll(() => _detCache.clear())
 let _detFC = 0
 
 function runRule(tsx: string, files: readonly CssFixture[]): readonly Diagnostic[] {

packages/ganko/test/cross-file/layout-sibling-alignment-policy-semantics.test.ts

@@ -1,5 +1,5 @@
 import { noopLogger } from "@drskillissue/ganko-shared";
-import { describe, expect, it } from "vitest";
+import { afterAll, describe, expect, it } from "vitest";
 import type { Diagnostic } from "../../src/diagnostic";
 import {
   analyzeCrossFileInput,
@@ -27,6 +27,7 @@ import { alignmentPolicyCalibration } from "../../src/cross-file/layout/calibrat
 import { parseCode } from "../solid/test-utils";
 
 const _psCache = new Map<string, ReturnType<typeof parseCode>>()
+afterAll(() => _psCache.clear())
 let _psFC = 0
 
 function runRule(tsx: string, css: string): readonly Diagnostic[] {

packages/ganko/test/cross-file/layout-sibling-alignment-rule.test.ts

@@ -1,4 +1,4 @@
-import { describe, expect, it } from "vitest";
+import { afterAll, describe, expect, it } from "vitest";
 import type { Diagnostic } from "../../src/diagnostic";
 import { analyzeCrossFileInput } from "../../src/cross-file";
 import { getLatestLayoutPerfStatsForTest } from "../../src/cross-file";
@@ -13,6 +13,7 @@ interface CssFixture {
 }
 
 const tsxCache = new Map<string, ReturnType<typeof parseCode>>();
+afterAll(() => tsxCache.clear())
 let fileCounter = 0;
 
 function runRule(tsx: string, css: string | readonly CssFixture[]): readonly Diagnostic[] {

packages/ganko/test/solid/test-utils.ts

@@ -23,6 +23,7 @@ const defaultHost = ts.createCompilerHost(compilerOptions)
  * immutable so parsing them once and reusing across all ts.createProgram
  * invocations is safe and eliminates the dominant cost per call (~100 lib files).
  */
+const MODULE_MARKER_RE = /export |import /
 const LIB_CACHE_MAX = 200
 const libSourceFileCache = new Map<string, ts.SourceFile | undefined>()
 
@@ -40,9 +41,9 @@ let lastProgram: ts.Program | null = null
  * Falls back to the real filesystem for lib files (e.g. lib.d.ts).
  * Uses oldProgram for incremental reuse of lib SourceFiles and checker state.
  */
-export function createTestProgram(files: Record<string, string>): ts.Program {
+export function createTestProgram(files: Map<string, string>): ts.Program {
   const fileMap = new Map<string, string>()
-  for (const [key, value] of Object.entries(files)) {
+  for (const [key, value] of files) {
     fileMap.set(resolve(key), value)
   }
 
@@ -84,7 +85,7 @@ export function createTestProgram(files: Record<string, string>): ts.Program {
  */
 export function parseCode(code: string, filePath = "test.tsx"): SolidInput {
   const resolvedPath = resolve(filePath)
-  const program = createTestProgram({ [filePath]: code })
+  const program = createTestProgram(new Map([[filePath, code]]))
   return createSolidInput(resolvedPath, program)
 }
 
@@ -139,25 +140,28 @@ export function createRuleBatch(
   // Build a single program with all snippets as separate virtual files.
   // Each snippet gets `export {}` appended to force TypeScript module mode,
   // ensuring separate module scopes (no global variable collisions).
-  const fileMap: Record<string, string> = {}
+  const fileMap = new Map<string, string>()
   for (let i = 0; i < snippets.length; i++) {
     const code = snippets[i]!
     // Only add export {} if the snippet doesn't already have an export/import
-    const needsModuleMarker = !code.includes("export ") && !code.includes("import ")
-    fileMap[`batch_${i}.tsx`] = needsModuleMarker ? code + "\nexport {}" : code
+    const needsModuleMarker = !MODULE_MARKER_RE.test(code)
+    fileMap.set(`batch_${i}.tsx`, needsModuleMarker ? code + "\nexport {}" : code)
   }
   const program = createTestProgram(fileMap)
 
   // Build SolidGraph and run rule for each file independently
   const results: RuleTestResult[] = []
+  const collector: { target: Diagnostic[] | null } = { target: null }
+  const collect = (d: Diagnostic) => collector.target!.push(d)
   for (let i = 0; i < snippets.length; i++) {
     const filePath = resolve(`batch_${i}.tsx`)
     const input = createSolidInput(filePath, program)
     const graph = buildSolidGraph(input)
     const diagnostics: Diagnostic[] = []
     const setup = setupPerSnippet?.[i]
     if (setup) setup()
-    rule.check(graph, (d) => diagnostics.push(d))
+    collector.target = diagnostics
+    rule.check(graph, collect)
     results.push({ diagnostics, graph, code: snippets[i]! })
   }
 
@@ -250,12 +254,12 @@ export function lazyParseBatch(): {
     },
     result(index: number): SolidInput {
       if (results === null) {
-        const fileMap: Record<string, string> = {}
+        const fileMap = new Map<string, string>()
         for (let i = 0; i < entries.length; i++) {
           const entry = entries[i]!
           const code = entry.code
-          const needsModuleMarker = !code.includes("export ") && !code.includes("import ")
-          fileMap[entry.filePath] = needsModuleMarker ? code + "\nexport {}" : code
+          const needsModuleMarker = !MODULE_MARKER_RE.test(code)
+          fileMap.set(entry.filePath, needsModuleMarker ? code + "\nexport {}" : code)
         }
         const program = createTestProgram(fileMap)
         results = []