Skip to content

Commit 2beccc5

Browse files
committed
[Exchanges] fix stop crash after ccxt update
1 parent b575633 commit 2beccc5

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

octobot_trading/exchanges/exchange_manager.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -144,10 +144,13 @@ async def stop(self, warning_on_missing_elements=True, enable_logs=True):
144144
await self.exchange.stop()
145145
except Exception as err:
146146
self.logger.exception(err, True, f"Error when stopping exchange: {err}")
147-
exchanges.Exchanges.instance().del_exchange(
148-
self.exchange.name, self.id, should_warn=warning_on_missing_elements
149-
)
150-
self.exchange.exchange_manager = None
147+
if self.exchange is not None:
148+
# ensure self.exchange still exists as await self.exchange.stop()
149+
# internally uses asyncio.sleep within ccxt
150+
exchanges.Exchanges.instance().del_exchange(
151+
self.exchange.name, self.id, should_warn=warning_on_missing_elements
152+
)
153+
self.exchange.exchange_manager = None
151154
self.exchange = None
152155
if self.exchange_personal_data is not None:
153156
try:

0 commit comments

Comments
 (0)