[Typo] fix relised/realized typo and rename enums

tmp

Author: techfreaque

CHANGELOG.md

@@ -268,7 +268,7 @@ No change, pypi issue version
 - [Transaction] class
 - [TransactionsManager] class
 - [TransactionsManager] factory
-- [TransactionsManager] transfer, blockchain, fee and realised_pnl
+- [TransactionsManager] transfer, blockchain, fee and realized_pnl
 
 ### Fixed
 - [Positions] missing mark_price fetching

octobot_trading/enums.py

@@ -118,8 +118,8 @@ class TransactionType(enum.Enum):
     BLOCKCHAIN_WITHDRAWAL = "blockchain_withdrawal"
     FUNDING_FEE = "funding_fee"
     TRADING_FEE = "trading_fee"
-    REALISED_PNL = "realised_pnl"
-    CLOSE_REALISED_PNL = "close_realised_pnl"
+    REALIZED_PNL = "realized_pnl"
+    CLOSE_REALIZED_PNL = "close_realized_pnl"
     TRANSFER = "transfer"
 
 
@@ -162,6 +162,7 @@ class PositionMode(enum.Enum):
 
 class ExchangeConstantsFundingColumns(enum.Enum):
     SYMBOL = "symbol"
+    TIMESTAMP = "timestamp"
     LAST_FUNDING_TIME = "last_funding_time"
     FUNDING_RATE = "funding_rate"
     NEXT_FUNDING_TIME = "next_funding_time"
@@ -301,8 +302,8 @@ class ExchangeConstantsOrderColumns(enum.Enum):
     PRICE = "price"
     AMOUNT = "amount"
     COST = "cost"
-    AVERAGE = "average"
-    FILLED = "filled"
+    FILLED_AMOUNT = "filled_amount"
+    FILLED_PRICE = "filled_price"
     REMAINING = "remaining"
     STATUS = "status"
     FEE = "fee"
@@ -314,9 +315,10 @@ class ExchangeConstantsOrderColumns(enum.Enum):
     REDUCE_ONLY = "reduceOnly"
     STOP_PRICE = "stopPrice"
     TRIGGER_ABOVE = "triggerAbove"
+    TIME_IN_FORCE = "timeInForce"
     TAG = "tag"
-
-
+    
+    
 class ExchangeConstantsPositionColumns(enum.Enum):
     ID = "id"
     TIMESTAMP = "timestamp"
@@ -325,12 +327,12 @@ class ExchangeConstantsPositionColumns(enum.Enum):
     MARK_PRICE = "mark_price"
     LIQUIDATION_PRICE = "liquidation_price"
     BANKRUPTCY_PRICE = "bankruptcy_price"
-    UNREALIZED_PNL = "unrealised_pnl"   # unrealised_pnl on Bybit api and unrealized_pnl on exchange UI
-    REALISED_PNL = "realised_pnl"
+    UNREALIZED_PNL = "unrealized_pnl"  # unrealized_pnl on Bybit api and unrealized_pnl on exchange UI
+    REALIZED_PNL = "realized_pnl"
     CLOSING_FEE = "closing_fee"
-    QUANTITY = "quantity"
+    SINGLE_CONTRACT_VALUE = "single_contract_value"
     SIZE = "size"
-    NOTIONAL = "notional"
+    VALUE = "position_value"
     INITIAL_MARGIN = "initial_margin"
     COLLATERAL = "collateral"
     LEVERAGE = "leverage"

octobot_trading/exchanges/connectors/ccxt/ccxt_adapter.py

@@ -177,24 +177,27 @@ def parse_position(self, fixed, **kwargs):
                 enums.ExchangeConstantsPositionColumns.SIDE.value: position_side,
                 enums.ExchangeConstantsPositionColumns.MARGIN_TYPE.value:
                     fixed.get(ccxt_enums.ExchangePositionCCXTColumns.MARGIN_TYPE.value, None),
-                enums.ExchangeConstantsPositionColumns.QUANTITY.value:
+                enums.ExchangeConstantsPositionColumns.SINGLE_CONTRACT_VALUE.value:
                     decimal.Decimal(
-                        f"{fixed.get(ccxt_enums.ExchangePositionCCXTColumns.CONTRACT_SIZE.value, 0)}"),
+                        f"{fixed.get(ccxt_enums.ExchangePositionCCXTColumns.CONTRACT_SIZE.value, 1)}"),
+                enums.ExchangeConstantsPositionColumns.SIZE.value:
+                    decimal.Decimal(
+                        f"{fixed.get(ccxt_enums.ExchangePositionCCXTColumns.CONTRACTS.value, 0)}"),
                 enums.ExchangeConstantsPositionColumns.COLLATERAL.value:
                     decimal.Decimal(
                         f"{fixed.get(ccxt_enums.ExchangePositionCCXTColumns.COLLATERAL.value, 0)}"),
-                enums.ExchangeConstantsPositionColumns.NOTIONAL.value:
+                enums.ExchangeConstantsPositionColumns.VALUE.value:
                     decimal.Decimal(
                         f"{fixed.get(ccxt_enums.ExchangePositionCCXTColumns.NOTIONAL.value, 0)}"),
                 enums.ExchangeConstantsPositionColumns.LEVERAGE.value:
                     decimal.Decimal(
                         f"{fixed.get(ccxt_enums.ExchangePositionCCXTColumns.LEVERAGE.value, 0)}"),
                 enums.ExchangeConstantsPositionColumns.UNREALIZED_PNL.value:
                     decimal.Decimal(
-                        f"{fixed.get(ccxt_enums.ExchangePositionCCXTColumns.UNREALISED_PNL.value, 0)}"),
-                enums.ExchangeConstantsPositionColumns.REALISED_PNL.value:
+                        f"{fixed.get(ccxt_enums.ExchangePositionCCXTColumns.UNREALIZED_PNL.value, 0)}"),
+                enums.ExchangeConstantsPositionColumns.REALIZED_PNL.value:
                     decimal.Decimal(
-                        f"{fixed.get(ccxt_enums.ExchangePositionCCXTColumns.REALISED_PNL.value, 0)}"),
+                        f"{fixed.get(ccxt_enums.ExchangePositionCCXTColumns.REALIZED_PNL.value, 0)}"),
                 enums.ExchangeConstantsPositionColumns.LIQUIDATION_PRICE.value:
                     decimal.Decimal(
                         f"{fixed.get(ccxt_enums.ExchangePositionCCXTColumns.LIQUIDATION_PRICE.value, 0)}"),

octobot_trading/exchanges/connectors/ccxt/enums.py

@@ -22,8 +22,9 @@ class ExchangeConstantsCCXTColumns(enum.Enum):
 
 
 class ExchangePositionCCXTColumns(enum.Enum):
-    CONTRACTS = "contracts"
-    CONTRACT_SIZE = "contractSize"
+    ID = "id"
+    CONTRACTS = "contracts"  # == ExchangeConstantsPositionColumn.SIZE
+    CONTRACT_SIZE = "contractSize"  # == ExchangeConstantsPositionColumns.SINGLE_CONTRACT_VALUE
     MARGIN_TYPE = "marginType"
     MARGIN_MODE = "marginMode"
     LEVERAGE = "leverage"
@@ -33,10 +34,10 @@ class ExchangePositionCCXTColumns(enum.Enum):
     INITIAL_MARGIN_PERCENTAGE = "initialMarginPercentage"
     MAINTENANCE_MARGIN = "maintenanceMargin"
     MAINTENANCE_MARGIN_PERCENTAGE = "maintenanceMarginPercentage"
-    NOTIONAL = "notional"
+    NOTIONAL = "notional"  # == ExchangeConstantsPositionColumn.VALUE
     MARGIN_RATIO = "marginRatio"
-    UNREALISED_PNL = "unrealizedPnl"
-    REALISED_PNL = "realizedPnl"
+    UNREALIZED_PNL = "unrealizedPnl"
+    REALIZED_PNL = "realizedPnl"
     LIQUIDATION_PRICE = "liquidationPrice"
     MARK_PRICE = "markPrice"
     ENTRY_PRICE = "entryPrice"

octobot_trading/exchanges/types/rest_exchange.py

@@ -386,7 +386,7 @@ async def get_order_from_trades(self, symbol, order_id, order_to_update=None):
                 order_to_update[ecoc.TIMESTAMP.value] = order_to_update.get(ecoc.TIMESTAMP.value,
                                                                             trade[ecoc.TIMESTAMP.value])
                 order_to_update[ecoc.STATUS.value] = enums.OrderStatus.FILLED.value
-                order_to_update[ecoc.FILLED.value] = trade[ecoc.AMOUNT.value]
+                order_to_update[ecoc.FILLED_AMOUNT.value] = trade[ecoc.AMOUNT.value]
                 order_to_update[ecoc.COST.value] = trade[ecoc.COST.value]
                 order_to_update[ecoc.REMAINING.value] = 0
                 order_to_update[ecoc.FEE.value] = trade[ecoc.FEE.value]

octobot_trading/personal_data/__init__.pxd

@@ -99,10 +99,10 @@ from octobot_trading.personal_data.transactions cimport (
     Transaction,
     BlockchainTransaction,
     FeeTransaction,
-    RealisedPnlTransaction,
+    RealizedPnlTransaction,
     TransferTransaction,
     create_blockchain_transaction,
-    create_realised_pnl_transaction,
+    create_realized_pnl_transaction,
     create_fee_transaction,
     create_transfer_transaction,
 )
@@ -189,10 +189,10 @@ __all__ = [
     "Transaction",
     "BlockchainTransaction",
     "FeeTransaction",
-    "RealisedPnlTransaction",
+    "RealizedPnlTransaction",
     "TransferTransaction",
     "create_blockchain_transaction",
-    "create_realised_pnl_transaction",
+    "create_realized_pnl_transaction",
     "create_fee_transaction",
     "create_transfer_transaction",
 ]

octobot_trading/personal_data/__init__.py

@@ -168,10 +168,10 @@
     Transaction,
     BlockchainTransaction,
     FeeTransaction,
-    RealisedPnlTransaction,
+    RealizedPnlTransaction,
     TransferTransaction,
     create_blockchain_transaction,
-    create_realised_pnl_transaction,
+    create_realized_pnl_transaction,
     create_fee_transaction,
     create_transfer_transaction,
 )
@@ -355,10 +355,10 @@
     "Transaction",
     "BlockchainTransaction",
     "FeeTransaction",
-    "RealisedPnlTransaction",
+    "RealizedPnlTransaction",
     "TransferTransaction",
     "create_blockchain_transaction",
-    "create_realised_pnl_transaction",
+    "create_realized_pnl_transaction",
     "create_fee_transaction",
     "create_transfer_transaction",
 ]

octobot_trading/personal_data/orders/order.py

@@ -509,7 +509,7 @@ def update_from_raw(self, raw_order):
             price = stop_price
         filled_price = decimal.Decimal(str(price))
         # set average price with real average price if available, use filled_price otherwise
-        average_price = decimal.Decimal(str(raw_order.get(enums.ExchangeConstantsOrderColumns.AVERAGE.value, 0.0)
+        average_price = decimal.Decimal(str(raw_order.get(enums.ExchangeConstantsOrderColumns.FILLED_PRICE.value, 0.0)
                                             or filled_price))
 
         return self.update(
@@ -519,7 +519,7 @@ def update_from_raw(self, raw_order):
             price=decimal.Decimal(str(price)),
             status=order_util.parse_order_status(raw_order),
             order_id=str(raw_order.get(enums.ExchangeConstantsOrderColumns.ID.value, None)),
-            quantity_filled=decimal.Decimal(str(raw_order.get(enums.ExchangeConstantsOrderColumns.FILLED.value, 0.0)
+            quantity_filled=decimal.Decimal(str(raw_order.get(enums.ExchangeConstantsOrderColumns.FILLED_AMOUNT.value, 0.0)
                                                 or 0.0)),
             filled_price=decimal.Decimal(str(filled_price)),
             average_price=decimal.Decimal(str(average_price)),
@@ -643,7 +643,7 @@ def to_dict(self):
             enums.ExchangeConstantsOrderColumns.AMOUNT.value: self.origin_quantity,
             enums.ExchangeConstantsOrderColumns.COST.value: self.total_cost,
             enums.ExchangeConstantsOrderColumns.QUANTITY_CURRENCY.value: self.quantity_currency,
-            enums.ExchangeConstantsOrderColumns.FILLED.value: self.filled_quantity,
+            enums.ExchangeConstantsOrderColumns.FILLED_AMOUNT.value: self.filled_quantity,
             enums.ExchangeConstantsOrderColumns.FEE.value: self.fee,
             enums.ExchangeConstantsOrderColumns.REDUCE_ONLY.value: self.reduce_only,
             enums.ExchangeConstantsOrderColumns.TAG.value: self.tag

octobot_trading/personal_data/orders/order_util.py

@@ -390,15 +390,15 @@ async def get_order_size_portfolio_percent(exchange_manager, order_amount, side,
                                  portfolio_type=commons_constants.PORTFOLIO_TOTAL)
     if exchange_manager.is_future:
         # TODO check inverse
-        if market_quantity is constants.ZERO:
+        if market_quantity == constants.ZERO:
             return constants.ZERO
         return min(order_amount / market_quantity, constants.ONE) * constants.ONE_HUNDRED
     if side is enums.TradeOrderSide.SELL:
-        if current_symbol_holding is constants.ZERO:
+        if current_symbol_holding == constants.ZERO:
             return constants.ZERO
         return min(order_amount / current_symbol_holding, constants.ONE) * constants.ONE_HUNDRED
     if side is enums.TradeOrderSide.BUY:
-        if current_market_holding is constants.ZERO:
+        if current_market_holding == constants.ZERO:
             return constants.ZERO
         return min(order_amount / market_quantity, constants.ONE) * constants.ONE_HUNDRED
     raise errors.InvalidArgumentError(f"Unhandled side: {side}")

octobot_trading/personal_data/portfolios/assets/future_asset.pxd

@@ -29,7 +29,7 @@ cdef class FutureAsset(asset_class.Asset):
     cpdef object set(self, object total=*, object available=*, object initial_margin=*, object position_margin=*,
                    object unrealized_pnl=*, object order_margin=*, object margin_balance=*)
     cpdef object set_unrealized_pnl(self, object unrealized_pnl)  # needs object to forward exceptions
-    cpdef object update_realised_pnl(self, object realized_pnl_update)  # needs object to forward exceptions
+    cpdef object update_realized_pnl(self, object realized_pnl_update)  # needs object to forward exceptions
 
     cdef object _update_total(self)
     cdef object _update_available(self)