wip

Author: GuillaumeDSM

octobot_trading/exchanges/traders/trader.py

@@ -405,8 +405,8 @@ async def update_order_as_inactive(
         self, order, ignored_order=None, wait_for_cancelling=True,
         cancelling_timeout=octobot_trading.constants.INDIVIDUAL_ORDER_SYNC_TIMEOUT
     ) -> bool:
-        if self.simulate:
-            self.logger.error(f"Can't update order as inactive on simulated trading.")
+        if not self.enable_inactive_orders:
+            self.logger.error(f"Can't update order as inactive when {self.enable_inactive_orders=}.")
             return False
         cancelled = False
         if order and order.is_open():
@@ -422,8 +422,8 @@ async def update_order_as_active(
         self, order, params: dict = None, wait_for_creation=True, raise_all_creation_error=False,
         creation_timeout=octobot_trading.constants.INDIVIDUAL_ORDER_SYNC_TIMEOUT
     ):
-        if self.simulate:
-            self.logger.error(f"Can't update order as active on simulated trading.")
+        if not self.enable_inactive_orders:
+            self.logger.error(f"Can't update order as active when {self.enable_inactive_orders=}.")
             return order
         with order.active_or_inactive_transition():
             return await self.create_order(

octobot_trading/personal_data/orders/order_group.py

@@ -71,6 +71,7 @@ def _default_active_order_swap_strategy(self, timeout: float) -> active_order_sw
         """
         Called when an order of this group is becoming active
         """
+        raise NotImplementedError("_default_active_order_swap_strategy is not implemented")
 
 
     async def enable(self, enabled):